From: Arnd Bergmann <arnd@arndb.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Greg Ungerer <gerg@uclinux.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: ks8695: fix __initdata annotation
Date: Tue, 09 Feb 2016 12:14:15 +0100 [thread overview]
Message-ID: <18237653.x9qPaNvtCU@wuerfel> (raw)
In-Reply-To: <20160209090030.GS13664@pengutronix.de>
On Tuesday 09 February 2016 10:00:30 Uwe Kleine-König wrote:
> > diff --git a/arch/arm/mach-ks8695/board-og.c b/arch/arm/mach-ks8695/board-og.c
> > index 1f4f2f4f25bb..fa1a7c2ca2bb 100644
> > --- a/arch/arm/mach-ks8695/board-og.c
> > +++ b/arch/arm/mach-ks8695/board-og.c
> > @@ -80,7 +80,7 @@ static void __init og_pci_bus_reset(void)
> > #define S8250_VIRT 0xf4000000
> > #define S8250_SIZE 0x00100000
> >
> > -static struct __initdata map_desc og_io_desc[] = {
> > +static struct map_desc __initdata og_io_desc[] = {
>
> I would have expected that
>
> +static struct map_desc og_io_desc[] __initdata = {
>
> is the correct variant?
>
I think those two mean the exact same thing, and we have tons of examples
for either one in the kernel, unlike the one I removed. I have
verified that the resulting object files are identical.
Can you point me to some documentation that clarifies which one to use,
and why?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: ks8695: fix __initdata annotation
Date: Tue, 09 Feb 2016 12:14:15 +0100 [thread overview]
Message-ID: <18237653.x9qPaNvtCU@wuerfel> (raw)
In-Reply-To: <20160209090030.GS13664@pengutronix.de>
On Tuesday 09 February 2016 10:00:30 Uwe Kleine-K?nig wrote:
> > diff --git a/arch/arm/mach-ks8695/board-og.c b/arch/arm/mach-ks8695/board-og.c
> > index 1f4f2f4f25bb..fa1a7c2ca2bb 100644
> > --- a/arch/arm/mach-ks8695/board-og.c
> > +++ b/arch/arm/mach-ks8695/board-og.c
> > @@ -80,7 +80,7 @@ static void __init og_pci_bus_reset(void)
> > #define S8250_VIRT 0xf4000000
> > #define S8250_SIZE 0x00100000
> >
> > -static struct __initdata map_desc og_io_desc[] = {
> > +static struct map_desc __initdata og_io_desc[] = {
>
> I would have expected that
>
> +static struct map_desc og_io_desc[] __initdata = {
>
> is the correct variant?
>
I think those two mean the exact same thing, and we have tons of examples
for either one in the kernel, unlike the one I removed. I have
verified that the resulting object files are identical.
Can you point me to some documentation that clarifies which one to use,
and why?
Arnd
next prev parent reply other threads:[~2016-02-09 11:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 14:24 [PATCH] ARM: ks8695: fix __initdata annotation Arnd Bergmann
2016-02-08 14:24 ` Arnd Bergmann
2016-02-08 23:36 ` Greg Ungerer
2016-02-08 23:36 ` Greg Ungerer
2016-02-26 16:25 ` Arnd Bergmann
2016-02-26 16:25 ` Arnd Bergmann
2016-02-09 9:00 ` Uwe Kleine-König
2016-02-09 9:00 ` Uwe Kleine-König
2016-02-09 11:14 ` Arnd Bergmann [this message]
2016-02-09 11:14 ` Arnd Bergmann
2016-02-09 11:36 ` Uwe Kleine-König
2016-02-09 11:36 ` Uwe Kleine-König
2016-02-09 15:10 ` Arnd Bergmann
2016-02-09 15:10 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18237653.x9qPaNvtCU@wuerfel \
--to=arnd@arndb.de \
--cc=gerg@uclinux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.