From: Siddh Raman Pant <code@siddh.me>
To: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
Cc: "Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"dri-devel" <dri-devel@lists.freedesktop.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
"Suraj Upadhyay" <usuraj35@gmail.com>
Subject: Re: [PATCH v9 8/8] drm: Remove usage of deprecated DRM_DEBUG_KMS
Date: Tue, 06 Jun 2023 22:47:32 +0530 [thread overview]
Message-ID: <18891b6bf3c.4ebd5fab126863.7291537060970485946@siddh.me> (raw)
In-Reply-To: <20230606150419.GI5197@pendragon.ideasonboard.com>
On Tue, 06 Jun 2023 20:34:19 +0530, Laurent Pinchart wrote:
> Hi Siddh,
>
> Thank you for the patch.
Anytime :)
> > - DRM_DEBUG_KMS("\n");
> > + drm_dbg_kms(dev, "\n");
>
> This message is pretty useless, it could be dropped on top of this
> series.
Okay.
> > - DRM_DEBUG_KMS("\n");
> > + drm_dbg_kms(NULL, "\n");
>
> Same.
Okay.
> > - DRM_DEBUG_KMS("\n");
> > + drm_dbg_kms(&dbidev->drm, "\n");
>
> Same.
Okay.
> With the commit subject fixed,
>
> Reviewed-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com>
Thanks,
Siddh
WARNING: multiple messages have this Message-ID (diff)
From: Siddh Raman Pant <code@siddh.me>
To: "Laurent Pinchart" <laurent.pinchart@ideasonboard.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Jonas Karlman <jonas@kwiboo.se>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Suraj Upadhyay <usuraj35@gmail.com>
Subject: Re: [PATCH v9 8/8] drm: Remove usage of deprecated DRM_DEBUG_KMS
Date: Tue, 06 Jun 2023 22:47:32 +0530 [thread overview]
Message-ID: <18891b6bf3c.4ebd5fab126863.7291537060970485946@siddh.me> (raw)
In-Reply-To: <20230606150419.GI5197@pendragon.ideasonboard.com>
On Tue, 06 Jun 2023 20:34:19 +0530, Laurent Pinchart wrote:
> Hi Siddh,
>
> Thank you for the patch.
Anytime :)
> > - DRM_DEBUG_KMS("\n");
> > + drm_dbg_kms(dev, "\n");
>
> This message is pretty useless, it could be dropped on top of this
> series.
Okay.
> > - DRM_DEBUG_KMS("\n");
> > + drm_dbg_kms(NULL, "\n");
>
> Same.
Okay.
> > - DRM_DEBUG_KMS("\n");
> > + drm_dbg_kms(&dbidev->drm, "\n");
>
> Same.
Okay.
> With the commit subject fixed,
>
> Reviewed-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com>
Thanks,
Siddh
next prev parent reply other threads:[~2023-06-06 17:19 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 10:45 [PATCH v9 0/8] drm: Remove usage of deprecated DRM_* macros Siddh Raman Pant
2023-06-06 10:45 ` Siddh Raman Pant
2023-06-06 10:45 ` [PATCH v9 1/8] Revert "drm: mipi-dsi: Convert logging to drm_* functions." Siddh Raman Pant
2023-06-06 10:45 ` Siddh Raman Pant
2023-06-06 12:55 ` Laurent Pinchart
2023-06-06 12:55 ` Laurent Pinchart
2023-06-06 13:07 ` Jani Nikula
2023-06-06 13:07 ` Jani Nikula
2023-06-06 13:21 ` Siddh Raman Pant
2023-06-06 13:21 ` Siddh Raman Pant
2023-06-06 10:45 ` [PATCH v9 2/8] drm/print: Fix and add support for NULL as first argument in drm_* macros Siddh Raman Pant
2023-06-06 10:45 ` Siddh Raman Pant
2023-06-06 14:05 ` Laurent Pinchart
2023-06-06 14:05 ` Laurent Pinchart
2023-06-06 14:34 ` Siddh Raman Pant
2023-06-06 14:34 ` Siddh Raman Pant
2023-06-06 14:47 ` Laurent Pinchart
2023-06-06 14:47 ` Laurent Pinchart
2023-06-06 10:45 ` [PATCH v9 3/8] drm: Remove usage of deprecated DRM_INFO Siddh Raman Pant
2023-06-06 10:45 ` Siddh Raman Pant
2023-06-06 14:23 ` Laurent Pinchart
2023-06-06 14:23 ` Laurent Pinchart
2023-06-06 14:38 ` Siddh Raman Pant
2023-06-06 14:38 ` Siddh Raman Pant
2023-06-06 14:46 ` Laurent Pinchart
2023-06-06 14:46 ` Laurent Pinchart
2023-06-06 16:39 ` Siddh Raman Pant
2023-06-06 16:39 ` Siddh Raman Pant
2023-06-06 10:45 ` [PATCH v9 4/8] drm: Remove usage of deprecated DRM_NOTE Siddh Raman Pant
2023-06-06 10:45 ` Siddh Raman Pant
2023-06-06 14:39 ` Laurent Pinchart
2023-06-06 14:39 ` Laurent Pinchart
2023-06-06 10:45 ` [PATCH v9 5/8] drm: Remove usage of deprecated DRM_ERROR Siddh Raman Pant
2023-06-06 10:45 ` Siddh Raman Pant
2023-06-06 14:44 ` Laurent Pinchart
2023-06-06 14:44 ` Laurent Pinchart
2023-06-06 17:06 ` Siddh Raman Pant
2023-06-06 17:06 ` Siddh Raman Pant
2023-06-06 17:13 ` Laurent Pinchart
2023-06-06 17:13 ` Laurent Pinchart
2023-06-06 10:45 ` [PATCH v9 6/8] drm: Remove usage of deprecated DRM_DEBUG Siddh Raman Pant
2023-06-06 10:45 ` Siddh Raman Pant
2023-06-06 14:57 ` Laurent Pinchart
2023-06-06 14:57 ` Laurent Pinchart
2023-06-06 17:14 ` Siddh Raman Pant
2023-06-06 17:14 ` Siddh Raman Pant
2023-06-06 10:45 ` [PATCH v9 7/8] drm: Remove usage of deprecated DRM_DEBUG_DRIVER Siddh Raman Pant
2023-06-06 10:45 ` Siddh Raman Pant
2023-06-06 14:38 ` Laurent Pinchart
2023-06-06 14:38 ` Laurent Pinchart
2023-06-06 10:45 ` [PATCH v9 8/8] drm: Remove usage of deprecated DRM_DEBUG_KMS Siddh Raman Pant
2023-06-06 10:45 ` Siddh Raman Pant
2023-06-06 15:04 ` Laurent Pinchart
2023-06-06 15:04 ` Laurent Pinchart
2023-06-06 17:17 ` Siddh Raman Pant [this message]
2023-06-06 17:17 ` Siddh Raman Pant
2023-06-06 21:39 ` Jani Nikula
2023-06-06 21:39 ` Jani Nikula
2023-06-07 3:53 ` Laurent Pinchart
2023-06-07 3:53 ` Laurent Pinchart
2023-06-07 8:12 ` Jani Nikula
2023-06-07 8:12 ` Jani Nikula
2023-06-06 11:30 ` [PATCH v9 0/8] drm: Remove usage of deprecated DRM_* macros Jani Nikula
2023-06-06 11:30 ` Jani Nikula
2023-06-06 15:05 ` Laurent Pinchart
2023-06-06 15:05 ` Laurent Pinchart
2023-06-06 17:29 ` Siddh Raman Pant
2023-06-06 17:29 ` Siddh Raman Pant
2023-06-06 17:49 ` Laurent Pinchart
2023-06-06 17:49 ` Laurent Pinchart
2023-06-06 18:17 ` Siddh Raman Pant
2023-06-06 18:17 ` Siddh Raman Pant
2023-06-07 4:30 ` Laurent Pinchart
2023-06-07 4:30 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18891b6bf3c.4ebd5fab126863.7291537060970485946@siddh.me \
--to=code@siddh.me \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=tzimmermann@suse.de \
--cc=usuraj35@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.