Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call

From: Archit Taneja <architt@codeaurora.org>
To: Inki Dae <inki.dae@samsung.com>, dri-devel@lists.freedesktop.org
Cc: daniel.vetter@intel.com
Subject: Re: [PATCH 12/14] drm/exynos: mic: clean up drm_bridge_add call
Date: Wed, 5 Jul 2017 14:30:54 +0530	[thread overview]
Message-ID: <18eb843c-19b2-a5d5-cbc3-d620d51f355e@codeaurora.org> (raw)
In-Reply-To: <1499071350-25168-13-git-send-email-inki.dae@samsung.com>

On 07/03/2017 02:12 PM, Inki Dae wrote:
> This patch removes unnecessary checking of return value.
> 
> Ps. this patch depends on below one,
> 	http://www.spinics.net/lists/dri-devel/msg145687.html

Will this one^ go via the exynos pull req or drm-misc? If there won't
be any conflicts, we could get both the patches through drm-misc to
keep things simple.

Archit

> 
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>   drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index 5ea6e3d..07bd7fc 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>   	mic->bridge.funcs = &mic_bridge_funcs;
>   	mic->bridge.of_node = dev->of_node;
>   
> -	ret = drm_bridge_add(&mic->bridge);
> -	if (ret) {
> -		DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
> -		return ret;
> -	}
> +	drm_bridge_add(&mic->bridge);
>   
>   	pm_runtime_enable(dev);
>   
> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel