From: Bryan O'Donoghue <pure.logic@nexus-software.ie>
To: Baruch Siach <baruch@tkos.co.il>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Sricharan R <sricharan@codeaurora.org>
Subject: Re: [PATCH] arm64: dts: qcom: ipq6018: Fix gpio-ranges property
Date: Sun, 12 Dec 2021 15:44:34 +0000 [thread overview]
Message-ID: <18f25dbf-3a8b-cda3-afad-abf7a7f42d8e@nexus-software.ie> (raw)
In-Reply-To: <8a744cfd96aff5754bfdcf7298d208ddca5b319a.1638862030.git.baruch@tkos.co.il>
On 07/12/2021 07:27, Baruch Siach wrote:
> There must be three parameters in gpio-ranges property. Fixes this not
> very helpful error message:
>
> OF: /soc/pinctrl@1000000: (null) = 3 found 3
>
> Fixes: 1e8277854b49 ("arm64: dts: Add ipq6018 SoC and CP01 board support")
> Cc: Sricharan R <sricharan@codeaurora.org>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>
> The error message was improved in commit af3be70a321 ("of: Improve
> of_phandle_iterator_next() error message"), but there is evidently some
> more room for improvement. As I don't really understand the code, I
> added the commit author and the DT list to Cc.
> ---
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 6a22bb5f42f4..a717fc17523d 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -220,7 +220,7 @@ tlmm: pinctrl@1000000 {
> interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> gpio-controller;
> #gpio-cells = <2>;
> - gpio-ranges = <&tlmm 0 80>;
> + gpio-ranges = <&tlmm 0 0 80>;
> interrupt-controller;
> #interrupt-cells = <2>;
>
>
Works for me
Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: Bryan O'Donoghue <pure.logic@nexus-software.ie>
To: Baruch Siach <baruch@tkos.co.il>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Sricharan R <sricharan@codeaurora.org>
Subject: Re: [PATCH] arm64: dts: qcom: ipq6018: Fix gpio-ranges property
Date: Sun, 12 Dec 2021 15:44:34 +0000 [thread overview]
Message-ID: <18f25dbf-3a8b-cda3-afad-abf7a7f42d8e@nexus-software.ie> (raw)
In-Reply-To: <8a744cfd96aff5754bfdcf7298d208ddca5b319a.1638862030.git.baruch@tkos.co.il>
On 07/12/2021 07:27, Baruch Siach wrote:
> There must be three parameters in gpio-ranges property. Fixes this not
> very helpful error message:
>
> OF: /soc/pinctrl@1000000: (null) = 3 found 3
>
> Fixes: 1e8277854b49 ("arm64: dts: Add ipq6018 SoC and CP01 board support")
> Cc: Sricharan R <sricharan@codeaurora.org>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>
> The error message was improved in commit af3be70a321 ("of: Improve
> of_phandle_iterator_next() error message"), but there is evidently some
> more room for improvement. As I don't really understand the code, I
> added the commit author and the DT list to Cc.
> ---
> arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 6a22bb5f42f4..a717fc17523d 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -220,7 +220,7 @@ tlmm: pinctrl@1000000 {
> interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
> gpio-controller;
> #gpio-cells = <2>;
> - gpio-ranges = <&tlmm 0 80>;
> + gpio-ranges = <&tlmm 0 0 80>;
> interrupt-controller;
> #interrupt-cells = <2>;
>
>
Works for me
Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-12 15:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 7:27 [PATCH] arm64: dts: qcom: ipq6018: Fix gpio-ranges property Baruch Siach
2021-12-07 7:27 ` Baruch Siach
2021-12-12 15:44 ` Bryan O'Donoghue [this message]
2021-12-12 15:44 ` Bryan O'Donoghue
2021-12-12 15:45 ` Bryan O'Donoghue
2021-12-12 15:45 ` Bryan O'Donoghue
2021-12-15 22:27 ` Bjorn Andersson
2021-12-15 22:27 ` Bjorn Andersson
2021-12-15 22:44 ` Florian Fainelli
2021-12-15 22:44 ` Florian Fainelli
2021-12-16 12:11 ` Baruch Siach
2021-12-16 12:11 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18f25dbf-3a8b-cda3-afad-abf7a7f42d8e@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=agross@kernel.org \
--cc=baruch@tkos.co.il \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.