From: Pankaj Gupta <pagupta@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linux-mm@kvack.org, linux-nvdimm@lists.01.org,
akpm@linux-foundation.org, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH 2/2] mm/memmap_init: Update variable name in memmap_init_zone
Date: Thu, 26 Sep 2019 09:38:23 -0400 (EDT) [thread overview]
Message-ID: <193523014.3320073.1569505103872.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190926122552.17905-2-aneesh.kumar@linux.ibm.com>
>
> The third argument is actually number of pages. Changes the variable name
> from size to nr_pages to indicate this better.
>
> No functional change in this patch.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> ---
> mm/page_alloc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 3334a769eb91..df9e09a5359f 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5914,10 +5914,10 @@ void __meminit memmap_init_zone(unsigned long size,
> int nid, unsigned long zone,
> #ifdef CONFIG_ZONE_DEVICE
> void __ref memmap_init_zone_device(struct zone *zone,
> unsigned long start_pfn,
> - unsigned long size,
> + unsigned long nr_pages,
> struct dev_pagemap *pgmap)
> {
> - unsigned long pfn, end_pfn = start_pfn + size;
> + unsigned long pfn, end_pfn = start_pfn + nr_pages;
> struct pglist_data *pgdat = zone->zone_pgdat;
> struct vmem_altmap *altmap = pgmap_altmap(pgmap);
> unsigned long zone_idx = zone_idx(zone);
> @@ -5934,7 +5934,7 @@ void __ref memmap_init_zone_device(struct zone *zone,
> */
> if (altmap) {
> start_pfn = altmap->base_pfn + vmem_altmap_offset(altmap);
> - size = end_pfn - start_pfn;
> + nr_pages = end_pfn - start_pfn;
> }
>
> for (pfn = start_pfn; pfn < end_pfn; pfn++) {
> @@ -5981,7 +5981,7 @@ void __ref memmap_init_zone_device(struct zone *zone,
> }
>
> pr_info("%s initialised %lu pages in %ums\n", __func__,
> - size, jiffies_to_msecs(jiffies - start));
> + nr_pages, jiffies_to_msecs(jiffies - start));
> }
>
> #endif
> --
> 2.21.0
Reviewed-by: Pankaj Gupta <pagupta@redhat.com>
>
>
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Gupta <pagupta@redhat.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: dan j williams <dan.j.williams@intel.com>,
akpm@linux-foundation.org, David Hildenbrand <david@redhat.com>,
linux-nvdimm@lists.01.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mm/memmap_init: Update variable name in memmap_init_zone
Date: Thu, 26 Sep 2019 09:38:23 -0400 (EDT) [thread overview]
Message-ID: <193523014.3320073.1569505103872.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190926122552.17905-2-aneesh.kumar@linux.ibm.com>
>
> The third argument is actually number of pages. Changes the variable name
> from size to nr_pages to indicate this better.
>
> No functional change in this patch.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
> ---
> mm/page_alloc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 3334a769eb91..df9e09a5359f 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5914,10 +5914,10 @@ void __meminit memmap_init_zone(unsigned long size,
> int nid, unsigned long zone,
> #ifdef CONFIG_ZONE_DEVICE
> void __ref memmap_init_zone_device(struct zone *zone,
> unsigned long start_pfn,
> - unsigned long size,
> + unsigned long nr_pages,
> struct dev_pagemap *pgmap)
> {
> - unsigned long pfn, end_pfn = start_pfn + size;
> + unsigned long pfn, end_pfn = start_pfn + nr_pages;
> struct pglist_data *pgdat = zone->zone_pgdat;
> struct vmem_altmap *altmap = pgmap_altmap(pgmap);
> unsigned long zone_idx = zone_idx(zone);
> @@ -5934,7 +5934,7 @@ void __ref memmap_init_zone_device(struct zone *zone,
> */
> if (altmap) {
> start_pfn = altmap->base_pfn + vmem_altmap_offset(altmap);
> - size = end_pfn - start_pfn;
> + nr_pages = end_pfn - start_pfn;
> }
>
> for (pfn = start_pfn; pfn < end_pfn; pfn++) {
> @@ -5981,7 +5981,7 @@ void __ref memmap_init_zone_device(struct zone *zone,
> }
>
> pr_info("%s initialised %lu pages in %ums\n", __func__,
> - size, jiffies_to_msecs(jiffies - start));
> + nr_pages, jiffies_to_msecs(jiffies - start));
> }
>
> #endif
> --
> 2.21.0
Reviewed-by: Pankaj Gupta <pagupta@redhat.com>
>
>
>
next prev parent reply other threads:[~2019-09-26 13:38 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 9:14 [PATCH v4 0/8] mm/memory_hotplug: Shrink zones before removing memory David Hildenbrand
2019-08-30 9:14 ` [PATCH v4 1/8] mm/memory_hotplug: Don't access uninitialized memmaps in shrink_pgdat_span() David Hildenbrand
2019-08-30 9:14 ` [PATCH v4 2/8] mm/memory_hotplug: Don't access uninitialized memmaps in shrink_zone_span() David Hildenbrand
2019-09-26 9:12 ` Aneesh Kumar K.V
2019-09-26 9:22 ` David Hildenbrand
2019-08-30 9:14 ` [PATCH v4 3/8] mm/memory_hotplug: Shrink zones when offlining memory David Hildenbrand
2019-08-30 9:14 ` David Hildenbrand
2019-08-30 9:14 ` [PATCH v4 4/8] mm/memory_hotplug: Poison memmap in remove_pfn_range_from_zone() David Hildenbrand
2019-09-26 9:10 ` Aneesh Kumar K.V
2019-09-26 9:14 ` David Hildenbrand
2019-08-30 9:14 ` [PATCH v4 5/8] mm/memory_hotplug: We always have a zone in find_(smallest|biggest)_section_pfn David Hildenbrand
2019-08-30 9:14 ` [PATCH v4 6/8] mm/memory_hotplug: Don't check for "all holes" in shrink_zone_span() David Hildenbrand
2019-08-30 9:14 ` [PATCH v4 7/8] mm/memory_hotplug: Drop local variables " David Hildenbrand
2019-08-30 9:14 ` [PATCH v4 8/8] mm/memory_hotplug: Cleanup __remove_pages() David Hildenbrand
2019-09-06 9:21 ` [PATCH v4 0/8] mm/memory_hotplug: Shrink zones before removing memory David Hildenbrand
2019-09-19 13:58 ` David Hildenbrand
2019-09-19 19:16 ` Andrew Morton
2019-09-20 8:16 ` David Hildenbrand
2019-09-26 12:25 ` [PATCH 1/2] mm/memunmap: Use the correct start and end pfn when removing pages from zone Aneesh Kumar K.V
2019-09-26 12:25 ` Aneesh Kumar K.V
2019-09-26 12:25 ` [PATCH 2/2] mm/memmap_init: Update variable name in memmap_init_zone Aneesh Kumar K.V
2019-09-26 12:25 ` Aneesh Kumar K.V
2019-09-26 12:56 ` David Hildenbrand
2019-09-26 12:56 ` David Hildenbrand
2019-09-26 13:38 ` Pankaj Gupta [this message]
2019-09-26 13:38 ` Pankaj Gupta
2019-09-26 12:43 ` [PATCH 1/2] mm/memunmap: Use the correct start and end pfn when removing pages from zone David Hildenbrand
2019-09-26 12:43 ` David Hildenbrand
2019-09-26 13:15 ` Aneesh Kumar K.V
2019-09-26 13:15 ` Aneesh Kumar K.V
2019-09-26 13:34 ` Pankaj Gupta
2019-09-26 13:34 ` Pankaj Gupta
2019-09-26 22:45 ` Andrew Morton
2019-09-26 22:45 ` Andrew Morton
2019-09-27 1:51 ` Aneesh Kumar K.V
2019-09-27 1:51 ` Aneesh Kumar K.V
2019-09-27 7:46 ` David Hildenbrand
2019-09-27 7:46 ` David Hildenbrand
2019-09-27 10:32 ` [PATCH] " Aneesh Kumar K.V
2019-09-27 10:32 ` Aneesh Kumar K.V
2019-09-27 10:38 ` David Hildenbrand
2019-09-27 10:38 ` David Hildenbrand
2019-09-27 10:36 ` [PATCH 1/2] " Aneesh Kumar K.V
2019-09-27 10:36 ` Aneesh Kumar K.V
2019-09-27 10:40 ` David Hildenbrand
2019-09-27 10:40 ` David Hildenbrand
2019-09-27 11:35 ` Aneesh Kumar K.V
2019-09-27 11:35 ` Aneesh Kumar K.V
2019-09-27 11:38 ` David Hildenbrand
2019-09-27 11:38 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=193523014.3320073.1569505103872.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.