From: Heiko Stuebner <heiko@sntech.de>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Alan Douglas <adouglas@cadence.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Jingoo Han <jingoohan1@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@free-electrons.com>,
Jia-Ju Bai <baijiaju1990@gmail.com>,
linux-omap@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/15] PCI: endpoint: Cleanup EPC features
Date: Mon, 07 Jan 2019 15:35:54 +0100 [thread overview]
Message-ID: <1936135.agpnLP3rXd@phil> (raw)
In-Reply-To: <20190107064148.10152-1-kishon@ti.com>
Am Montag, 7. Januar 2019, 07:41:33 CET schrieb Kishon Vijay Abraham I:
> Hi Lorenzo,
>
> The Endpoint controller driver uses features member in 'struct pci_epc'
> to advertise the list of supported features to the endpoint function
> driver.
>
> There are a few shortcomings with this approach.
> *) Certain endpoint controllers support fixed size BAR (e.g. TI's
> AM654 uses Designware configuration with fixed size BAR). The
> size of each BARs cannot be passed to the endpoint function
> driver.
> *) Too many macros for handling EPC features.
> (EPC_FEATURE_NO_LINKUP_NOTIFIER, EPC_FEATURE_BAR_MASK,
> EPC_FEATURE_MSIX_AVAILABLE, EPC_FEATURE_SET_BAR,
> EPC_FEATURE_GET_BAR)
> *) Endpoint controllers are directly modifying struct pci_epc
> members. (I have plans to move struct pci_epc to
> drivers/pci/endpoint so that pci_epc members are referenced
> only by endpoint core).
>
> To overcome the above shortcomings, introduced pci_epc_get_features()
> API, pci_epc_features structure and a ->get_features() callback.
>
> Also added a patch to set BAR flags in pci_epf_alloc_space and
> remove it from pci-epf-test function driver.
>
> Tested on TI's DRA7xx platform.
While I don't have that much PCI experience and hence cannot judge
this cleanup as a whole, I can at least say, that my Rockchip rk3399
still does find its PCIE-connected wifi card, so this series on rk3399
Tested-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Alan Douglas <adouglas@cadence.com>,
Jia-Ju Bai <baijiaju1990@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@free-electrons.com>,
Jingoo Han <jingoohan1@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/15] PCI: endpoint: Cleanup EPC features
Date: Mon, 07 Jan 2019 15:35:54 +0100 [thread overview]
Message-ID: <1936135.agpnLP3rXd@phil> (raw)
In-Reply-To: <20190107064148.10152-1-kishon@ti.com>
Am Montag, 7. Januar 2019, 07:41:33 CET schrieb Kishon Vijay Abraham I:
> Hi Lorenzo,
>
> The Endpoint controller driver uses features member in 'struct pci_epc'
> to advertise the list of supported features to the endpoint function
> driver.
>
> There are a few shortcomings with this approach.
> *) Certain endpoint controllers support fixed size BAR (e.g. TI's
> AM654 uses Designware configuration with fixed size BAR). The
> size of each BARs cannot be passed to the endpoint function
> driver.
> *) Too many macros for handling EPC features.
> (EPC_FEATURE_NO_LINKUP_NOTIFIER, EPC_FEATURE_BAR_MASK,
> EPC_FEATURE_MSIX_AVAILABLE, EPC_FEATURE_SET_BAR,
> EPC_FEATURE_GET_BAR)
> *) Endpoint controllers are directly modifying struct pci_epc
> members. (I have plans to move struct pci_epc to
> drivers/pci/endpoint so that pci_epc members are referenced
> only by endpoint core).
>
> To overcome the above shortcomings, introduced pci_epc_get_features()
> API, pci_epc_features structure and a ->get_features() callback.
>
> Also added a patch to set BAR flags in pci_epf_alloc_space and
> remove it from pci-epf-test function driver.
>
> Tested on TI's DRA7xx platform.
While I don't have that much PCI experience and hence cannot judge
this cleanup as a whole, I can at least say, that my Rockchip rk3399
still does find its PCIE-connected wifi card, so this series on rk3399
Tested-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-07 14:36 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 6:41 [PATCH 00/15] PCI: endpoint: Cleanup EPC features Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 01/15] PCI: endpoint: Add new pci_epc_ops to get " Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 02/15] PCI: dwc: Add ->get_features() callback function in dw_pcie_ep_ops Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 03/15] PCI: designware-plat: Populate ->get_features() dw_pcie_ep_ops Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 04/15] PCI: pci-dra7xx: " Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 05/15] PCI: rockchip: " Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 06/15] PCI: cadence: Populate ->get_features() cdns_pcie_epc_ops Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 07/15] PCI: endpoint: Add helper to get first unreserved BAR Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 08/15] PCI: endpoint: Fix pci_epf_alloc_space to set correct MEM TYPE flags Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 09/15] PCI: pci-epf-test: Remove setting epf_bar flags in function driver Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 10/15] PCI: pci-epf-test: Do not allocate next BARs memory if current BAR is 64Bit Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 11/15] PCI: pci-epf-test: Use pci_epc_get_features to get EPC features Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-02-12 15:07 ` Lorenzo Pieralisi
2019-02-12 15:07 ` Lorenzo Pieralisi
2019-02-13 13:38 ` Kishon Vijay Abraham I
2019-02-13 13:38 ` Kishon Vijay Abraham I
2019-02-13 13:38 ` Kishon Vijay Abraham I
2019-02-13 13:44 ` Kishon Vijay Abraham I
2019-02-13 13:44 ` Kishon Vijay Abraham I
2019-02-13 13:44 ` Kishon Vijay Abraham I
2019-02-13 14:36 ` Lorenzo Pieralisi
2019-02-13 14:36 ` Lorenzo Pieralisi
2019-02-14 5:06 ` Kishon Vijay Abraham I
2019-02-14 5:06 ` Kishon Vijay Abraham I
2019-02-14 5:06 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 12/15] PCI: cadence: Remove pci_epf_linkup from Cadence EP driver Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 13/15] PCI: rockchip: Remove pci_epf_linkup from Rockchip " Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 14/15] PCI: designware-plat: Remove setting epc->features in Designware plat " Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` [PATCH 15/15] PCI: endpoint: Remove features member in struct pci_epc Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 6:41 ` Kishon Vijay Abraham I
2019-01-07 14:35 ` Heiko Stuebner [this message]
2019-01-07 14:35 ` [PATCH 00/15] PCI: endpoint: Cleanup EPC features Heiko Stuebner
2019-01-10 5:05 ` Kishon Vijay Abraham I
2019-01-10 5:05 ` Kishon Vijay Abraham I
2019-01-10 5:05 ` Kishon Vijay Abraham I
2019-01-10 12:10 ` Heiko Stuebner
2019-01-10 12:10 ` Heiko Stuebner
2019-01-24 14:52 ` Lorenzo Pieralisi
2019-01-24 14:52 ` Lorenzo Pieralisi
2019-01-28 5:01 ` Kishon Vijay Abraham I
2019-01-28 5:01 ` Kishon Vijay Abraham I
2019-01-28 5:01 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1936135.agpnLP3rXd@phil \
--to=heiko@sntech.de \
--cc=adouglas@cadence.com \
--cc=baijiaju1990@gmail.com \
--cc=bhelgaas@google.com \
--cc=cyrille.pitchen@free-electrons.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.