From: Alexander Graf <agraf@suse.de>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"kvm@vger.kernel.org list" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org List" <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [PATCH] kvm: ppc: Fix breakage of kvm_arch_pre_run/process_irqchip_events
Date: Fri, 11 Mar 2011 06:55:25 +0100 [thread overview]
Message-ID: <1F65CCB9-1E2A-4210-8D05-3FFB4B9B0A61@suse.de> (raw)
In-Reply-To: <4D5D8C92.1080901@web.de>
On 17.02.2011, at 22:01, Jan Kiszka wrote:
> On 2011-02-07 12:19, Jan Kiszka wrote:
>> We do not check them, and the only arch with non-empty implementations
>> always returns 0 (this is also true for qemu-kvm).
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> CC: Alexander Graf <agraf@suse.de>
>> ---
>> kvm.h | 5 ++---
>> target-i386/kvm.c | 8 ++------
>> target-ppc/kvm.c | 6 ++----
>> target-s390x/kvm.c | 6 ++----
>> 4 files changed, 8 insertions(+), 17 deletions(-)
>>
>
> ...
>
>> diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
>> index 93ecc57..bd4012a 100644
>> --- a/target-ppc/kvm.c
>> +++ b/target-ppc/kvm.c
>> @@ -256,14 +256,12 @@ int kvm_arch_pre_run(CPUState *env, struct kvm_run *run)
>> return 0;
>> }
>>
>> -int kvm_arch_post_run(CPUState *env, struct kvm_run *run)
>> +void kvm_arch_post_run(CPUState *env, struct kvm_run *run)
>> {
>> - return 0;
>> }
>>
>> -int kvm_arch_process_irqchip_events(CPUState *env)
>> +void kvm_arch_process_irqchip_events(CPUState *env)
>> {
>> - return 0;
>> }
>
> Oops. Do we already have a built-bot for KVM-enabled PPC (and s390)
> targets somewhere?
Just before leaving for vacation I prepared a machine for each and gave stefan access to them. Looks like they're not officially running though - will try to look at this asap.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Avi Kivity <avi@redhat.com>,
"kvm@vger.kernel.org list" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org List" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] kvm: ppc: Fix breakage of kvm_arch_pre_run/process_irqchip_events
Date: Fri, 11 Mar 2011 06:55:25 +0100 [thread overview]
Message-ID: <1F65CCB9-1E2A-4210-8D05-3FFB4B9B0A61@suse.de> (raw)
In-Reply-To: <4D5D8C92.1080901@web.de>
On 17.02.2011, at 22:01, Jan Kiszka wrote:
> On 2011-02-07 12:19, Jan Kiszka wrote:
>> We do not check them, and the only arch with non-empty implementations
>> always returns 0 (this is also true for qemu-kvm).
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> CC: Alexander Graf <agraf@suse.de>
>> ---
>> kvm.h | 5 ++---
>> target-i386/kvm.c | 8 ++------
>> target-ppc/kvm.c | 6 ++----
>> target-s390x/kvm.c | 6 ++----
>> 4 files changed, 8 insertions(+), 17 deletions(-)
>>
>
> ...
>
>> diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
>> index 93ecc57..bd4012a 100644
>> --- a/target-ppc/kvm.c
>> +++ b/target-ppc/kvm.c
>> @@ -256,14 +256,12 @@ int kvm_arch_pre_run(CPUState *env, struct kvm_run *run)
>> return 0;
>> }
>>
>> -int kvm_arch_post_run(CPUState *env, struct kvm_run *run)
>> +void kvm_arch_post_run(CPUState *env, struct kvm_run *run)
>> {
>> - return 0;
>> }
>>
>> -int kvm_arch_process_irqchip_events(CPUState *env)
>> +void kvm_arch_process_irqchip_events(CPUState *env)
>> {
>> - return 0;
>> }
>
> Oops. Do we already have a built-bot for KVM-enabled PPC (and s390)
> targets somewhere?
Just before leaving for vacation I prepared a machine for each and gave stefan access to them. Looks like they're not officially running though - will try to look at this asap.
Alex
next prev parent reply other threads:[~2011-03-11 5:55 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 11:19 [PATCH 00/15] [uq/master] Patch queue, part III Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 01/15] Refactor kvm&tcg function names in cpus.c Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work " Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-08 18:50 ` Marcelo Tosatti
2011-02-08 18:50 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 8:07 ` Jan Kiszka
2011-02-09 8:07 ` [Qemu-devel] " Jan Kiszka
2011-02-09 13:54 ` Marcelo Tosatti
2011-02-09 13:54 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 15:29 ` [PATCH v2 " Jan Kiszka
2011-02-09 15:29 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 03/15] Fix a few coding style violations " Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 04/15] Improve vm_stop reason declarations Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-08 18:59 ` Marcelo Tosatti
2011-02-08 18:59 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 8:07 ` Jan Kiszka
2011-02-09 8:07 ` [Qemu-devel] " Jan Kiszka
2011-02-09 14:17 ` Marcelo Tosatti
2011-02-09 14:17 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 14:51 ` Jan Kiszka
2011-02-09 14:51 ` [Qemu-devel] " Jan Kiszka
2011-02-09 15:29 ` [PATCH v2 " Jan Kiszka
2011-02-09 15:29 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 05/15] Refactor debug and vmstop request interface Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 06/15] Move debug exception handling out of cpu_exec Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 07/15] kvm: Separate TCG from KVM cpu execution Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-08 23:39 ` Marcelo Tosatti
2011-02-08 23:39 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 7:59 ` Jan Kiszka
2011-02-09 7:59 ` [Qemu-devel] " Jan Kiszka
2011-02-09 14:44 ` Marcelo Tosatti
2011-02-09 14:44 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 14:53 ` Jan Kiszka
2011-02-09 14:53 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 08/15] kvm: x86: Prepare VCPU loop for in-kernel irqchip Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 09/15] kvm: Drop return values from kvm_arch_pre/post_run Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 12:54 ` Alexander Graf
2011-02-07 12:54 ` [Qemu-devel] " Alexander Graf
2011-02-17 21:01 ` [PATCH] kvm: ppc: Fix breakage of kvm_arch_pre_run/process_irqchip_events Jan Kiszka
2011-02-17 21:01 ` [Qemu-devel] " Jan Kiszka
2011-03-11 5:55 ` Alexander Graf [this message]
2011-03-11 5:55 ` [Qemu-devel] " Alexander Graf
2011-03-11 6:26 ` Stefan Hajnoczi
2011-03-11 6:26 ` [Qemu-devel] " Stefan Hajnoczi
2011-03-11 7:02 ` Alexander Graf
2011-03-11 7:02 ` [Qemu-devel] " Alexander Graf
2011-02-07 11:19 ` [PATCH 10/15] kvm: x86: Catch and report failing IRQ and NMI injections Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 11/15] kvm: Remove unneeded memory slot reservation Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 15:26 ` Alex Williamson
2011-02-07 15:26 ` [Qemu-devel] " Alex Williamson
2011-02-07 11:19 ` [PATCH 12/15] Introduce log_start/log_stop in CPUPhysMemoryClient Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 13/15] cirrus: Remove obsolete kvm.h include Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 14/15] kvm: Make kvm_state globally available Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 12:27 ` Glauber Costa
2011-02-07 12:27 ` [Qemu-devel] " Glauber Costa
2011-02-07 12:36 ` Jan Kiszka
2011-02-07 12:36 ` [Qemu-devel] " Jan Kiszka
2011-02-07 13:40 ` Glauber Costa
2011-02-07 13:40 ` [Qemu-devel] " Glauber Costa
2011-02-07 14:03 ` Jan Kiszka
2011-02-07 14:03 ` [Qemu-devel] " Jan Kiszka
2011-02-07 18:04 ` Glauber Costa
2011-02-07 18:04 ` [Qemu-devel] " Glauber Costa
2011-02-07 18:12 ` Jan Kiszka
2011-02-07 18:12 ` [Qemu-devel] " Jan Kiszka
2011-02-07 18:26 ` Glauber Costa
2011-02-07 18:26 ` [Qemu-devel] " Glauber Costa
2011-02-07 12:44 ` Avi Kivity
2011-02-07 12:44 ` [Qemu-devel] " Avi Kivity
2011-02-07 19:39 ` [Qemu-devel] " Blue Swirl
2011-02-07 19:39 ` Blue Swirl
2011-02-07 21:48 ` Jan Kiszka
2011-02-07 21:48 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1F65CCB9-1E2A-4210-8D05-3FFB4B9B0A61@suse.de \
--to=agraf@suse.de \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.