From: Bert Vermeulen <bert@biot.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: devicetree@vger.kernel.org, John Crispin <john@phrozen.org>,
Russell King <linux@armlinux.org.uk>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Arnd Bergmann <arnd@arndb.de>,
Olivier Moysan <olivier.moysan@st.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
Lionel Debieve <lionel.debieve@st.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] ARM: multi_v7_defconfig: Add support for Airoha EN7523 SoC
Date: Tue, 7 Sep 2021 12:41:41 +0200 [thread overview]
Message-ID: <1a04688d-46fc-8885-feba-d2ffa532f2d9@biot.com> (raw)
In-Reply-To: <93abbefa-1ee6-7913-a41e-3e587e9a747a@gmail.com>
On 9/7/21 12:39 PM, Dmitry Osipenko wrote:
> 07.09.2021 13:27, Bert Vermeulen пишет:
>> From: John Crispin <john@phrozen.org>
>>
>> This enables basic bootup support for the Airoha EN7523 SoC.
>>
>> Signed-off-by: John Crispin <john@phrozen.org>
>> Signed-off-by: Bert Vermeulen <bert@biot.com>
>> ---
>> arch/arm/configs/multi_v7_defconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
>> index d9abaae118dd..a9370a95dc38 100644
>> --- a/arch/arm/configs/multi_v7_defconfig
>> +++ b/arch/arm/configs/multi_v7_defconfig
>> @@ -31,6 +31,7 @@ CONFIG_MACH_BERLIN_BG2=y
>> CONFIG_MACH_BERLIN_BG2CD=y
>> CONFIG_MACH_BERLIN_BG2Q=y
>> CONFIG_ARCH_DIGICOLOR=y
>> +CONFIG_ARCH_AIROHA=y
>> CONFIG_ARCH_EXYNOS=y
>> CONFIG_ARCH_HIGHBANK=y
>> CONFIG_ARCH_HISI=y
>> @@ -983,6 +984,7 @@ CONFIG_STAGING_BOARD=y
>> CONFIG_MFD_CROS_EC_DEV=m
>> CONFIG_CROS_EC_I2C=m
>> CONFIG_CROS_EC_SPI=m
>> +CONFIG_COMMON_CLK_EN7523=y
>
> If SoC doesn't work without clk support, then this option should be
> auto-selected by the arch option.
>
> It also doesn't look like upstream kernel has COMMON_CLK_EN7523 at all.
Oops, you're right -- the clock driver is coming as soon as the base system
is in. I guess this option (under ARCH_AIROHA) should come in at that time
as well? I'll respin after some more comments.
--
Bert Vermeulen
bert@biot.com
WARNING: multiple messages have this Message-ID (diff)
From: Bert Vermeulen <bert@biot.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: devicetree@vger.kernel.org, John Crispin <john@phrozen.org>,
Russell King <linux@armlinux.org.uk>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Arnd Bergmann <arnd@arndb.de>,
Olivier Moysan <olivier.moysan@st.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Fabrice Gasnier <fabrice.gasnier@st.com>,
Lionel Debieve <lionel.debieve@st.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] ARM: multi_v7_defconfig: Add support for Airoha EN7523 SoC
Date: Tue, 7 Sep 2021 12:41:41 +0200 [thread overview]
Message-ID: <1a04688d-46fc-8885-feba-d2ffa532f2d9@biot.com> (raw)
In-Reply-To: <93abbefa-1ee6-7913-a41e-3e587e9a747a@gmail.com>
On 9/7/21 12:39 PM, Dmitry Osipenko wrote:
> 07.09.2021 13:27, Bert Vermeulen пишет:
>> From: John Crispin <john@phrozen.org>
>>
>> This enables basic bootup support for the Airoha EN7523 SoC.
>>
>> Signed-off-by: John Crispin <john@phrozen.org>
>> Signed-off-by: Bert Vermeulen <bert@biot.com>
>> ---
>> arch/arm/configs/multi_v7_defconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
>> index d9abaae118dd..a9370a95dc38 100644
>> --- a/arch/arm/configs/multi_v7_defconfig
>> +++ b/arch/arm/configs/multi_v7_defconfig
>> @@ -31,6 +31,7 @@ CONFIG_MACH_BERLIN_BG2=y
>> CONFIG_MACH_BERLIN_BG2CD=y
>> CONFIG_MACH_BERLIN_BG2Q=y
>> CONFIG_ARCH_DIGICOLOR=y
>> +CONFIG_ARCH_AIROHA=y
>> CONFIG_ARCH_EXYNOS=y
>> CONFIG_ARCH_HIGHBANK=y
>> CONFIG_ARCH_HISI=y
>> @@ -983,6 +984,7 @@ CONFIG_STAGING_BOARD=y
>> CONFIG_MFD_CROS_EC_DEV=m
>> CONFIG_CROS_EC_I2C=m
>> CONFIG_CROS_EC_SPI=m
>> +CONFIG_COMMON_CLK_EN7523=y
>
> If SoC doesn't work without clk support, then this option should be
> auto-selected by the arch option.
>
> It also doesn't look like upstream kernel has COMMON_CLK_EN7523 at all.
Oops, you're right -- the clock driver is coming as soon as the base system
is in. I guess this option (under ARCH_AIROHA) should come in at that time
as well? I'll respin after some more comments.
--
Bert Vermeulen
bert@biot.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-07 10:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 10:27 [PATCH v2 0/5] Add support for Airoha EN7523 SoC Bert Vermeulen
2021-09-07 10:27 ` Bert Vermeulen
2021-09-07 10:27 ` [PATCH v2 1/5] dt-bindings: Add vendor prefix for Airoha Bert Vermeulen
2021-09-07 10:27 ` Bert Vermeulen
2021-09-07 11:13 ` Krzysztof Kozlowski
2021-09-07 11:13 ` Krzysztof Kozlowski
2021-09-07 10:27 ` [PATCH v2 2/5] dt-bindings: arm: airoha: Add binding for EN7523 SoC and EVB Bert Vermeulen
2021-09-07 10:27 ` Bert Vermeulen
2021-09-07 10:27 ` [PATCH v2 3/5] ARM: dts: Add basic support for Airoha EN7523 Bert Vermeulen
2021-09-07 10:27 ` Bert Vermeulen
2021-09-07 10:27 ` [PATCH v2 4/5] ARM: Add basic support for Airoha EN7523 SoC Bert Vermeulen
2021-09-07 10:27 ` Bert Vermeulen
2021-09-07 10:48 ` Daniel Palmer
2021-09-07 10:48 ` Daniel Palmer
2021-09-07 11:51 ` Arnd Bergmann
2021-09-07 11:51 ` Arnd Bergmann
2021-09-07 12:27 ` Daniel Palmer
2021-09-07 12:27 ` Daniel Palmer
2021-09-07 14:11 ` Arnd Bergmann
2021-09-07 14:11 ` Arnd Bergmann
2021-09-07 14:32 ` Daniel Palmer
2021-09-07 14:32 ` Daniel Palmer
2021-09-07 15:22 ` Arnd Bergmann
2021-09-07 15:22 ` Arnd Bergmann
2021-09-07 10:27 ` [PATCH v2 5/5] ARM: multi_v7_defconfig: Add " Bert Vermeulen
2021-09-07 10:27 ` Bert Vermeulen
2021-09-07 10:39 ` Dmitry Osipenko
2021-09-07 10:39 ` Dmitry Osipenko
2021-09-07 10:41 ` Bert Vermeulen [this message]
2021-09-07 10:41 ` Bert Vermeulen
2021-09-07 11:03 ` Dmitry Osipenko
2021-09-07 11:03 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a04688d-46fc-8885-feba-d2ffa532f2d9@biot.com \
--to=bert@biot.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=fabrice.gasnier@st.com \
--cc=grygorii.strashko@ti.com \
--cc=john@phrozen.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lionel.debieve@st.com \
--cc=m.szyprowski@samsung.com \
--cc=mani@kernel.org \
--cc=olivier.moysan@st.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.