From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Irina Tirdea <irina.tirdea@intel.com>
Cc: linux-clk@vger.kernel.org, "x86@kernel.org" <x86@kernel.org>,
platform-driver-x86@vger.kernel.org,
Stephen Boyd <sboyd@codeaurora.org>,
Darren Hart <dvhart@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks
Date: Mon, 12 Dec 2016 18:15:09 -0600 [thread overview]
Message-ID: <1a98dcda-a662-958e-307f-5fe3f281ed9f@linux.intel.com> (raw)
In-Reply-To: <CAHp75Vdaw4yvTPP2JZc+ti-AVNsisRQ+WG=JxPQ1jv-r7DADQA@mail.gmail.com>
> Thanks for an update I will comment all the patches.
> Here we start.
Thanks Andy for the review. Two quick comments before going further in
the details later.
>
>> The BayTrail and CherryTrail platforms provide platform clocks
>> through their Power Management Controller (PMC).
>>
>> The SoC supports up to 6 clocks (PMC_PLT_CLK[5:0]) with a
>> frequency of either 19.2 MHz (PLL) or 25 MHz (XTAL) for BayTrail
>> and a frequency of 19.2 MHz (XTAL) for CherryTrail. These clocks
>> are available for general system use, where appropriate, and each
>> have Control & Frequency register fields associated with them.
>>
>> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> Who is the actual author? SoB I guess should be either the author, or
> 1st, 2nd, ..., last one who is submitter.
I ported the initial code from Android legacy stuff and Irina ported the
functionality to the clk framework. It seems appropriate to have both
signed-offs?
[snip]
>
>> +#include <linux/platform_data/x86/clk-byt-plt.h>
This was a suggestion of Darren Hart in agreement with Thomas Gleixner.
see
http://mailman.alsa-project.org/pipermail/alsa-devel/2016-October/113936.html
Darren, did we get your proposal right?
>
> Is it indeed platform data? I would not create platform_data/x86
> without strong argument.
> Perhaps include/linux/clk/x86_pmc.h? (Yes, I know about clk-lpss.h
> which is old enough and was basically first try of clk stuff on x86)
next prev parent reply other threads:[~2016-12-13 0:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 18:01 [PATCH v6 0/3] Add platform clock for BayTrail platforms Irina Tirdea
2016-12-09 18:01 ` [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks Irina Tirdea
2016-12-12 23:39 ` Andy Shevchenko
2016-12-13 0:15 ` Pierre-Louis Bossart [this message]
2016-12-13 0:26 ` Andy Shevchenko
2016-12-16 18:36 ` Darren Hart
2016-12-16 18:49 ` Andy Shevchenko
2016-12-16 19:19 ` Darren Hart
2016-12-16 22:29 ` Andy Shevchenko
2016-12-16 22:58 ` Darren Hart
2016-12-19 11:04 ` Mark Brown
2016-12-13 1:16 ` Andy Shevchenko
2016-12-13 23:25 ` Stephen Boyd
2016-12-16 5:15 ` [alsa-devel] " Pierre-Louis Bossart
2016-12-16 8:46 ` Andy Shevchenko
2016-12-16 14:57 ` Pierre-Louis Bossart
2016-12-17 1:33 ` Stephen Boyd
2016-12-17 13:57 ` Andy Shevchenko
2016-12-19 16:11 ` Pierre-Louis Bossart
2016-12-21 23:05 ` Stephen Boyd
2016-12-22 1:07 ` Pierre-Louis Bossart
2016-12-22 18:29 ` Stephen Boyd
2016-12-22 18:42 ` Andy Shevchenko
2017-01-05 0:54 ` Pierre-Louis Bossart
2016-12-09 18:01 ` [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 Irina Tirdea
2016-12-12 23:43 ` Andy Shevchenko
2016-12-16 18:20 ` Darren Hart
2016-12-16 18:39 ` Andy Shevchenko
2016-12-09 18:01 ` [PATCH v6 3/3] platform/x86: Enable Atom PMC platform clocks Irina Tirdea
2016-12-13 0:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a98dcda-a662-958e-307f-5fe3f281ed9f@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=dvhart@infradead.org \
--cc=hpa@zytor.com \
--cc=irina.tirdea@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mturquette@baylibre.com \
--cc=pierre-louis.bossart@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.