From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Stephen Boyd <sboyd@codeaurora.org>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>,
linux-clk@vger.kernel.org, Irina Tirdea <irina.tirdea@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@intel.com>,
Michael Turquette <mturquette@baylibre.com>,
"x86@kernel.org" <x86@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>, Mark Brown <broonie@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Darren Hart <dvhart@infradead.org>, Takashi Iwai <tiwai@suse.com>,
platform-driver-x86@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Len Brown <lenb@kernel.org>
Subject: Re: [alsa-devel] [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks
Date: Mon, 19 Dec 2016 10:11:49 -0600 [thread overview]
Message-ID: <7f3d03dc-24fe-ec3f-4a3b-926c28f0ac86@linux.intel.com> (raw)
In-Reply-To: <CAHp75Vdn_8_fCQzkG7CPrnDZzhC7WUpGM1cyvfNRz0u_sc7RKA@mail.gmail.com>
On 12/17/16 7:57 AM, Andy Shevchenko wrote:
> On Sat, Dec 17, 2016 at 3:33 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> On 12/15, Pierre-Louis Bossart wrote:
>
>>> Clients use devm_clk_get() with a "pmc_plt_clk_<n>"
>>> argument.
>>
>> This is the problem. Clients should be calling clk_get() like:
>>
>> clk_get(dev, "signal name in datasheet")
>>
>> where the first argument is the device and the second argument is
>> some string that is meaningful to the device, not the system as a
>> whole. The way clkdev is intended is so that the dev argument's
>> dev_name() is combined with the con_id that matches some signale
>> name in the datasheet. This way when the same IP is put into some
>> other chip, the globally unique name doesn't need to change, just
>> the device name that's registered with the lookup. Obviously this
>> breaks down quite badly when dev_name() isn't stable. Is that
>> happening here?
>
> PMC Atom is a PCI device and thus each platform would have different
> dev_name(). Do you want to list all in each consumer if consumer wants
> to work on all of them or I missed something?
>
> So, the question is how clock getting will look like to work on
> currently both CherryTrail and BayTrail.
The name pmc_plt_clk_<n> follows the data sheet specification, where
this convention is suggested:
PLT_CLK[2:0] - Camera
PLT_CLK[3] - Audio Codec
PLT_CLK[4] -
PLT_CLK[5] - COMMs
These clocks are not internal but are made available to external
components through dedicated physical pins on the package, this external
visibility limits the scope for confusions, variations. I have not seen
any skews where these clocks and pins were changed at all.
next prev parent reply other threads:[~2016-12-19 16:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 18:01 [PATCH v6 0/3] Add platform clock for BayTrail platforms Irina Tirdea
2016-12-09 18:01 ` [PATCH v6 1/3] clk: x86: Add Atom PMC platform clocks Irina Tirdea
2016-12-12 23:39 ` Andy Shevchenko
2016-12-13 0:15 ` Pierre-Louis Bossart
2016-12-13 0:26 ` Andy Shevchenko
2016-12-16 18:36 ` Darren Hart
2016-12-16 18:49 ` Andy Shevchenko
2016-12-16 19:19 ` Darren Hart
2016-12-16 22:29 ` Andy Shevchenko
2016-12-16 22:58 ` Darren Hart
2016-12-19 11:04 ` Mark Brown
2016-12-13 1:16 ` Andy Shevchenko
2016-12-13 23:25 ` Stephen Boyd
2016-12-16 5:15 ` [alsa-devel] " Pierre-Louis Bossart
2016-12-16 8:46 ` Andy Shevchenko
2016-12-16 14:57 ` Pierre-Louis Bossart
2016-12-17 1:33 ` Stephen Boyd
2016-12-17 13:57 ` Andy Shevchenko
2016-12-19 16:11 ` Pierre-Louis Bossart [this message]
2016-12-21 23:05 ` Stephen Boyd
2016-12-22 1:07 ` Pierre-Louis Bossart
2016-12-22 18:29 ` Stephen Boyd
2016-12-22 18:42 ` Andy Shevchenko
2017-01-05 0:54 ` Pierre-Louis Bossart
2016-12-09 18:01 ` [PATCH v6 2/3] arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86 Irina Tirdea
2016-12-12 23:43 ` Andy Shevchenko
2016-12-16 18:20 ` Darren Hart
2016-12-16 18:39 ` Andy Shevchenko
2016-12-09 18:01 ` [PATCH v6 3/3] platform/x86: Enable Atom PMC platform clocks Irina Tirdea
2016-12-13 0:01 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f3d03dc-24fe-ec3f-4a3b-926c28f0ac86@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=dvhart@infradead.org \
--cc=hpa@zytor.com \
--cc=irina.tirdea@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mturquette@baylibre.com \
--cc=pierre-louis.bossart@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.