From: Paolo Bonzini <pbonzini@redhat.com>
To: Jing Zhang <jingzhangos@google.com>, KVM <kvm@vger.kernel.org>,
KVMARM <kvmarm@lists.cs.columbia.edu>,
LinuxMIPS <linux-mips@vger.kernel.org>,
KVMPPC <kvm-ppc@vger.kernel.org>,
LinuxS390 <linux-s390@vger.kernel.org>,
Fuad Tabba <tabba@google.com>
Subject: Re: [PATCH 2/4] KVM: stats: Use binary stats descriptors for debugfs interface
Date: Mon, 14 Jun 2021 11:51:21 +0200 [thread overview]
Message-ID: <1b57502b-116a-9be5-fa2f-1e8f5b5fce2d@redhat.com> (raw)
In-Reply-To: <20210614025351.365284-3-jingzhangos@google.com>
On 14/06/21 04:53, Jing Zhang wrote:
> + STATS_DESC_ICOUNTER_RONLY(VM, lpages),
> + STATS_DESC_ICOUNTER_RONLY(VM, nx_lpage_splits),
> STATS_DESC_ICOUNTER(VM, max_mmu_page_hash_collisions)
I think we're now adding too many macros.
max_mmu_page_hash_collisions is the only remaining instant counter that
is not read-only. In fact, in the statsfs prototype we made all instant
counters read-only.
You could add a third type in addition to instant and cumulative, let's
call it "peak". This essentially corresponds to the "max" aggregation
function in the statsfs prototype. Then instant counters would be read
only, while cumulative and peak would be read-write.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jing Zhang <jingzhangos@google.com>, KVM <kvm@vger.kernel.org>,
KVMARM <kvmarm@lists.cs.columbia.edu>,
LinuxMIPS <linux-mips@vger.kernel.org>,
KVMPPC <kvm-ppc@vger.kernel.org>,
LinuxS390 <linux-s390@vger.kernel.org>,
Fuad Tabba <tabba@google.com>
Subject: Re: [PATCH 2/4] KVM: stats: Use binary stats descriptors for debugfs interface
Date: Mon, 14 Jun 2021 11:51:21 +0200 [thread overview]
Message-ID: <1b57502b-116a-9be5-fa2f-1e8f5b5fce2d@redhat.com> (raw)
In-Reply-To: <20210614025351.365284-3-jingzhangos@google.com>
On 14/06/21 04:53, Jing Zhang wrote:
> + STATS_DESC_ICOUNTER_RONLY(VM, lpages),
> + STATS_DESC_ICOUNTER_RONLY(VM, nx_lpage_splits),
> STATS_DESC_ICOUNTER(VM, max_mmu_page_hash_collisions)
I think we're now adding too many macros.
max_mmu_page_hash_collisions is the only remaining instant counter that
is not read-only. In fact, in the statsfs prototype we made all instant
counters read-only.
You could add a third type in addition to instant and cumulative, let's
call it "peak". This essentially corresponds to the "max" aggregation
function in the statsfs prototype. Then instant counters would be read
only, while cumulative and peak would be read-write.
Paolo
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jing Zhang <jingzhangos@google.com>, KVM <kvm@vger.kernel.org>,
KVMARM <kvmarm@lists.cs.columbia.edu>,
LinuxMIPS <linux-mips@vger.kernel.org>,
KVMPPC <kvm-ppc@vger.kernel.org>,
LinuxS390 <linux-s390@vger.kernel.org>,
Fuad Tabba <tabba@google.com>
Subject: Re: [PATCH 2/4] KVM: stats: Use binary stats descriptors for debugfs interface
Date: Mon, 14 Jun 2021 09:51:21 +0000 [thread overview]
Message-ID: <1b57502b-116a-9be5-fa2f-1e8f5b5fce2d@redhat.com> (raw)
In-Reply-To: <20210614025351.365284-3-jingzhangos@google.com>
On 14/06/21 04:53, Jing Zhang wrote:
> + STATS_DESC_ICOUNTER_RONLY(VM, lpages),
> + STATS_DESC_ICOUNTER_RONLY(VM, nx_lpage_splits),
> STATS_DESC_ICOUNTER(VM, max_mmu_page_hash_collisions)
I think we're now adding too many macros.
max_mmu_page_hash_collisions is the only remaining instant counter that
is not read-only. In fact, in the statsfs prototype we made all instant
counters read-only.
You could add a third type in addition to instant and cumulative, let's
call it "peak". This essentially corresponds to the "max" aggregation
function in the statsfs prototype. Then instant counters would be read
only, while cumulative and peak would be read-write.
Paolo
next prev parent reply other threads:[~2021-06-14 9:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 2:53 [PATCH 0/4] Remove duplicated stats definitions for debugfs Jing Zhang
2021-06-14 2:53 ` Jing Zhang
2021-06-14 2:53 ` [PATCH 1/4] KVM: stats: Make sure no missing or mismatched binary stats definition Jing Zhang
2021-06-14 2:53 ` Jing Zhang
2021-06-14 2:53 ` Jing Zhang
2021-06-14 9:49 ` Fuad Tabba
2021-06-14 9:49 ` Fuad Tabba
2021-06-14 9:49 ` Fuad Tabba
2021-06-14 13:28 ` Jing Zhang
2021-06-14 13:28 ` Jing Zhang
2021-06-14 13:28 ` Jing Zhang
2021-06-16 12:55 ` kernel test robot
2021-06-16 12:55 ` kernel test robot
2021-06-16 12:55 ` kernel test robot
2021-06-16 12:55 ` kernel test robot
2021-06-14 2:53 ` [PATCH 2/4] KVM: stats: Use binary stats descriptors for debugfs interface Jing Zhang
2021-06-14 2:53 ` Jing Zhang
2021-06-14 2:53 ` Jing Zhang
2021-06-14 9:51 ` Paolo Bonzini [this message]
2021-06-14 9:51 ` Paolo Bonzini
2021-06-14 9:51 ` Paolo Bonzini
2021-06-14 13:36 ` Jing Zhang
2021-06-14 13:36 ` Jing Zhang
2021-06-14 13:36 ` Jing Zhang
2021-06-14 2:53 ` [PATCH 3/4] KVM: stats: Update documentation supporting stats mode and offset Jing Zhang
2021-06-14 2:53 ` Jing Zhang
2021-06-14 2:53 ` [PATCH 4/4] KVM: selftests: Update binary stats test for stats mode Jing Zhang
2021-06-14 2:53 ` Jing Zhang
2021-06-14 9:53 ` [PATCH 0/4] Remove duplicated stats definitions for debugfs Paolo Bonzini
2021-06-14 9:53 ` Paolo Bonzini
2021-06-14 9:53 ` Paolo Bonzini
2021-06-14 13:38 ` Jing Zhang
2021-06-14 13:38 ` Jing Zhang
2021-06-14 13:38 ` Jing Zhang
2021-06-16 14:21 [PATCH 2/4] KVM: stats: Use binary stats descriptors for debugfs interface kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b57502b-116a-9be5-fa2f-1e8f5b5fce2d@redhat.com \
--to=pbonzini@redhat.com \
--cc=jingzhangos@google.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-mips@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=tabba@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.