From: Chris Wilson <chris@chris-wilson.co.uk>
To: Julien Cristau <jcristau@debian.org>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Pretty print out the reason for rejecting the mode
Date: Tue, 05 Apr 2011 22:41:57 +0100 [thread overview]
Message-ID: <1bdc18$k4a62g@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <20110405213919.GZ3159@radis.liafa.jussieu.fr>
On Tue, 5 Apr 2011 23:39:19 +0200, Julien Cristau <jcristau@debian.org> wrote:
> On Tue, Apr 5, 2011 at 21:50:15 +0100, Chris Wilson wrote:
>
> > + if ((unsigned)status > ARRAY_SIZE(strings))
>
> off by one?
And didn't check for holes.
/me wishes he never sent this momentarily useful bit of code. ;-)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-04-05 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 20:50 [PATCH] drm: Pretty print out the reason for rejecting the mode Chris Wilson
2011-04-05 21:06 ` Marcin Ślusarz
2011-04-05 21:32 ` Chris Wilson
2011-04-06 14:10 ` Henri Verbeet
2011-04-05 21:39 ` Julien Cristau
2011-04-05 21:41 ` Chris Wilson [this message]
2011-04-06 14:32 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1bdc18$k4a62g@fmsmga002.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=jcristau@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.