Re: [PATCH] drm: Pretty print out the reason for rejecting the mode

From: Chris Wilson <chris@chris-wilson.co.uk>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Pretty print out the reason for rejecting the mode
Date: Tue, 05 Apr 2011 22:32:14 +0100	[thread overview]
Message-ID: <b7da2f$r00c33@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <BANLkTinHLQFYLcL99Cfid1pce=f5YLJw7Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

On Tue, 5 Apr 2011 23:06:19 +0200, Marcin Åšlusarz <marcin.slusarz@gmail.com> wrote:
> 2011/4/5 Chris Wilson <chris@chris-wilson.co.uk>:
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > Â drivers/gpu/drm/drm_modes.c | Â  52 +++++++++++++++++++++++++++++++++++++++++-
> > Â 1 files changed, 50 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> > index 25bf873..b3e07ac 100644
> > --- a/drivers/gpu/drm/drm_modes.c
> > +++ b/drivers/gpu/drm/drm_modes.c
> > @@ -853,6 +853,52 @@ void drm_mode_validate_clocks(struct drm_device *dev,
> > Â }
> > Â EXPORT_SYMBOL(drm_mode_validate_clocks);
> >
> > +static const char *mode_status_to_string(enum drm_mode_status status)
> > +{
> > + Â  Â  Â  const char *strings[] = {
> 
> + static?

Yes, it should be. I wonder if the compiler is smart enough (smarter than
me) for that to make no difference in this case...

> > + Â  Â  Â  Â  Â  Â  Â  [MODE_OK] = "OK",
> > + Â  Â  Â  Â  Â  Â  Â  [MODE_HSYNC] = "hsync out of range",
> > + Â  Â  Â  Â  Â  Â  Â  [MODE_VSYNC] = "vsync out of range",
> > + Â  Â  Â  Â  Â  Â  Â  [MODE_H_ILLEGAL] = "illegal horizontal timings",
> > + Â  Â  Â  Â  Â  Â  Â  [MODE_V_ILLEGAL] = "illegal vertical timings",
> > + Â  Â  Â  Â  Â  Â  Â  [MODE_BAD_WIDTH] = "requires an unsupported linepitch",
> > + Â  Â  Â  Â  Â  Â  Â  [MODE_NOMODE] = "no mode with a maching name",
> 
> s/maching/matching/

Cut'n'paste typo. Another patch for include/drm/drm_crtc.h required!

Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel