From: Simon South <simon@simonsouth.net>
To: tpiepho@gmail.com, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, robin.murphy@arm.com,
lee.jones@linaro.org, heiko@sntech.de, bbrezillon@kernel.org,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Cc: simon@simonsouth.net
Subject: [PATCH v3 3/7] pwm: rockchip: Replace "bus clk" with "PWM clk"
Date: Wed, 23 Dec 2020 11:01:05 -0500 [thread overview]
Message-ID: <1c2f85dafab03d6f5cdbcac37e7288de8f90e6d8.1608735481.git.simon@simonsouth.net> (raw)
In-Reply-To: <cover.1608735481.git.simon@simonsouth.net>
Clarify the Rockchip PWM driver's error messages by referring to the clock
that operates a PWM device as the "PWM" clock, rather than the "bus"
clock (which is especially misleading in the case of devices that also use
a separate clock for bus access).
Suggested-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Simon South <simon@simonsouth.net>
---
drivers/pwm/pwm-rockchip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c
index 0c940c7508ea..3b1aa5daafff 100644
--- a/drivers/pwm/pwm-rockchip.c
+++ b/drivers/pwm/pwm-rockchip.c
@@ -309,7 +309,7 @@ static int rockchip_pwm_probe(struct platform_device *pdev)
pc->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(pc->clk))
return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk),
- "Can't get bus clk\n");
+ "Can't get PWM clk\n");
}
count = of_count_phandle_with_args(pdev->dev.of_node,
@@ -328,7 +328,7 @@ static int rockchip_pwm_probe(struct platform_device *pdev)
ret = clk_prepare_enable(pc->clk);
if (ret) {
- dev_err(&pdev->dev, "Can't prepare enable bus clk: %d\n", ret);
+ dev_err(&pdev->dev, "Can't prepare enable PWM clk: %d\n", ret);
return ret;
}
--
2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Simon South <simon@simonsouth.net>
To: tpiepho@gmail.com, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, robin.murphy@arm.com,
lee.jones@linaro.org, heiko@sntech.de, bbrezillon@kernel.org,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Cc: simon@simonsouth.net
Subject: [PATCH v3 3/7] pwm: rockchip: Replace "bus clk" with "PWM clk"
Date: Wed, 23 Dec 2020 11:01:05 -0500 [thread overview]
Message-ID: <1c2f85dafab03d6f5cdbcac37e7288de8f90e6d8.1608735481.git.simon@simonsouth.net> (raw)
In-Reply-To: <cover.1608735481.git.simon@simonsouth.net>
Clarify the Rockchip PWM driver's error messages by referring to the clock
that operates a PWM device as the "PWM" clock, rather than the "bus"
clock (which is especially misleading in the case of devices that also use
a separate clock for bus access).
Suggested-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Simon South <simon@simonsouth.net>
---
drivers/pwm/pwm-rockchip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c
index 0c940c7508ea..3b1aa5daafff 100644
--- a/drivers/pwm/pwm-rockchip.c
+++ b/drivers/pwm/pwm-rockchip.c
@@ -309,7 +309,7 @@ static int rockchip_pwm_probe(struct platform_device *pdev)
pc->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(pc->clk))
return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk),
- "Can't get bus clk\n");
+ "Can't get PWM clk\n");
}
count = of_count_phandle_with_args(pdev->dev.of_node,
@@ -328,7 +328,7 @@ static int rockchip_pwm_probe(struct platform_device *pdev)
ret = clk_prepare_enable(pc->clk);
if (ret) {
- dev_err(&pdev->dev, "Can't prepare enable bus clk: %d\n", ret);
+ dev_err(&pdev->dev, "Can't prepare enable PWM clk: %d\n", ret);
return ret;
}
--
2.29.2
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Simon South <simon@simonsouth.net>
To: tpiepho@gmail.com, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, robin.murphy@arm.com,
lee.jones@linaro.org, heiko@sntech.de, bbrezillon@kernel.org,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Cc: simon@simonsouth.net
Subject: [PATCH v3 3/7] pwm: rockchip: Replace "bus clk" with "PWM clk"
Date: Wed, 23 Dec 2020 11:01:05 -0500 [thread overview]
Message-ID: <1c2f85dafab03d6f5cdbcac37e7288de8f90e6d8.1608735481.git.simon@simonsouth.net> (raw)
In-Reply-To: <cover.1608735481.git.simon@simonsouth.net>
Clarify the Rockchip PWM driver's error messages by referring to the clock
that operates a PWM device as the "PWM" clock, rather than the "bus"
clock (which is especially misleading in the case of devices that also use
a separate clock for bus access).
Suggested-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Simon South <simon@simonsouth.net>
---
drivers/pwm/pwm-rockchip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c
index 0c940c7508ea..3b1aa5daafff 100644
--- a/drivers/pwm/pwm-rockchip.c
+++ b/drivers/pwm/pwm-rockchip.c
@@ -309,7 +309,7 @@ static int rockchip_pwm_probe(struct platform_device *pdev)
pc->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(pc->clk))
return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk),
- "Can't get bus clk\n");
+ "Can't get PWM clk\n");
}
count = of_count_phandle_with_args(pdev->dev.of_node,
@@ -328,7 +328,7 @@ static int rockchip_pwm_probe(struct platform_device *pdev)
ret = clk_prepare_enable(pc->clk);
if (ret) {
- dev_err(&pdev->dev, "Can't prepare enable bus clk: %d\n", ret);
+ dev_err(&pdev->dev, "Can't prepare enable PWM clk: %d\n", ret);
return ret;
}
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-23 16:03 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 16:01 [PATCH v3 0/7] pwm: rockchip: Eliminate potential race condition when probing Simon South
2020-12-23 16:01 ` Simon South
2020-12-23 16:01 ` Simon South
2020-12-23 16:01 ` [PATCH v3 1/7] pwm: rockchip: Enable APB clock during register access while probing Simon South
2020-12-23 16:01 ` Simon South
2020-12-23 16:01 ` Simon South
2020-12-25 7:11 ` Kever Yang
2021-01-13 7:23 ` Uwe Kleine-König
2021-01-13 7:23 ` Uwe Kleine-König
2021-01-13 7:23 ` Uwe Kleine-König
2020-12-23 16:01 ` [PATCH v3 2/7] pwm: rockchip: rockchip_pwm_probe(): Remove superfluous clk_unprepare() Simon South
2020-12-23 16:01 ` Simon South
2020-12-23 16:01 ` Simon South
2021-01-13 7:31 ` Uwe Kleine-König
2021-01-13 7:31 ` Uwe Kleine-König
2021-01-13 7:31 ` Uwe Kleine-König
2020-12-23 16:01 ` Simon South [this message]
2020-12-23 16:01 ` [PATCH v3 3/7] pwm: rockchip: Replace "bus clk" with "PWM clk" Simon South
2020-12-23 16:01 ` Simon South
2020-12-25 7:13 ` Kever Yang
2021-01-13 7:33 ` Uwe Kleine-König
2021-01-13 7:33 ` Uwe Kleine-König
2021-01-13 7:33 ` Uwe Kleine-König
2020-12-23 16:01 ` [PATCH v3 4/7] pwm: rockchip: Eliminate potential race condition when probing Simon South
2020-12-23 16:01 ` Simon South
2020-12-23 16:01 ` Simon South
2021-01-13 7:37 ` Uwe Kleine-König
2021-01-13 7:37 ` Uwe Kleine-König
2021-01-13 7:37 ` Uwe Kleine-König
2020-12-23 16:01 ` [PATCH v3 5/7] pwm: rockchip: rockchip_pwm_probe(): Remove unneeded goto target Simon South
2020-12-23 16:01 ` Simon South
2020-12-23 16:01 ` Simon South
2020-12-25 7:14 ` Kever Yang
2021-01-13 7:38 ` Uwe Kleine-König
2021-01-13 7:38 ` Uwe Kleine-König
2021-01-13 7:38 ` Uwe Kleine-König
2020-12-23 16:01 ` [PATCH v3 6/7] pwm: rockchip: Enable PWM clock of probed device only if running Simon South
2020-12-23 16:01 ` Simon South
2020-12-23 16:01 ` Simon South
2020-12-25 7:14 ` Kever Yang
2021-01-13 7:50 ` Uwe Kleine-König
2021-01-13 7:50 ` Uwe Kleine-König
2021-01-13 7:50 ` Uwe Kleine-König
2021-01-14 15:22 ` Simon South
2021-01-14 15:22 ` Simon South
2021-01-14 15:22 ` Simon South
2020-12-23 16:01 ` [PATCH v3 7/7] pwm: rockchip: Enable clock before calling clk_get_rate() Simon South
2020-12-23 16:01 ` Simon South
2020-12-23 16:01 ` Simon South
2021-01-13 7:54 ` Uwe Kleine-König
2021-01-13 7:54 ` Uwe Kleine-König
2021-01-13 7:54 ` Uwe Kleine-König
2020-12-25 7:10 ` [PATCH v3 0/7] pwm: rockchip: Eliminate potential race condition when probing Kever Yang
2021-01-05 11:26 ` [PATCH v3 0/7] pwm: rockchip: Eliminate potential race condition when probing【请注意，邮件由kever.yang@gmail.com代发】 David Wu
2021-01-05 11:26 ` David Wu
2021-01-05 11:26 ` David Wu
2021-01-13 9:19 ` Uwe Kleine-König
2021-01-13 9:19 ` Uwe Kleine-König
2021-01-13 9:19 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c2f85dafab03d6f5cdbcac37e7288de8f90e6d8.1608735481.git.simon@simonsouth.net \
--to=simon@simonsouth.net \
--cc=bbrezillon@kernel.org \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=thierry.reding@gmail.com \
--cc=tpiepho@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.