From: Soeren Moch <smoch@web.de> To: Shawn Lin <shawn.lin@rock-chips.com>, Robin Murphy <robin.murphy@arm.com>, Heiko Stuebner <heiko@sntech.de> Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】 Date: Fri, 4 Oct 2019 05:39:52 +0200 [thread overview] Message-ID: <1c452b8b-853f-8f58-5f3a-0bbecbe20557@web.de> (raw) In-Reply-To: <120e2dbc-55eb-2205-b00f-7e50928ec706@rock-chips.com> On 04.10.19 04:13, Shawn Lin wrote: > On 2019/10/4 8:53, Soeren Moch wrote: >> >> >> On 04.10.19 02:01, Robin Murphy wrote: >>> On 2019-10-03 10:50 pm, Soeren Moch wrote: >>>> According to the RockPro64 schematic [1] the rk3399 sdmmc >>>> controller is >>>> connected to a microSD (TF card) slot, which cannot be switched to >>>> 1.8V. >>> >>> Really? AFAICS the SDMMC0 wiring looks pretty much identical to the >>> NanoPC-T4 schematic (it's the same reference design, after all), and I >>> know that board can happily drive a UHS-I microSD card with 1.8v I/Os, >>> because mine's doing so right now. >>> >>> Robin. >> OK, the RockPro64 does not allow a card reset (power cycle) since >> VCC3V0_SD is directly connected to VCC3V3_SYS (via R89555), the >> SDMMC0_PWH_H signal is not connected. So the card fails to identify >> itself after suspend or reboot when switched to 1.8V operation. >> > > I believe we addressed this issue long time ago, please check: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6a11fc47f175c8d87018e89cb58e2d36c66534cb > Thanks for the pointer. In this case I guess I should use following patch instead: --- rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +++ rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 @@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; }; When I do so, the sd card is detected as SDR104, but a reboot hangs: Boot1: 2018-06-26, version: 1.14 CPUId = 0x0 ChipType = 0x10, 286 Spi_ChipId = c84018 no find rkpartition SpiBootInit:ffffffff mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000 mmc: ERROR: Card did not respond to voltage select! emmc reinit mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000 mmc: ERROR: Card did not respond to voltage select! emmc reinit mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000 mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1 mmc0:cmd5,32 mmc0:cmd7,32 mmc0:cmd5,32 mmc0:cmd7,32 mmc0:cmd5,32 mmc0:cmd7,32 SdmmcInit=0 1 So I guess I should use a different miniloader for this reboot to work!? Or what else could be wrong here? Thanks, Soeren >> Regards, >> Soeren >>> >>>> So also configure the vcc_sdio regulator, which drives the i/o voltage >>>> of the sdmmc controller, accordingly. >>>> >>>> While at it, also remove the cap-mmc-highspeed property of the sdmmc >>>> controller, since no mmc card can be connected here. >>>> >>>> [1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf >>>> >>>> Fixes: e4f3fb490967 ("arm64: dts: rockchip: add initial dts support >>>> for Rockpro64") >>>> Signed-off-by: Soeren Moch <smoch@web.de> >>>> --- >>>> Cc: Heiko Stuebner <heiko@sntech.de> >>>> Cc: linux-rockchip@lists.infradead.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-kernel@vger.kernel.org >>>> --- >>>> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 3 +-- >>>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts >>>> b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts >>>> index 2e44dae4865a..084f1d994a50 100644 >>>> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts >>>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts >>>> @@ -353,7 +353,7 @@ >>>> regulator-name = "vcc_sdio"; >>>> regulator-always-on; >>>> regulator-boot-on; >>>> - regulator-min-microvolt = <1800000>; >>>> + regulator-min-microvolt = <3000000>; >>>> regulator-max-microvolt = <3000000>; >>>> regulator-state-mem { >>>> regulator-on-in-suspend; >>>> @@ -624,7 +624,6 @@ >>>> >>>> &sdmmc { >>>> bus-width = <4>; >>>> - cap-mmc-highspeed; >>>> cap-sd-highspeed; >>>> cd-gpios = <&gpio0 7 GPIO_ACTIVE_LOW>; >>>> disable-wp; >>>> -- >>>> 2.17.1 >>>> >>>> >>>> _______________________________________________ >>>> Linux-rockchip mailing list >>>> Linux-rockchip@lists.infradead.org >>>> http://lists.infradead.org/mailman/listinfo/linux-rockchip >>>> >> >> _______________________________________________ >> Linux-rockchip mailing list >> Linux-rockchip@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-rockchip >> > >
WARNING: multiple messages have this Message-ID (diff)
From: Soeren Moch <smoch@web.de> To: Shawn Lin <shawn.lin@rock-chips.com>, Robin Murphy <robin.murphy@arm.com>, Heiko Stuebner <heiko@sntech.de> Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】 Date: Fri, 4 Oct 2019 05:39:52 +0200 [thread overview] Message-ID: <1c452b8b-853f-8f58-5f3a-0bbecbe20557@web.de> (raw) In-Reply-To: <120e2dbc-55eb-2205-b00f-7e50928ec706@rock-chips.com> On 04.10.19 04:13, Shawn Lin wrote: > On 2019/10/4 8:53, Soeren Moch wrote: >> >> >> On 04.10.19 02:01, Robin Murphy wrote: >>> On 2019-10-03 10:50 pm, Soeren Moch wrote: >>>> According to the RockPro64 schematic [1] the rk3399 sdmmc >>>> controller is >>>> connected to a microSD (TF card) slot, which cannot be switched to >>>> 1.8V. >>> >>> Really? AFAICS the SDMMC0 wiring looks pretty much identical to the >>> NanoPC-T4 schematic (it's the same reference design, after all), and I >>> know that board can happily drive a UHS-I microSD card with 1.8v I/Os, >>> because mine's doing so right now. >>> >>> Robin. >> OK, the RockPro64 does not allow a card reset (power cycle) since >> VCC3V0_SD is directly connected to VCC3V3_SYS (via R89555), the >> SDMMC0_PWH_H signal is not connected. So the card fails to identify >> itself after suspend or reboot when switched to 1.8V operation. >> > > I believe we addressed this issue long time ago, please check: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6a11fc47f175c8d87018e89cb58e2d36c66534cb > Thanks for the pointer. In this case I guess I should use following patch instead: --- rk3399-rockpro64.dts.bak 2019-10-03 22:14:00.067745799 +0200 +++ rk3399-rockpro64.dts 2019-10-04 00:02:50.047892366 +0200 @@ -619,6 +619,8 @@ max-frequency = <150000000>; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; + sd-uhs-sdr104; + vqmmc-supply = <&vcc_sdio>; status = "okay"; }; When I do so, the sd card is detected as SDR104, but a reboot hangs: Boot1: 2018-06-26, version: 1.14 CPUId = 0x0 ChipType = 0x10, 286 Spi_ChipId = c84018 no find rkpartition SpiBootInit:ffffffff mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000 mmc: ERROR: Card did not respond to voltage select! emmc reinit mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000 mmc: ERROR: Card did not respond to voltage select! emmc reinit mmc: ERROR: SDHCI ERR:cmd:0x102,stat:0x18000 mmc: ERROR: Card did not respond to voltage select! SdmmcInit=2 1 mmc0:cmd5,32 mmc0:cmd7,32 mmc0:cmd5,32 mmc0:cmd7,32 mmc0:cmd5,32 mmc0:cmd7,32 SdmmcInit=0 1 So I guess I should use a different miniloader for this reboot to work!? Or what else could be wrong here? Thanks, Soeren >> Regards, >> Soeren >>> >>>> So also configure the vcc_sdio regulator, which drives the i/o voltage >>>> of the sdmmc controller, accordingly. >>>> >>>> While at it, also remove the cap-mmc-highspeed property of the sdmmc >>>> controller, since no mmc card can be connected here. >>>> >>>> [1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf >>>> >>>> Fixes: e4f3fb490967 ("arm64: dts: rockchip: add initial dts support >>>> for Rockpro64") >>>> Signed-off-by: Soeren Moch <smoch@web.de> >>>> --- >>>> Cc: Heiko Stuebner <heiko@sntech.de> >>>> Cc: linux-rockchip@lists.infradead.org >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: linux-kernel@vger.kernel.org >>>> --- >>>> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 3 +-- >>>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts >>>> b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts >>>> index 2e44dae4865a..084f1d994a50 100644 >>>> --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts >>>> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts >>>> @@ -353,7 +353,7 @@ >>>> regulator-name = "vcc_sdio"; >>>> regulator-always-on; >>>> regulator-boot-on; >>>> - regulator-min-microvolt = <1800000>; >>>> + regulator-min-microvolt = <3000000>; >>>> regulator-max-microvolt = <3000000>; >>>> regulator-state-mem { >>>> regulator-on-in-suspend; >>>> @@ -624,7 +624,6 @@ >>>> >>>> &sdmmc { >>>> bus-width = <4>; >>>> - cap-mmc-highspeed; >>>> cap-sd-highspeed; >>>> cd-gpios = <&gpio0 7 GPIO_ACTIVE_LOW>; >>>> disable-wp; >>>> -- >>>> 2.17.1 >>>> >>>> >>>> _______________________________________________ >>>> Linux-rockchip mailing list >>>> Linux-rockchip@lists.infradead.org >>>> http://lists.infradead.org/mailman/listinfo/linux-rockchip >>>> >> >> _______________________________________________ >> Linux-rockchip mailing list >> Linux-rockchip@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-rockchip >> > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-04 3:40 UTC|newest] Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-03 21:50 [PATCH 1/3] arm64: dts: rockchip: fix RockPro64 vdd-log regulator settings Soeren Moch 2019-10-03 21:50 ` Soeren Moch 2019-10-03 21:50 ` Soeren Moch 2019-10-03 21:50 ` [PATCH 2/3] arm64: dts: rockchip: fix RockPro64 sdhci settings Soeren Moch 2019-10-03 21:50 ` Soeren Moch 2019-10-04 20:05 ` Heiko Stuebner 2019-10-04 20:05 ` Heiko Stuebner 2019-10-03 21:50 ` [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings Soeren Moch 2019-10-03 21:50 ` Soeren Moch 2019-10-04 0:01 ` Robin Murphy 2019-10-04 0:01 ` Robin Murphy 2019-10-04 0:53 ` Soeren Moch 2019-10-04 0:53 ` Soeren Moch 2019-10-04 2:13 ` [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】 Shawn Lin 2019-10-04 2:13 ` Shawn Lin 2019-10-04 2:13 ` Shawn Lin 2019-10-04 3:39 ` Soeren Moch [this message] 2019-10-04 3:39 ` Soeren Moch 2019-10-04 14:20 ` Robin Murphy 2019-10-04 14:20 ` Robin Murphy 2019-10-04 14:42 ` Jonas Karlman 2019-10-04 14:42 ` Jonas Karlman 2019-10-04 14:42 ` Jonas Karlman 2019-10-04 15:33 ` Shawn Lin 2019-10-04 15:33 ` Shawn Lin 2019-10-04 15:33 ` Shawn Lin 2019-10-04 17:24 ` Sören Moch 2019-10-04 17:24 ` Sören Moch 2019-10-04 20:15 ` Soeren Moch 2019-10-04 20:15 ` Soeren Moch 2019-10-04 20:18 ` Heiko Stuebner 2019-10-04 20:18 ` Heiko Stuebner 2019-10-04 20:39 ` Sören Moch 2019-10-04 20:39 ` Sören Moch 2019-10-04 20:39 ` Sören Moch 2019-10-11 8:22 ` Jonas Karlman 2019-10-11 8:22 ` Jonas Karlman 2019-10-11 8:22 ` Jonas Karlman 2019-10-11 11:40 ` [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings Soeren Moch 2019-10-11 11:40 ` Soeren Moch 2019-10-11 13:00 ` Robin Murphy 2019-10-11 13:00 ` Robin Murphy 2019-10-11 13:00 ` Robin Murphy 2019-10-11 14:16 ` Soeren Moch 2019-10-11 14:16 ` Soeren Moch 2019-10-11 14:16 ` Soeren Moch 2019-10-12 4:09 ` Shawn Lin 2019-10-12 4:09 ` Shawn Lin 2019-10-12 12:45 ` Soeren Moch 2019-10-12 12:45 ` Soeren Moch 2019-10-12 12:45 ` Soeren Moch 2019-10-04 16:39 ` [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】 Soeren Moch 2019-10-04 16:39 ` Soeren Moch 2019-10-04 20:04 ` [PATCH 1/3] arm64: dts: rockchip: fix RockPro64 vdd-log regulator settings Heiko Stuebner 2019-10-04 20:04 ` Heiko Stuebner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1c452b8b-853f-8f58-5f3a-0bbecbe20557@web.de \ --to=smoch@web.de \ --cc=heiko@sntech.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=robin.murphy@arm.com \ --cc=shawn.lin@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.