From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
To: Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>, <mchehab@kernel.org>,
<chris@chris-wilson.co.uk>, <matthew.auld@intel.com>,
<thomas.hellstrom@linux.intel.com>, <jani.nikula@intel.com>,
<nirmoy.das@intel.com>, <airlied@redhat.com>, <daniel@ffwll.ch>,
<andi.shyti@linux.intel.com>, <andrzej.hajda@intel.com>,
<mauro.chehab@linux.intel.com>, <linux@rasmusvillemoes.dk>,
<vitor@massaru.org>, <dlatypov@google.com>,
<ndesaulniers@google.com>, <trix@redhat.com>,
<llvm@lists.linux.dev>, <linux-hardening@vger.kernel.org>,
<linux-sparse@vger.kernel.org>, <nathan@kernel.org>,
<gustavoars@kernel.org>, <luc.vanoostenryck@gmail.com>
Subject: Re: [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation
Date: Fri, 7 Oct 2022 19:40:36 +0300 [thread overview]
Message-ID: <1c7e171b-e5e8-7197-ddbc-346bac86176d@intel.com> (raw)
In-Reply-To: <202209281102.A86D736@keescook>
Linus and Kees, I also understood that I should not make and use the
macro that performs assignment and checking at the same time, and I will
drop it and update it.
Kees, the overflows_type() macro had several updates as input from you
and the community, and there is an advantage when moving to Linux common.
What are your thoughts on continuing to add the overflows_type() macro
to overflows.h?
Br,
G.G.
On 9/28/22 9:06 PM, Kees Cook wrote:
> On Wed, Sep 28, 2022 at 10:09:04AM -0700, Linus Torvalds wrote:
>> Kees, you need to reign in the craziness in overflow.h.
>
> Understood. I've been trying to help the drm folks walk a line between
> having a bunch of custom macros hidden away in the drm includes and
> building up generalized versions that are actually helpful beyond drm.
> But I can see that it doesn't help to have a "do two things at the same
> time" macro for the assignment checking.
>
WARNING: multiple messages have this Message-ID (diff)
From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
To: Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: gustavoars@kernel.org, trix@redhat.com, dlatypov@google.com,
llvm@lists.linux.dev, linux@rasmusvillemoes.dk,
dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk,
linux-hardening@vger.kernel.org, andrzej.hajda@intel.com,
linux-sparse@vger.kernel.org, matthew.auld@intel.com,
andi.shyti@linux.intel.com, airlied@redhat.com,
thomas.hellstrom@linux.intel.com, jani.nikula@intel.com,
intel-gfx@lists.freedesktop.org, nathan@kernel.org,
mchehab@kernel.org, mauro.chehab@linux.intel.com,
ndesaulniers@google.com, linux-kernel@vger.kernel.org,
vitor@massaru.org, luc.vanoostenryck@gmail.com,
nirmoy.das@intel.com
Subject: Re: [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation
Date: Fri, 7 Oct 2022 19:40:36 +0300 [thread overview]
Message-ID: <1c7e171b-e5e8-7197-ddbc-346bac86176d@intel.com> (raw)
In-Reply-To: <202209281102.A86D736@keescook>
Linus and Kees, I also understood that I should not make and use the
macro that performs assignment and checking at the same time, and I will
drop it and update it.
Kees, the overflows_type() macro had several updates as input from you
and the community, and there is an advantage when moving to Linux common.
What are your thoughts on continuing to add the overflows_type() macro
to overflows.h?
Br,
G.G.
On 9/28/22 9:06 PM, Kees Cook wrote:
> On Wed, Sep 28, 2022 at 10:09:04AM -0700, Linus Torvalds wrote:
>> Kees, you need to reign in the craziness in overflow.h.
>
> Understood. I've been trying to help the drm folks walk a line between
> having a bunch of custom macros hidden away in the drm includes and
> building up generalized versions that are actually helpful beyond drm.
> But I can see that it doesn't help to have a "do two things at the same
> time" macro for the assignment checking.
>
WARNING: multiple messages have this Message-ID (diff)
From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
To: Kees Cook <keescook@chromium.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: gustavoars@kernel.org, trix@redhat.com, dlatypov@google.com,
llvm@lists.linux.dev, linux@rasmusvillemoes.dk,
dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk,
linux-hardening@vger.kernel.org, andrzej.hajda@intel.com,
linux-sparse@vger.kernel.org, matthew.auld@intel.com,
airlied@redhat.com, thomas.hellstrom@linux.intel.com,
jani.nikula@intel.com, intel-gfx@lists.freedesktop.org,
nathan@kernel.org, mchehab@kernel.org, ndesaulniers@google.com,
linux-kernel@vger.kernel.org, daniel@ffwll.ch, vitor@massaru.org,
luc.vanoostenryck@gmail.com, nirmoy.das@intel.com
Subject: Re: [Intel-gfx] [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation
Date: Fri, 7 Oct 2022 19:40:36 +0300 [thread overview]
Message-ID: <1c7e171b-e5e8-7197-ddbc-346bac86176d@intel.com> (raw)
In-Reply-To: <202209281102.A86D736@keescook>
Linus and Kees, I also understood that I should not make and use the
macro that performs assignment and checking at the same time, and I will
drop it and update it.
Kees, the overflows_type() macro had several updates as input from you
and the community, and there is an advantage when moving to Linux common.
What are your thoughts on continuing to add the overflows_type() macro
to overflows.h?
Br,
G.G.
On 9/28/22 9:06 PM, Kees Cook wrote:
> On Wed, Sep 28, 2022 at 10:09:04AM -0700, Linus Torvalds wrote:
>> Kees, you need to reign in the craziness in overflow.h.
>
> Understood. I've been trying to help the drm folks walk a line between
> having a bunch of custom macros hidden away in the drm includes and
> building up generalized versions that are actually helpful beyond drm.
> But I can see that it doesn't help to have a "do two things at the same
> time" macro for the assignment checking.
>
next prev parent reply other threads:[~2022-10-07 16:41 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 8:12 [PATCH v13 0/9] Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation Gwan-gyeong Mun
2022-09-28 8:12 ` [Intel-gfx] " Gwan-gyeong Mun
2022-09-28 8:12 ` Gwan-gyeong Mun
2022-09-28 8:12 ` [PATCH v13 1/9] overflow: Allow mixed type arguments Gwan-gyeong Mun
2022-09-28 8:12 ` Gwan-gyeong Mun
2022-09-28 8:12 ` [Intel-gfx] " Gwan-gyeong Mun
2022-09-28 8:12 ` [PATCH v13 2/9] overflow: Introduce check_assign() and check_assign_user_ptr() Gwan-gyeong Mun
2022-09-28 8:12 ` Gwan-gyeong Mun
2022-09-28 8:12 ` [Intel-gfx] " Gwan-gyeong Mun
2022-09-28 8:12 ` [PATCH v13 3/9] overflow: Introduce overflows_type() and castable_to_type() Gwan-gyeong Mun
2022-09-28 8:12 ` Gwan-gyeong Mun
2022-09-28 8:12 ` [Intel-gfx] " Gwan-gyeong Mun
2022-09-28 8:12 ` [Intel-gfx] [PATCH v13 4/9] drm/i915/gem: Typecheck page lookups Gwan-gyeong Mun
2022-09-28 8:12 ` Gwan-gyeong Mun
2022-09-28 8:12 ` Gwan-gyeong Mun
2022-09-28 8:12 ` [PATCH v13 5/9] drm/i915: Check for integer truncation on scatterlist creation Gwan-gyeong Mun
2022-09-28 8:12 ` [Intel-gfx] " Gwan-gyeong Mun
2022-09-28 8:12 ` Gwan-gyeong Mun
2022-09-28 8:51 ` Jani Nikula
2022-09-28 8:51 ` [Intel-gfx] " Jani Nikula
2022-09-28 8:51 ` Jani Nikula
2022-10-07 16:38 ` Gwan-gyeong Mun
2022-10-07 16:38 ` [Intel-gfx] " Gwan-gyeong Mun
2022-10-07 16:38 ` Gwan-gyeong Mun
2022-09-28 17:09 ` Linus Torvalds
2022-09-28 17:09 ` [Intel-gfx] " Linus Torvalds
2022-09-28 17:09 ` Linus Torvalds
2022-09-28 18:06 ` Kees Cook
2022-09-28 18:06 ` Kees Cook
2022-09-28 18:06 ` [Intel-gfx] " Kees Cook
2022-10-07 16:40 ` Gwan-gyeong Mun [this message]
2022-10-07 16:40 ` Gwan-gyeong Mun
2022-10-07 16:40 ` Gwan-gyeong Mun
2022-10-07 16:45 ` Gwan-gyeong Mun
2022-10-07 16:45 ` [Intel-gfx] " Gwan-gyeong Mun
2022-10-07 16:45 ` Gwan-gyeong Mun
2022-09-28 8:12 ` [PATCH v13 6/9] drm/i915: Check for integer truncation on the configuration of ttm place Gwan-gyeong Mun
2022-09-28 8:12 ` [Intel-gfx] " Gwan-gyeong Mun
2022-09-28 8:12 ` Gwan-gyeong Mun
2022-09-28 8:12 ` [PATCH v13 7/9] drm/i915: Check if the size is too big while creating shmem file Gwan-gyeong Mun
2022-09-28 8:12 ` Gwan-gyeong Mun
2022-09-28 8:12 ` [Intel-gfx] " Gwan-gyeong Mun
2022-09-28 8:12 ` [PATCH v13 8/9] drm/i915: Use error code as -E2BIG when the size of gem ttm object is too large Gwan-gyeong Mun
2022-09-28 8:12 ` Gwan-gyeong Mun
2022-09-28 8:12 ` [Intel-gfx] " Gwan-gyeong Mun
2022-09-28 8:13 ` [PATCH v13 9/9] drm/i915: Remove truncation warning for large objects Gwan-gyeong Mun
2022-09-28 8:13 ` Gwan-gyeong Mun
2022-09-28 8:13 ` [Intel-gfx] " Gwan-gyeong Mun
2022-09-28 14:35 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fixes integer overflow or integer truncation issues in page lookups, ttm place configuration and scatterlist creation Patchwork
2022-09-28 14:35 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-09-28 14:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-29 8:44 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c7e171b-e5e8-7197-ddbc-346bac86176d@intel.com \
--to=gwan-gyeong.mun@intel.com \
--cc=airlied@redhat.com \
--cc=andi.shyti@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=dlatypov@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sparse@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=llvm@lists.linux.dev \
--cc=luc.vanoostenryck@gmail.com \
--cc=matthew.auld@intel.com \
--cc=mauro.chehab@linux.intel.com \
--cc=mchehab@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nirmoy.das@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=trix@redhat.com \
--cc=vitor@massaru.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.