From: Bart Van Assche <bvanassche@acm.org>
To: Mike Christie <mchristi@redhat.com>,
bstroesser@ts.fujitsu.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 08/11] target: add sysfs session helper functions
Date: Tue, 28 Apr 2020 16:43:38 +0000 [thread overview]
Message-ID: <1c97ee38-7a0e-5aac-6065-41267baea648@acm.org> (raw)
In-Reply-To: <20200428061109.3042-9-mchristi@redhat.com>
On 2020-04-27 23:11, Mike Christie wrote:
> + ret = kobject_add(&se_sess->kobj, se_tpg->sessions_kobj, "session-%d",
> + se_sess->sid);
> + if (ret) {
> + pr_err("Could not add session%d to sysfs. Error %d.\n",
> + se_sess->sid, ret);
> + goto free_acl_name;
> + }
Has it been considered to derive the directory name for a session from
the initiator name (se_node_acl.initiatorname-%d)? Would that be more
convenient for users than the session-%d naming scheme?
Thanks,
Bart.
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Mike Christie <mchristi@redhat.com>,
bstroesser@ts.fujitsu.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 08/11] target: add sysfs session helper functions
Date: Tue, 28 Apr 2020 09:43:38 -0700 [thread overview]
Message-ID: <1c97ee38-7a0e-5aac-6065-41267baea648@acm.org> (raw)
In-Reply-To: <20200428061109.3042-9-mchristi@redhat.com>
On 2020-04-27 23:11, Mike Christie wrote:
> + ret = kobject_add(&se_sess->kobj, se_tpg->sessions_kobj, "session-%d",
> + se_sess->sid);
> + if (ret) {
> + pr_err("Could not add session%d to sysfs. Error %d.\n",
> + se_sess->sid, ret);
> + goto free_acl_name;
> + }
Has it been considered to derive the directory name for a session from
the initiator name (se_node_acl.initiatorname-%d)? Would that be more
convenient for users than the session-%d naming scheme?
Thanks,
Bart.
next prev parent reply other threads:[~2020-04-28 16:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 6:10 [PATCH 00/11] target: add sysfs support Mike Christie
2020-04-28 6:10 ` Mike Christie
2020-04-28 6:10 ` [PATCH 01/11] target: check enforce_pr_isids during registration Mike Christie
2020-04-28 6:10 ` Mike Christie
2020-04-28 6:11 ` [PATCH 02/11] target: separate acl name from port ids Mike Christie
2020-04-28 6:11 ` Mike Christie
2020-04-28 16:14 ` Bart Van Assche
2020-04-28 16:14 ` Bart Van Assche
2020-04-28 6:11 ` [PATCH 03/11] iscsi target: setup transport_id Mike Christie
2020-04-28 6:11 ` Mike Christie
2020-04-28 6:11 ` [PATCH 04/11] target: use tpid in target_stat_iport_port_ident_show Mike Christie
2020-04-28 6:11 ` Mike Christie
2020-04-28 6:11 ` [PATCH 05/11] target: drop sess_get_initiator_sid from PR code Mike Christie
2020-04-28 6:11 ` Mike Christie
2020-04-28 6:11 ` [PATCH 06/11] target: drop sess_get_initiator_sid Mike Christie
2020-04-28 6:11 ` Mike Christie
2020-04-28 16:25 ` Bart Van Assche
2020-04-28 16:25 ` Bart Van Assche
2020-04-28 6:11 ` [PATCH 07/11] target: add sysfs support Mike Christie
2020-04-28 6:11 ` Mike Christie
2020-04-28 16:29 ` Bart Van Assche
2020-04-28 16:29 ` Bart Van Assche
2020-04-28 16:33 ` Mike Christie
2020-04-28 16:33 ` Mike Christie
2020-04-28 6:11 ` [PATCH 08/11] target: add sysfs session helper functions Mike Christie
2020-04-28 6:11 ` Mike Christie
2020-04-28 16:43 ` Bart Van Assche [this message]
2020-04-28 16:43 ` Bart Van Assche
2020-04-28 17:06 ` Mike Christie
2020-04-28 17:06 ` Mike Christie
2020-04-28 6:11 ` [PATCH 09/11] target: add target_setup_session sysfs support Mike Christie
2020-04-28 6:11 ` Mike Christie
2020-04-28 6:11 ` [PATCH 10/11] iscsi target: use session sysfs helpers Mike Christie
2020-04-28 6:11 ` Mike Christie
2020-04-28 6:11 ` [PATCH 11/11] target: drop sess_get_index Mike Christie
2020-04-28 6:11 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c97ee38-7a0e-5aac-6065-41267baea648@acm.org \
--to=bvanassche@acm.org \
--cc=bstroesser@ts.fujitsu.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchristi@redhat.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.