From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>, devel@driverdev.osuosl.org
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>,
Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Madhumitha Prabakaran <madhumithabiw@gmail.com>,
Malcolm Priestley <tvboxspy@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: vt6655: Fix memory leak in vt6655_probe
Date: Sat, 5 Oct 2019 18:30:13 +0200 [thread overview]
Message-ID: <1d0ba4c6-99ed-e2c9-48a2-ce34b0042876@web.de> (raw)
In-Reply-To: <20191004200319.22394-1-navid.emamdoost@gmail.com>
> In vt6655_probe, if vnt_init() fails the cleanup code needs to be called
> like other error handling cases. The call to device_free_info() is
> added.
Please improve this change description.
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>, devel@driverdev.osuosl.org
Cc: kernel-janitors@vger.kernel.org,
Malcolm Priestley <tvboxspy@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kangjie Lu <kjlu@umn.edu>,
linux-kernel@vger.kernel.org,
Madhumitha Prabakaran <madhumithabiw@gmail.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Navid Emamdoost <emamd001@umn.edu>,
Forest Bond <forest@alittletooquiet.net>,
Stephen McCamant <smccaman@umn.edu>
Subject: Re: [PATCH] staging: vt6655: Fix memory leak in vt6655_probe
Date: Sat, 05 Oct 2019 16:30:13 +0000 [thread overview]
Message-ID: <1d0ba4c6-99ed-e2c9-48a2-ce34b0042876@web.de> (raw)
In-Reply-To: <20191004200319.22394-1-navid.emamdoost@gmail.com>
> In vt6655_probe, if vnt_init() fails the cleanup code needs to be called
> like other error handling cases. The call to device_free_info() is
> added.
Please improve this change description.
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>, devel@driverdev.osuosl.org
Cc: kernel-janitors@vger.kernel.org,
Malcolm Priestley <tvboxspy@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kangjie Lu <kjlu@umn.edu>,
linux-kernel@vger.kernel.org,
Madhumitha Prabakaran <madhumithabiw@gmail.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Navid Emamdoost <emamd001@umn.edu>,
Forest Bond <forest@alittletooquiet.net>,
Stephen McCamant <smccaman@umn.edu>
Subject: Re: [PATCH] staging: vt6655: Fix memory leak in vt6655_probe
Date: Sat, 5 Oct 2019 18:30:13 +0200 [thread overview]
Message-ID: <1d0ba4c6-99ed-e2c9-48a2-ce34b0042876@web.de> (raw)
In-Reply-To: <20191004200319.22394-1-navid.emamdoost@gmail.com>
> In vt6655_probe, if vnt_init() fails the cleanup code needs to be called
> like other error handling cases. The call to device_free_info() is
> added.
Please improve this change description.
Regards,
Markus
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-10-05 16:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 20:03 [PATCH] staging: vt6655: Fix memory leak in vt6655_probe Navid Emamdoost
2019-10-04 20:03 ` Navid Emamdoost
2019-10-05 16:30 ` Markus Elfring [this message]
2019-10-05 16:30 ` Markus Elfring
2019-10-05 16:30 ` Markus Elfring
2019-10-05 18:40 ` Greg Kroah-Hartman
2019-10-05 18:40 ` Greg Kroah-Hartman
2019-10-05 18:40 ` Greg Kroah-Hartman
2019-10-06 5:39 ` Markus Elfring
2019-10-06 5:39 ` Markus Elfring
2019-10-06 5:39 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d0ba4c6-99ed-e2c9-48a2-ce34b0042876@web.de \
--to=markus.elfring@web.de \
--cc=devel@driverdev.osuosl.org \
--cc=emamd001@umn.edu \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=madhumithabiw@gmail.com \
--cc=mcgrof@kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=smccaman@umn.edu \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.