Re: [PATCH for-6.2/block V3 1/2] block: Data type conversion for IO accounting

From: Sagi Grimberg <sagi@grimberg.me>
To: Gulam Mohamed <gulam.mohamed@oracle.com>, linux-block@vger.kernel.org
Cc: axboe@kernel.dk, philipp.reisner@linbit.com,
	lars.ellenberg@linbit.com, christoph.boehmwalder@linbit.com,
	minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org,
	colyli@suse.de, kent.overstreet@gmail.com, agk@redhat.com,
	snitzer@kernel.org, dm-devel@redhat.com, song@kernel.org,
	dan.j.williams@intel.com, vishal.l.verma@intel.com,
	dave.jiang@intel.com, ira.weiny@intel.com, junxiao.bi@oracle.com,
	martin.petersen@oracle.com, kch@nvidia.com,
	drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org,
	linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org,
	nvdimm@lists.linux.dev, konrad.wilk@oracle.com,
	joe.jin@oracle.com, rajesh.sivaramasubramaniom@oracle.com,
	shminderjit.singh@oracle.com
Subject: Re: [PATCH for-6.2/block V3 1/2] block: Data type conversion for IO accounting
Date: Sun, 25 Dec 2022 13:40:23 +0200	[thread overview]
Message-ID: <1d0eb8e4-a91f-4635-bac7-9bc6cefbeff0@grimberg.me> (raw)
In-Reply-To: <20221221040506.1174644-1-gulam.mohamed@oracle.com>

On 12/21/22 06:05, Gulam Mohamed wrote:
> Change the data type of start and end time IO accounting variables in,
> block layer, from "unsigned long" to "u64". This is to enable nano-seconds
> granularity, in next commit, for the devices whose latency is less than
> milliseconds.
> 
> Changes from V2 to V3
> =====================
> 1. Changed all the required variables data-type to u64 as part of this
>     first patch
> 2. Create a new setting '2' for iostats in sysfs in next patch
> 3. Change the code to get the ktime values when iostat=2 in next patch
> 
> Signed-off-by: Gulam Mohamed <gulam.mohamed@oracle.com>
> ---
>   block/blk-core.c              | 24 ++++++++++++------------
>   block/blk.h                   |  2 +-
>   drivers/block/drbd/drbd_int.h |  2 +-
>   drivers/block/zram/zram_drv.c |  4 ++--
>   drivers/md/bcache/request.c   | 10 +++++-----
>   drivers/md/dm-core.h          |  2 +-
>   drivers/md/dm.c               |  2 +-
>   drivers/md/md.h               |  2 +-
>   drivers/md/raid1.h            |  2 +-
>   drivers/md/raid10.h           |  2 +-
>   drivers/md/raid5.c            |  2 +-
>   drivers/nvdimm/btt.c          |  2 +-
>   drivers/nvdimm/pmem.c         |  2 +-
>   include/linux/blk_types.h     |  2 +-
>   include/linux/blkdev.h        | 12 ++++++------
>   include/linux/part_stat.h     |  2 +-

nvme-mpath now also has stats, so struct nvme_request should also be
updated.