From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 2/5] qom: Remove ParentClassType argument from OBJECT_DECLARE_SIMPLE_TYPE
Date: Thu, 17 Sep 2020 09:47:54 +0200 [thread overview]
Message-ID: <1d10aff6-b9e8-4d2b-b4a6-6ad5f28a817b@redhat.com> (raw)
In-Reply-To: <20200916182519.415636-3-ehabkost@redhat.com>
On 9/16/20 8:25 PM, Eduardo Habkost wrote:
> The requirement to specify the parent class type makes the macro
> harder to use and easy to misuse (silent bugs can be introduced
> if the wrong struct type is specified).
>
> Simplify the macro by just not declaring any class struct,
> allowing us to remove the class_size field from the TypeInfo
> variables for those types.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Cc: "Daniel P. Berrangé" <berrange@redhat.com>
> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: qemu-devel@nongnu.org
> ---
> include/authz/list.h | 2 +-
> include/authz/listfile.h | 2 +-
> include/authz/pamacct.h | 2 +-
> include/authz/simple.h | 2 +-
> include/crypto/secret_keyring.h | 2 +-
> include/io/dns-resolver.h | 2 +-
> include/io/net-listener.h | 2 +-
> include/qom/object.h | 16 ++++++++--------
> include/sysemu/vhost-user-backend.h | 2 +-
> authz/list.c | 1 -
> authz/listfile.c | 1 -
> authz/pamacct.c | 1 -
> authz/simple.c | 1 -
> backends/dbus-vmstate.c | 3 +--
> backends/vhost-user.c | 1 -
> crypto/secret_keyring.c | 1 -
> io/dns-resolver.c | 1 -
> io/net-listener.c | 1 -
> ui/input-barrier.c | 3 +--
> ui/input-linux.c | 3 +--
> 20 files changed, 19 insertions(+), 30 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-09-17 7:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 18:25 [PATCH 0/5] qom: Convert more declarations to OBJECT_DECLARE* Eduardo Habkost
2020-09-16 18:25 ` [PATCH 1/5] scripts/codeconverter: Update to latest version Eduardo Habkost
2020-09-16 18:25 ` [PATCH 2/5] qom: Remove ParentClassType argument from OBJECT_DECLARE_SIMPLE_TYPE Eduardo Habkost
2020-09-17 7:47 ` Philippe Mathieu-Daudé [this message]
2020-09-16 18:25 ` [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros Eduardo Habkost
2020-09-16 18:25 ` Eduardo Habkost
2020-09-17 6:53 ` Thomas Huth
2020-09-17 6:53 ` Thomas Huth
2020-09-17 7:11 ` Igor Mammedov
2020-09-17 7:11 ` Igor Mammedov
2020-09-17 7:42 ` Cédric Le Goater
2020-09-17 7:42 ` Cédric Le Goater
2020-09-17 7:46 ` Cornelia Huck
2020-09-17 7:46 ` Cornelia Huck
2020-09-17 7:57 ` Paul Durrant
2020-09-17 7:57 ` Paul Durrant
2020-09-16 18:25 ` [PATCH 4/5] [automated] Use OBJECT_DECLARE_TYPE when possible Eduardo Habkost
2020-09-16 18:25 ` Eduardo Habkost
2020-09-17 7:47 ` Cédric Le Goater
2020-09-17 7:47 ` Cédric Le Goater
2020-09-17 7:57 ` Paul Durrant
2020-09-17 7:57 ` Paul Durrant
2020-09-16 18:25 ` [PATCH 5/5] [automated] Use OBJECT_DECLARE_SIMPLE_TYPE " Eduardo Habkost
2020-09-16 18:25 ` Eduardo Habkost
2020-09-17 7:57 ` Paul Durrant
2020-09-17 7:57 ` Paul Durrant
2020-09-18 18:17 ` [PATCH 0/5] qom: Convert more declarations to OBJECT_DECLARE* Eduardo Habkost
2020-09-18 18:17 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d10aff6-b9e8-4d2b-b4a6-6ad5f28a817b@redhat.com \
--to=philmd@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.