RE: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros

From: Paul Durrant <xadimgnik@gmail.com>
To: "'Eduardo Habkost'" <ehabkost@redhat.com>, <qemu-devel@nongnu.org>
Cc: "'Fam Zheng'" <fam@euphon.net>,
	"'Peter Maydell'" <peter.maydell@linaro.org>,
	"'Sarah Harris'" <S.E.Harris@kent.ac.uk>,
	"'Chris Wulff'" <crwulff@gmail.com>,
	"'Sagar Karandikar'" <sagark@eecs.berkeley.edu>,
	"'Michael S. Tsirkin'" <mst@redhat.com>,
	"'Anthony Green'" <green@moxielogic.com>,
	"'Mark Cave-Ayland'" <mark.cave-ayland@ilande.co.uk>,
	"'Aleksandar Rikalo'" <aleksandar.rikalo@syrmia.com>,
	"'Jiaxun Yang'" <jiaxun.yang@flygoat.com>,
	"'Max Filippov'" <jcmvbkbc@gmail.com>,
	"'Gerd Hoffmann'" <kraxel@redhat.com>,
	"'Edgar E. Iglesias'" <edgar.iglesias@gmail.com>,
	"'Guan Xuetao'" <gxt@mprc.pku.edu.cn>,
	"'Marek Vasut'" <marex@denx.de>,
	"'Stefano Stabellini'" <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org,
	"'Yoshinori Sato'" <ysato@users.sourceforge.jp>,
	"'David Hildenbrand'" <david@redhat.com>,
	"'Halil Pasic'" <pasic@linux.ibm.com>,
	"'Christian Borntraeger'" <borntraeger@de.ibm.com>,
	"'Aleksandar Markovic'" <aleksandar.qemu.devel@gmail.com>,
	"'Gonglei (Arei)'" <arei.gonglei@huawei.com>,
	"'Anthony Perard'" <anthony.perard@citrix.com>,
	"'Marc-André Lureau'" <marcandre.lureau@redhat.com>,
	"'Richard Henderson'" <rth@twiddle.net>,
	"'Artyom Tarasenko'" <atar4qemu@gmail.com>,
	"'Laurent Vivier'" <lvivier@redhat.com>,
	"'Thomas Huth'" <thuth@redhat.com>,
	"'Amit Shah'" <amit@kernel.org>,
	"'Alistair Francis'" <alistair@alistair23.me>,
	qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
	"'Michael Rolnik'" <mrolnik@gmail.com>,
	"'Cédric Le Goater'" <clg@kaod.org>,
	"'Igor Mammedov'" <imammedo@redhat.com>,
	qemu-ppc@nongnu.org, "'Stafford Horne'" <shorne@gmail.com>,
	"'Palmer Dabbelt'" <palmer@dabbelt.com>,
	"'David Gibson'" <david@gibson.dropbear.id.au>,
	"'Daniel P. Berrange'" <berrange@redhat.com>,
	qemu-block@nongnu.org, qemu-riscv@nongnu.org,
	"'Bastian Koppelmann'" <kbastian@mail.uni-paderborn.de>,
	"'Cornelia Huck'" <cohuck@redhat.com>,
	"'Philippe Mathieu-Daudé'" <f4bug@amsat.org>,
	"'Michael Walle'" <michael@walle.cc>,
	"'Corey Minyard'" <cminyard@mvista.com>,
	"'Paolo Bonzini'" <pbonzini@redhat.com>,
	"'Aurelien Jarno'" <aurelien@aurel32.net>,
	"'Stefan Berger'" <stefanb@linux.ibm.com>
Subject: RE: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros
Date: Thu, 17 Sep 2020 08:57:33 +0100	[thread overview]
Message-ID: <007c01d68cc8$347614f0$9d623ed0$@xen.org> (raw)
In-Reply-To: <20200916182519.415636-4-ehabkost@redhat.com>

> -----Original Message-----
> From: Eduardo Habkost <ehabkost@redhat.com>
> Sent: 16 September 2020 19:25
> To: qemu-devel@nongnu.org
> Cc: Paolo Bonzini <pbonzini@redhat.com>; Daniel P. Berrange <berrange@redhat.com>; Marc-André Lureau
> <marcandre.lureau@redhat.com>; Gerd Hoffmann <kraxel@redhat.com>; Michael S. Tsirkin <mst@redhat.com>;
> Peter Maydell <peter.maydell@linaro.org>; Corey Minyard <cminyard@mvista.com>; Cédric Le Goater
> <clg@kaod.org>; David Gibson <david@gibson.dropbear.id.au>; Cornelia Huck <cohuck@redhat.com>; Thomas
> Huth <thuth@redhat.com>; Halil Pasic <pasic@linux.ibm.com>; Christian Borntraeger
> <borntraeger@de.ibm.com>; Philippe Mathieu-Daudé <f4bug@amsat.org>; Alistair Francis
> <alistair@alistair23.me>; David Hildenbrand <david@redhat.com>; Laurent Vivier <lvivier@redhat.com>;
> Amit Shah <amit@kernel.org>; Stefano Stabellini <sstabellini@kernel.org>; Anthony Perard
> <anthony.perard@citrix.com>; Paul Durrant <paul@xen.org>; Fam Zheng <fam@euphon.net>; Gonglei (Arei)
> <arei.gonglei@huawei.com>; Igor Mammedov <imammedo@redhat.com>; Stefan Berger <stefanb@linux.ibm.com>;
> Richard Henderson <rth@twiddle.net>; Michael Rolnik <mrolnik@gmail.com>; Sarah Harris
> <S.E.Harris@kent.ac.uk>; Edgar E. Iglesias <edgar.iglesias@gmail.com>; Michael Walle
> <michael@walle.cc>; Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>; Aurelien Jarno
> <aurelien@aurel32.net>; Jiaxun Yang <jiaxun.yang@flygoat.com>; Aleksandar Rikalo
> <aleksandar.rikalo@syrmia.com>; Anthony Green <green@moxielogic.com>; Chris Wulff <crwulff@gmail.com>;
> Marek Vasut <marex@denx.de>; Stafford Horne <shorne@gmail.com>; Palmer Dabbelt <palmer@dabbelt.com>;
> Sagar Karandikar <sagark@eecs.berkeley.edu>; Bastian Koppelmann <kbastian@mail.uni-paderborn.de>;
> Yoshinori Sato <ysato@users.sourceforge.jp>; Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>; Artyom
> Tarasenko <atar4qemu@gmail.com>; Guan Xuetao <gxt@mprc.pku.edu.cn>; Max Filippov <jcmvbkbc@gmail.com>;
> qemu-arm@nongnu.org; qemu-ppc@nongnu.org; qemu-s390x@nongnu.org; qemu-block@nongnu.org; xen-
> devel@lists.xenproject.org; qemu-riscv@nongnu.org
> Subject: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros
> 
> One of the goals of having less boilerplate on QOM declarations
> is to avoid human error.  Requiring an extra argument that is
> never used is an opportunity for mistakes.
> 
> Remove the unused argument from OBJECT_DECLARE_TYPE and
> OBJECT_DECLARE_SIMPLE_TYPE.
> 
> Coccinelle patch used to convert all users of the macros:
> 
>   @@
>   declarer name OBJECT_DECLARE_TYPE;
>   identifier InstanceType, ClassType, lowercase, UPPERCASE;
>   @@
>    OBJECT_DECLARE_TYPE(InstanceType, ClassType,
>   -                    lowercase,
>                        UPPERCASE);
> 
>   @@
>   declarer name OBJECT_DECLARE_SIMPLE_TYPE;
>   identifier InstanceType, lowercase, UPPERCASE;
>   @@
>    OBJECT_DECLARE_SIMPLE_TYPE(InstanceType,
>   -                    lowercase,
>                        UPPERCASE);
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Acked-by: Paul Durrant <paul@xen.org>