From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
Abel Vesa <abelvesa@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: kernel@pengutronix.de, Peng Fan <peng.fan@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Trimarchi <michael@amarulasolutions.com>,
Mark Brown <broonie@kernel.org>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Anson Huang <Anson.Huang@nxp.com>, Marek Vasut <marex@denx.de>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-input@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v1 1/7] dt-bindings: mmc: fsl-imx-esdhc: Add imx6ul support
Date: Fri, 2 Jun 2023 10:27:12 +0200 [thread overview]
Message-ID: <1d6f70ab-e971-4a83-a9b3-e049b38c29a0@linaro.org> (raw)
In-Reply-To: <20230601101451.357662-2-o.rempel@pengutronix.de>
On 01/06/2023 12:14, Oleksij Rempel wrote:
> Add the 'fsl,imx6ul-usdhc' value to the compatible properties list in
> the fsl-imx-esdhc.yaml file. This is required to match the compatible
> strings present in the 'mmc@2190000' node of 'imx6ul-prti6g.dtb'. This
> commit addresses the following dtbs_check warning:
> imx6ul-prti6g.dtb: mmc@2190000: compatible: 'oneOf' conditional failed,
> one must be fixed: ['fsl,imx6ul-usdhc', 'fsl,imx6sx-usdhc'] is too long
> 'fsl,imx6ul-usdhc' is not one of ['fsl,imx25-esdhc', 'fsl,imx35-esdhc',
> 'fsl,imx51-esdhc', 'fsl,imx53-esdhc', 'fsl,imx6q-usdhc',
> 'fsl,imx6sl-usdhc', 'fsl,imx6sx-usdhc', 'fsl,imx7d-usdhc',
> 'fsl,imx7ulp-usdhc', 'fsl,imx8mm-usdhc', 'fsl,imxrt1050-usdhc',
> 'nxp,s32g2-usdhc']
> From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
Except what Conor wrote, please don't wrap that much the error log - it
is unreadable. Trim it, remove unneeded parts and keep some decent
one/two lines even if it exceeds the commit msg. This applies to other
patches as well.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
Abel Vesa <abelvesa@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: kernel@pengutronix.de, Peng Fan <peng.fan@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Trimarchi <michael@amarulasolutions.com>,
Mark Brown <broonie@kernel.org>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Anson Huang <Anson.Huang@nxp.com>, Marek Vasut <marex@denx.de>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-input@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v1 1/7] dt-bindings: mmc: fsl-imx-esdhc: Add imx6ul support
Date: Fri, 2 Jun 2023 10:27:12 +0200 [thread overview]
Message-ID: <1d6f70ab-e971-4a83-a9b3-e049b38c29a0@linaro.org> (raw)
In-Reply-To: <20230601101451.357662-2-o.rempel@pengutronix.de>
On 01/06/2023 12:14, Oleksij Rempel wrote:
> Add the 'fsl,imx6ul-usdhc' value to the compatible properties list in
> the fsl-imx-esdhc.yaml file. This is required to match the compatible
> strings present in the 'mmc@2190000' node of 'imx6ul-prti6g.dtb'. This
> commit addresses the following dtbs_check warning:
> imx6ul-prti6g.dtb: mmc@2190000: compatible: 'oneOf' conditional failed,
> one must be fixed: ['fsl,imx6ul-usdhc', 'fsl,imx6sx-usdhc'] is too long
> 'fsl,imx6ul-usdhc' is not one of ['fsl,imx25-esdhc', 'fsl,imx35-esdhc',
> 'fsl,imx51-esdhc', 'fsl,imx53-esdhc', 'fsl,imx6q-usdhc',
> 'fsl,imx6sl-usdhc', 'fsl,imx6sx-usdhc', 'fsl,imx7d-usdhc',
> 'fsl,imx7ulp-usdhc', 'fsl,imx8mm-usdhc', 'fsl,imxrt1050-usdhc',
> 'nxp,s32g2-usdhc']
> From schema: Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
Except what Conor wrote, please don't wrap that much the error log - it
is unreadable. Trim it, remove unneeded parts and keep some decent
one/two lines even if it exceeds the commit msg. This applies to other
patches as well.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-02 8:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 10:14 [PATCH v1 0/7] Add support for various features to i.MX6 bindings Oleksij Rempel
2023-06-01 10:14 ` Oleksij Rempel
2023-06-01 10:14 ` [PATCH v1 1/7] dt-bindings: mmc: fsl-imx-esdhc: Add imx6ul support Oleksij Rempel
2023-06-01 10:14 ` Oleksij Rempel
2023-06-01 18:18 ` Conor Dooley
2023-06-01 18:18 ` Conor Dooley
2023-06-01 18:19 ` Conor Dooley
2023-06-01 18:19 ` Conor Dooley
2023-06-02 8:27 ` Krzysztof Kozlowski [this message]
2023-06-02 8:27 ` Krzysztof Kozlowski
2023-06-01 10:14 ` [PATCH v1 2/7] dt-bindings: timer: gpt: Add i.MX6UL support Oleksij Rempel
2023-06-01 10:14 ` Oleksij Rempel
2023-06-01 18:20 ` Conor Dooley
2023-06-01 18:20 ` Conor Dooley
2023-06-01 10:14 ` [PATCH v1 3/7] dt-bindings: timer: gpt: Support 3rd clock for i.MX6DL Oleksij Rempel
2023-06-01 10:14 ` Oleksij Rempel
2023-06-01 18:22 ` Conor Dooley
2023-06-01 18:22 ` Conor Dooley
2023-06-14 19:03 ` Rob Herring
2023-06-14 19:03 ` Rob Herring
2023-06-01 10:14 ` [PATCH v1 4/7] dt-bindings: crypto: fsl-dcp: Add i.MX6SL, i.MX6SLL, and i.MX6ULL support Oleksij Rempel
2023-06-01 10:14 ` Oleksij Rempel
2023-06-01 18:26 ` Conor Dooley
2023-06-01 18:26 ` Conor Dooley
2023-06-01 10:14 ` [PATCH v1 5/7] dt-bindings: clock: imx6ul: Support optional enet*_ref_pad clocks Oleksij Rempel
2023-06-01 10:14 ` Oleksij Rempel
2023-06-14 19:13 ` Rob Herring
2023-06-14 19:13 ` Rob Herring
2023-06-01 10:14 ` [PATCH v1 6/7] dt-bindings: clock: imx6q: Allow single optional clock and add enet_ref_pad Oleksij Rempel
2023-06-01 10:14 ` Oleksij Rempel
2023-06-14 19:18 ` Rob Herring
2023-06-14 19:18 ` Rob Herring
2023-06-01 10:14 ` [PATCH v1 7/7] dt-bindings: input: touchscreen: edt-ft5x06: Add 'threshold' property Oleksij Rempel
2023-06-01 10:14 ` Oleksij Rempel
2023-06-14 19:21 ` Rob Herring
2023-06-14 19:21 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d6f70ab-e971-4a83-a9b3-e049b38c29a0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Anson.Huang@nxp.com \
--cc=abelvesa@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=festevam@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=marex@denx.de \
--cc=michael@amarulasolutions.com \
--cc=mturquette@baylibre.com \
--cc=o.rempel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.