From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Tamas K Lengyel <tamas@tklengyel.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 13/14] xen/mm: Convert {s, g}et_gpfn_from_mfn() to use typesafe MFN
Date: Fri, 10 May 2019 15:27:43 +0100 [thread overview]
Message-ID: <1dd02ece-4d2c-0600-4078-f3dde8d7d5ab@citrix.com> (raw)
In-Reply-To: <5CD58740020000780022D9D4@prv1-mh.provo.novell.com>
On 10/05/2019 15:14, Jan Beulich wrote:
>>>> On 10.05.19 at 16:05, <andrew.cooper3@citrix.com> wrote:
>> The overwhelming majority way of printing mfns is via:
>>
>> mfn %"PRI_mfn"
>>
>> which is almost fully consistent across the x86 code.
>>
>> Various bits of common code, and most of ARM code use variations of
>> %#"PRI_mfn", and this ought to be fixed.
> Oh, so you're fine with omitting the 0x here? That's fine with me. I've
> suggested its addition merely because commonly you ask for the prefix.
This falls into the category of "what is commonly done" vs "what is ideal".
Personally, I'd prefer to have no ambiguity between dec and hex, and
would in principle prefer to start printing mfns with a leading 0x.
However, we a) don't have the current expectations documented, and b) I
consider it rude and obstructive to make an undocumented change to
expectations as part of reviewing an unrelated change. (I certainly
find it obstructive when others do it to me in review.)
So long as the number is clearly identified as an mfn (which it wasn't
previously), the prevailing format used in Xen is %05lx, and this what
should be used.
When point a) above is addressed, there can be a proposed change to
expectations by patching the docs and adjusting the existing users.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Tamas K Lengyel <tamas@tklengyel.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 13/14] xen/mm: Convert {s, g}et_gpfn_from_mfn() to use typesafe MFN
Date: Fri, 10 May 2019 15:27:43 +0100 [thread overview]
Message-ID: <1dd02ece-4d2c-0600-4078-f3dde8d7d5ab@citrix.com> (raw)
Message-ID: <20190510142743.WqXBVuWBBUUh--cuGs8Y2WgJ6I_tO4y_myOiasZ4iTo@z> (raw)
In-Reply-To: <5CD58740020000780022D9D4@prv1-mh.provo.novell.com>
On 10/05/2019 15:14, Jan Beulich wrote:
>>>> On 10.05.19 at 16:05, <andrew.cooper3@citrix.com> wrote:
>> The overwhelming majority way of printing mfns is via:
>>
>> mfn %"PRI_mfn"
>>
>> which is almost fully consistent across the x86 code.
>>
>> Various bits of common code, and most of ARM code use variations of
>> %#"PRI_mfn", and this ought to be fixed.
> Oh, so you're fine with omitting the 0x here? That's fine with me. I've
> suggested its addition merely because commonly you ask for the prefix.
This falls into the category of "what is commonly done" vs "what is ideal".
Personally, I'd prefer to have no ambiguity between dec and hex, and
would in principle prefer to start printing mfns with a leading 0x.
However, we a) don't have the current expectations documented, and b) I
consider it rude and obstructive to make an undocumented change to
expectations as part of reviewing an unrelated change. (I certainly
find it obstructive when others do it to me in review.)
So long as the number is clearly identified as an mfn (which it wasn't
previously), the prevailing format used in Xen is %05lx, and this what
should be used.
When point a) above is addressed, there can be a proposed change to
expectations by patching the docs and adjusting the existing users.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-10 14:27 UTC|newest]
Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 15:14 [PATCH 00/14] xen/arm: Properly disable M2P on Arm Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-07 15:14 ` [PATCH 01/14] xen/arm: Use mfn_to_pdx instead of pfn_to_pdx when possible Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-09 17:50 ` Stefano Stabellini
2019-05-09 17:50 ` [Xen-devel] " Stefano Stabellini
2019-05-07 15:14 ` [PATCH 02/14] xen/x86: Constify the parameter "d" in mfn_to_gfn Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-07 15:14 ` [PATCH 03/14] xen/x86: Make mfn_to_gfn typesafe Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-10 11:35 ` Jan Beulich
2019-05-10 11:35 ` [Xen-devel] " Jan Beulich
2019-05-10 13:02 ` Julien Grall
2019-05-10 13:02 ` [Xen-devel] " Julien Grall
2019-05-10 13:24 ` Jan Beulich
2019-05-10 13:24 ` [Xen-devel] " Jan Beulich
2019-05-10 13:25 ` Julien Grall
2019-05-10 13:25 ` [Xen-devel] " Julien Grall
2019-05-20 15:13 ` Julien Grall
2019-05-20 15:13 ` [Xen-devel] " Julien Grall
2019-05-28 17:29 ` George Dunlap
2019-05-28 17:29 ` [Xen-devel] " George Dunlap
2019-05-29 11:39 ` Julien Grall
2019-05-29 11:39 ` [Xen-devel] " Julien Grall
2019-05-07 15:14 ` [PATCH 04/14] xen/x86: Use mfn_to_gfn rather than mfn_to_gmfn Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-10 12:15 ` Jan Beulich
2019-05-10 12:15 ` [Xen-devel] " Jan Beulich
2019-05-10 13:07 ` Julien Grall
2019-05-10 13:07 ` [Xen-devel] " Julien Grall
2019-05-07 15:14 ` [PATCH 05/14] xen/grant-table: Make arch specific macros typesafe Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-09 17:54 ` Stefano Stabellini
2019-05-09 17:54 ` [Xen-devel] " Stefano Stabellini
2019-05-07 15:14 ` [PATCH 06/14] xen: Convert hotplug page function to use typesafe MFN Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-09 18:01 ` Stefano Stabellini
2019-05-09 18:01 ` [Xen-devel] " Stefano Stabellini
2019-05-09 18:10 ` Julien Grall
2019-05-09 18:10 ` [Xen-devel] " Julien Grall
2019-05-07 15:14 ` [PATCH 07/14] xen: Convert is_xen_fixed_mfn " Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-24 15:16 ` George Dunlap
2019-05-24 15:16 ` [Xen-devel] " George Dunlap
2019-05-07 15:14 ` [PATCH 08/14] xen: Convert is_xen_heap_mfn " Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-24 15:15 ` George Dunlap
2019-05-24 15:15 ` [Xen-devel] " George Dunlap
2019-05-07 15:14 ` [PATCH 09/14] xen: Introduce HAS_M2P config and use to protect mfn_to_gmfn call Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-09 18:06 ` Stefano Stabellini
2019-05-09 18:06 ` [Xen-devel] " Stefano Stabellini
2019-05-09 18:12 ` Julien Grall
2019-05-09 18:12 ` [Xen-devel] " Julien Grall
2019-05-09 18:16 ` Stefano Stabellini
2019-05-09 18:16 ` [Xen-devel] " Stefano Stabellini
2019-05-09 18:29 ` Julien Grall
2019-05-09 18:29 ` [Xen-devel] " Julien Grall
2019-05-09 19:49 ` Stefano Stabellini
2019-05-09 19:49 ` [Xen-devel] " Stefano Stabellini
2019-05-10 12:31 ` Jan Beulich
2019-05-10 12:31 ` [Xen-devel] " Jan Beulich
2019-05-10 13:22 ` Julien Grall
2019-05-10 13:22 ` [Xen-devel] " Julien Grall
2019-05-10 13:32 ` Jan Beulich
2019-05-10 13:32 ` [Xen-devel] " Jan Beulich
2019-05-10 13:41 ` Julien Grall
2019-05-10 13:41 ` [Xen-devel] " Julien Grall
2019-05-10 13:45 ` Jan Beulich
2019-05-10 13:45 ` [Xen-devel] " Jan Beulich
2019-05-10 14:04 ` Julien Grall
2019-05-10 14:04 ` [Xen-devel] " Julien Grall
2019-05-10 14:19 ` Jan Beulich
2019-05-10 14:19 ` [Xen-devel] " Jan Beulich
2019-05-10 14:34 ` Julien Grall
2019-05-10 14:34 ` [Xen-devel] " Julien Grall
2019-05-22 16:03 ` Julien Grall
2019-05-22 16:03 ` [Xen-devel] " Julien Grall
2019-05-07 15:14 ` [PATCH 10/14] xen: Remove mfn_to_gmfn macro Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-07 15:14 ` [PATCH 11/14] xen/x86: mm: Re-implement set_gpfn_from_mfn() as a static inline function Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-10 12:43 ` Jan Beulich
2019-05-10 12:43 ` [Xen-devel] " Jan Beulich
2019-05-10 13:27 ` Julien Grall
2019-05-10 13:27 ` [Xen-devel] " Julien Grall
2019-05-10 13:35 ` Jan Beulich
2019-05-10 13:35 ` [Xen-devel] " Jan Beulich
2019-05-10 13:41 ` Julien Grall
2019-05-10 13:41 ` [Xen-devel] " Julien Grall
2019-05-10 13:48 ` Jan Beulich
2019-05-10 13:48 ` [Xen-devel] " Jan Beulich
2019-05-10 14:05 ` Julien Grall
2019-05-10 14:05 ` [Xen-devel] " Julien Grall
2019-05-10 14:21 ` Jan Beulich
2019-05-10 14:21 ` [Xen-devel] " Jan Beulich
2019-05-10 14:48 ` Julien Grall
2019-05-10 14:48 ` [Xen-devel] " Julien Grall
2019-05-07 15:14 ` [PATCH 12/14] xen/x86: pv: Convert update_intpte() to use typesafe MFN Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-10 12:54 ` Jan Beulich
2019-05-10 12:54 ` [Xen-devel] " Jan Beulich
2019-05-10 13:28 ` Julien Grall
2019-05-10 13:28 ` [Xen-devel] " Julien Grall
2019-05-07 15:14 ` [PATCH 13/14] xen/mm: Convert {s, g}et_gpfn_from_mfn() " Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-07 20:27 ` Tamas K Lengyel
2019-05-07 20:27 ` [Xen-devel] " Tamas K Lengyel
2019-05-09 18:19 ` Stefano Stabellini
2019-05-09 18:19 ` [Xen-devel] " Stefano Stabellini
2019-05-10 13:21 ` Jan Beulich
2019-05-10 13:21 ` [Xen-devel] " Jan Beulich
2019-05-10 13:27 ` Andrew Cooper
2019-05-10 13:27 ` [Xen-devel] " Andrew Cooper
2019-05-10 13:34 ` Julien Grall
2019-05-10 13:34 ` [Xen-devel] " Julien Grall
2019-05-10 13:41 ` Jan Beulich
2019-05-10 13:41 ` [Xen-devel] " Jan Beulich
2019-05-10 13:46 ` Julien Grall
2019-05-10 13:46 ` [Xen-devel] " Julien Grall
2019-05-10 14:02 ` Jan Beulich
2019-05-10 14:02 ` [Xen-devel] " Jan Beulich
2019-05-10 14:05 ` Andrew Cooper
2019-05-10 14:05 ` [Xen-devel] " Andrew Cooper
2019-05-10 14:08 ` Julien Grall
2019-05-10 14:08 ` [Xen-devel] " Julien Grall
2019-05-10 14:09 ` Andrew Cooper
2019-05-10 14:09 ` [Xen-devel] " Andrew Cooper
2019-05-10 14:14 ` Jan Beulich
2019-05-10 14:14 ` [Xen-devel] " Jan Beulich
2019-05-10 14:27 ` Andrew Cooper [this message]
2019-05-10 14:27 ` Andrew Cooper
2019-05-24 16:24 ` George Dunlap
2019-05-24 16:24 ` [Xen-devel] " George Dunlap
2019-05-29 16:27 ` Julien Grall
2019-05-29 16:27 ` [Xen-devel] " Julien Grall
2019-05-29 16:29 ` George Dunlap
2019-05-29 16:29 ` [Xen-devel] " George Dunlap
2019-05-24 16:35 ` George Dunlap
2019-05-24 16:35 ` [Xen-devel] " George Dunlap
2019-05-07 15:14 ` [PATCH 14/14] xen/mm: Provide dummy M2P-related helpers when !CONFIG_HAVE_M2P Julien Grall
2019-05-07 15:14 ` [Xen-devel] " Julien Grall
2019-05-09 18:20 ` Stefano Stabellini
2019-05-09 18:20 ` [Xen-devel] " Stefano Stabellini
2019-05-10 13:28 ` Jan Beulich
2019-05-10 13:28 ` [Xen-devel] " Jan Beulich
2019-05-10 13:29 ` Julien Grall
2019-05-10 13:29 ` [Xen-devel] " Julien Grall
2019-05-10 13:37 ` Jan Beulich
2019-05-10 13:37 ` [Xen-devel] " Jan Beulich
2019-05-10 13:38 ` Julien Grall
2019-05-10 13:38 ` [Xen-devel] " Julien Grall
2019-05-24 16:51 ` George Dunlap
2019-05-24 16:51 ` [Xen-devel] " George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dd02ece-4d2c-0600-4078-f3dde8d7d5ab@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tamas@tklengyel.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.