From: kgene@kernel.org
To: "'Vivek Gautam'" <gautam.vivek@samsung.com>, linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, gregkh@linuxfoundation.org,
balbi@ti.com, grant.likely@secretlab.ca, rob.herring@calxeda.com,
sylvester.nawrocki@gmail.com, tomasz.figa@gmail.com,
av.tikhomirov@samsung.com, dianders@chromium.org,
p.paneri@samsung.com
Subject: RE: [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250
Date: Tue, 12 Feb 2013 22:31:00 -0800 [thread overview]
Message-ID: <1e3101ce09b3$b2e178c0$18a46a40$@kernel.org> (raw)
In-Reply-To: <1360068256-19602-1-git-send-email-gautam.vivek@samsung.com>
Vivek Gautam wrote:
>
> Based on 'usb-next'
>
> Changes from v4:
> - Modifying function names and driver names to follow a common
> naming convention.
> "usb2phy" for samsung-usb2phy driver
> "usb3phy" for samsung-usb3phy driver
> - Changing file names "samsung-usb2.c" to "samsung-usb2phy.c" and,
> "samsung-usb3.c" to "samsung-usb3phy.c"
> - Removing dependencies for SAMSUNG_USB2PHY and
> SAMSUNG_USB3PHY.
> - Arranging SAMSUNG_USB2PHY and SAMSUNG_USB3PHY to select
> SAMSUNG_USBPHY,
> which is the usb-phy helper driver.
>
> Vivek Gautam (2):
> usb: phy: samsung: Common out the generic stuff
> usb: phy: samsung: Add PHY support for USB 3.0 controller
>
> drivers/usb/phy/Kconfig | 25 +-
> drivers/usb/phy/Makefile | 2 +
> drivers/usb/phy/samsung-usb2phy.c | 511
> ++++++++++++++++++++++++++
> drivers/usb/phy/samsung-usb3phy.c | 349 ++++++++++++++++++
> drivers/usb/phy/samsung-usbphy.c | 717
+------------------------------------
> drivers/usb/phy/samsung-usbphy.h | 328 +++++++++++++++++
> 6 files changed, 1219 insertions(+), 713 deletions(-)
> create mode 100644 drivers/usb/phy/samsung-usb2phy.c
> create mode 100644 drivers/usb/phy/samsung-usb3phy.c
> create mode 100644 drivers/usb/phy/samsung-usbphy.h
>
> --
> 1.7.6.5
For now, looks good to me, and if any enhancement is required, it can be
done next time.
Felipe, please go ahead with my ack :-)
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks.
- Kukjin
next prev parent reply other threads:[~2013-02-13 6:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 12:44 [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250 Vivek Gautam
2013-02-05 12:44 ` Vivek Gautam
2013-02-05 12:44 ` [PATCH v5 1/2] usb: phy: samsung: Common out the generic stuff Vivek Gautam
2013-02-05 12:44 ` Vivek Gautam
2013-02-05 12:44 ` [PATCH v5 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller Vivek Gautam
2013-02-13 6:31 ` kgene [this message]
2013-02-13 8:32 ` [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250 Felipe Balbi
2013-02-13 8:32 ` Felipe Balbi
2013-02-13 9:09 ` Vivek Gautam
2013-02-27 10:48 ` [PATCH] usb: phy: samsung: let it be built as a module Felipe Balbi
2013-02-27 12:01 ` Vivek Gautam
2013-02-27 12:13 ` Felipe Balbi
2013-02-27 12:17 ` Vivek Gautam
2013-02-27 12:24 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1e3101ce09b3$b2e178c0$18a46a40$@kernel.org' \
--to=kgene@kernel.org \
--cc=av.tikhomirov@samsung.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dianders@chromium.org \
--cc=gautam.vivek@samsung.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.paneri@samsung.com \
--cc=rob.herring@calxeda.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.