From: Vivek Gautam <gautamvivek1987@gmail.com>
To: balbi@ti.com
Cc: Linux USB Mailing List <linux-usb@vger.kernel.org>,
kgene@kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] usb: phy: samsung: let it be built as a module
Date: Wed, 27 Feb 2013 17:47:29 +0530 [thread overview]
Message-ID: <CAFp+6iG18xWLY3Z77LUfCBrGhNMm5iHFE7xMCjo-TeJxhoT6jg@mail.gmail.com> (raw)
In-Reply-To: <20130227121334.GF8016@arwen.pp.htv.fi>
On Wed, Feb 27, 2013 at 5:43 PM, Felipe Balbi <balbi@ti.com> wrote:
> Hi,
>
> On Wed, Feb 27, 2013 at 05:31:53PM +0530, Vivek Gautam wrote:
>> Hi Felipe,
>>
>>
>> On Wed, Feb 27, 2013 at 4:18 PM, Felipe Balbi <balbi@ti.com> wrote:
>> > There's no reason not to allow samsung PHY
>> > drivers be built as modules. This patch changes
>> > Kconfig to allow that.
>> >
>> > Signed-off-by: Felipe Balbi <balbi@ti.com>
>> > ---
>> >
>> > Hi,
>> >
>> > I will take your patches but I'm planning to add this on top
>> > as there is no reason not to allow these drivers being built
>> > as modules.
>> >
>>
>> aargh !! my bad :-(
>> actually missed exporting the symbols in drivers/usb/phy/samsung-usbphy.c
>> Getting compile errors.
>> Shall i just update the patch [PATCH v5 0/2] Adding USB 3.0 DRD-phy
>> support for exynos5250
>> or send a separate patch on top so that you can squash this change
>> along with. ;-)
>
> there's still time to update the original. I'll drop all 3 patches for
> now (both of yours and mine).
>
Alright, i shall update the original patches and resend them after
adding this change for
EXPORT_SYMBOL_GPL() and also squashing your change for "modules".
--
Thanks & Regards
Vivek
next prev parent reply other threads:[~2013-02-27 12:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 12:44 [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250 Vivek Gautam
2013-02-05 12:44 ` Vivek Gautam
2013-02-05 12:44 ` [PATCH v5 1/2] usb: phy: samsung: Common out the generic stuff Vivek Gautam
2013-02-05 12:44 ` Vivek Gautam
2013-02-05 12:44 ` [PATCH v5 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller Vivek Gautam
2013-02-13 6:31 ` [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250 kgene
2013-02-13 8:32 ` Felipe Balbi
2013-02-13 8:32 ` Felipe Balbi
2013-02-13 9:09 ` Vivek Gautam
2013-02-27 10:48 ` [PATCH] usb: phy: samsung: let it be built as a module Felipe Balbi
2013-02-27 12:01 ` Vivek Gautam
2013-02-27 12:13 ` Felipe Balbi
2013-02-27 12:17 ` Vivek Gautam [this message]
2013-02-27 12:24 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFp+6iG18xWLY3Z77LUfCBrGhNMm5iHFE7xMCjo-TeJxhoT6jg@mail.gmail.com \
--to=gautamvivek1987@gmail.com \
--cc=balbi@ti.com \
--cc=kgene@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.