From: Kishon Vijay Abraham I <kishon@ti.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Roger Quadros <rogerq@ti.com>, <linux-omap@vger.kernel.org>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<nsekhar@ti.com>
Subject: Re: [PATCH 0/2] phy: ti-pipe3: Update PCIe PHY settings
Date: Wed, 18 Oct 2017 17:38:15 +0530 [thread overview]
Message-ID: <1f583d30-fdf4-e104-271c-8a36704cbaf2@ti.com> (raw)
In-Reply-To: <20171017193129.GM5641@bhelgaas-glaptop.roam.corp.google.com>
On Wednesday 18 October 2017 01:01 AM, Bjorn Helgaas wrote:
> On Mon, Oct 09, 2017 at 02:33:36PM +0530, Kishon Vijay Abraham I wrote:
>> This was supposed to only update ti-pipe3 PHY registers. However because
>> of the way the ti-pipe3 PHY, OCP2SCP and PCIe controller are connected
>> in dra7xx where
>>
>> PCIe controller --------------> ti-pipe3 PHY --------------> OCP2SCP
>> depends on depends on
>>
>> updating ti-pipe3 PHY registers results in an abort.
>>
>> Though the dependency between ti-pipe3 PHY and OCP2SCP is created
>> (OCP2SCP is parent of ti-pipe3 PHY), and enabling ti-pipe3 PHY clocks
>> should in turn enable OCP2SCP (with the help of pm_runtime framework),
>> this doesn't work in no_irq stage since pm_runtime is disabled during
>> no_irq stage. Since pci-dra7xx enables/initializes ti-pipe3 phy in
>> no_irq stage, OCP2SCP is not enabled resulting in an abort with ti-pipe3
>> PHY registers are accessed.
>>
>> In order to solve this a functional dependency is created between
>> PCIe and ti-pipe3 PHY so that PCIe is suspended before PHY/OCP2SCP
>> and resumed after PCIe PHY/OCP2SCP
>>
>> Kishon Vijay Abraham I (2):
>> PCI: dwc: dra7xx: Create functional dependency between PCIe and PHY
>
> s/PCI: dwc: dra7xx: Create functional dependency between PCIe and PHY/
> PCI: dra7xx: Create functional dependency between PCIe and PHY/
>
> Should these be merged together? If it makes sense for you to merge them
> together, here's my ack for the PCI piece:
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Yeah both should be merged together. I'll make the change you suggested, add
your Ack and merge myself.
Thanks
Kishon
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Roger Quadros <rogerq@ti.com>,
linux-omap@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, nsekhar@ti.com
Subject: Re: [PATCH 0/2] phy: ti-pipe3: Update PCIe PHY settings
Date: Wed, 18 Oct 2017 17:38:15 +0530 [thread overview]
Message-ID: <1f583d30-fdf4-e104-271c-8a36704cbaf2@ti.com> (raw)
In-Reply-To: <20171017193129.GM5641@bhelgaas-glaptop.roam.corp.google.com>
On Wednesday 18 October 2017 01:01 AM, Bjorn Helgaas wrote:
> On Mon, Oct 09, 2017 at 02:33:36PM +0530, Kishon Vijay Abraham I wrote:
>> This was supposed to only update ti-pipe3 PHY registers. However because
>> of the way the ti-pipe3 PHY, OCP2SCP and PCIe controller are connected
>> in dra7xx where
>>
>> PCIe controller --------------> ti-pipe3 PHY --------------> OCP2SCP
>> depends on depends on
>>
>> updating ti-pipe3 PHY registers results in an abort.
>>
>> Though the dependency between ti-pipe3 PHY and OCP2SCP is created
>> (OCP2SCP is parent of ti-pipe3 PHY), and enabling ti-pipe3 PHY clocks
>> should in turn enable OCP2SCP (with the help of pm_runtime framework),
>> this doesn't work in no_irq stage since pm_runtime is disabled during
>> no_irq stage. Since pci-dra7xx enables/initializes ti-pipe3 phy in
>> no_irq stage, OCP2SCP is not enabled resulting in an abort with ti-pipe3
>> PHY registers are accessed.
>>
>> In order to solve this a functional dependency is created between
>> PCIe and ti-pipe3 PHY so that PCIe is suspended before PHY/OCP2SCP
>> and resumed after PCIe PHY/OCP2SCP
>>
>> Kishon Vijay Abraham I (2):
>> PCI: dwc: dra7xx: Create functional dependency between PCIe and PHY
>
> s/PCI: dwc: dra7xx: Create functional dependency between PCIe and PHY/
> PCI: dra7xx: Create functional dependency between PCIe and PHY/
>
> Should these be merged together? If it makes sense for you to merge them
> together, here's my ack for the PCI piece:
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Yeah both should be merged together. I'll make the change you suggested, add
your Ack and merge myself.
Thanks
Kishon
next prev parent reply other threads:[~2017-10-18 12:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 9:03 [PATCH 0/2] phy: ti-pipe3: Update PCIe PHY settings Kishon Vijay Abraham I
2017-10-09 9:03 ` Kishon Vijay Abraham I
2017-10-09 9:03 ` [PATCH 1/2] PCI: dwc: dra7xx: Create functional dependency between PCIe and PHY Kishon Vijay Abraham I
2017-10-09 9:03 ` Kishon Vijay Abraham I
2017-10-10 7:19 ` Roger Quadros
2017-10-10 7:19 ` Roger Quadros
2017-10-10 7:19 ` Roger Quadros
2017-10-10 7:42 ` Kishon Vijay Abraham I
2017-10-10 7:42 ` Kishon Vijay Abraham I
2017-10-10 7:59 ` Roger Quadros
2017-10-10 7:59 ` Roger Quadros
2017-10-10 7:59 ` Roger Quadros
2017-10-18 12:12 ` Kishon Vijay Abraham I
2017-10-18 12:12 ` Kishon Vijay Abraham I
2017-10-19 9:46 ` Roger Quadros
2017-10-19 9:46 ` Roger Quadros
2017-10-09 9:03 ` [PATCH 2/2] phy: ti-pipe3: Update pcie phy settings Kishon Vijay Abraham I
2017-10-09 9:03 ` Kishon Vijay Abraham I
2017-10-17 19:31 ` [PATCH 0/2] phy: ti-pipe3: Update PCIe PHY settings Bjorn Helgaas
2017-10-18 12:08 ` Kishon Vijay Abraham I [this message]
2017-10-18 12:08 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f583d30-fdf4-e104-271c-8a36704cbaf2@ti.com \
--to=kishon@ti.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.