All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Kevin Hilman <khilman@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-clk@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] clk: meson: Kconfig: fix dependency for G12A
Date: Thu, 19 Nov 2020 17:47:14 +0100	[thread overview]
Message-ID: <1jzh3d8fal.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20201118190930.34352-1-khilman@baylibre.com>


On Wed 18 Nov 2020 at 20:09, Kevin Hilman <khilman@baylibre.com> wrote:

> When building only G12A, ensure that VID_PLL_DIV clock driver is
> selected, otherwise results in this build error:
>
> ERROR: modpost: "meson_vid_pll_div_ro_ops" [drivers/clk/meson/g12a.ko] undefined!
>
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>

Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")

> ---
>  drivers/clk/meson/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> index 034da203e8e0..9a8a548d839d 100644
> --- a/drivers/clk/meson/Kconfig
> +++ b/drivers/clk/meson/Kconfig
> @@ -110,6 +110,7 @@ config COMMON_CLK_G12A
>  	select COMMON_CLK_MESON_AO_CLKC
>  	select COMMON_CLK_MESON_EE_CLKC
>  	select COMMON_CLK_MESON_CPU_DYNDIV
> +	select COMMON_CLK_MESON_VID_PLL_DIV
>  	select MFD_SYSCON
>  	help
>  	  Support for the clock controller on Amlogic S905D2, S905X2 and S905Y2


WARNING: multiple messages have this Message-ID (diff)
From: Jerome Brunet <jbrunet@baylibre.com>
To: Kevin Hilman <khilman@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: meson: Kconfig: fix dependency for G12A
Date: Thu, 19 Nov 2020 17:47:14 +0100	[thread overview]
Message-ID: <1jzh3d8fal.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20201118190930.34352-1-khilman@baylibre.com>


On Wed 18 Nov 2020 at 20:09, Kevin Hilman <khilman@baylibre.com> wrote:

> When building only G12A, ensure that VID_PLL_DIV clock driver is
> selected, otherwise results in this build error:
>
> ERROR: modpost: "meson_vid_pll_div_ro_ops" [drivers/clk/meson/g12a.ko] undefined!
>
> Signed-off-by: Kevin Hilman <khilman@baylibre.com>

Fixes: 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")

> ---
>  drivers/clk/meson/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> index 034da203e8e0..9a8a548d839d 100644
> --- a/drivers/clk/meson/Kconfig
> +++ b/drivers/clk/meson/Kconfig
> @@ -110,6 +110,7 @@ config COMMON_CLK_G12A
>  	select COMMON_CLK_MESON_AO_CLKC
>  	select COMMON_CLK_MESON_EE_CLKC
>  	select COMMON_CLK_MESON_CPU_DYNDIV
> +	select COMMON_CLK_MESON_VID_PLL_DIV
>  	select MFD_SYSCON
>  	help
>  	  Support for the clock controller on Amlogic S905D2, S905X2 and S905Y2


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2020-11-19 16:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18 19:09 [PATCH] clk: meson: Kconfig: fix dependency for G12A Kevin Hilman
2020-11-18 19:09 ` Kevin Hilman
2020-11-19 16:47 ` Jerome Brunet [this message]
2020-11-19 16:47   ` Jerome Brunet
2020-11-19 16:51   ` Jerome Brunet
2020-11-19 16:51     ` Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1jzh3d8fal.fsf@starbuckisacylon.baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.