Re: v3: KVM: support for 'count' in CPUID functions 4, 0xb and 0xd

From: Amit Shah <amit.shah@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, aliguori@us.ibm.com
Subject: Re: v3: KVM: support for 'count' in CPUID functions 4, 0xb and 0xd
Date: Thu, 15 Jan 2009 15:58:57 +0530	[thread overview]
Message-ID: <20090115102857.GA25534@amit-x200.pnq.redhat.com> (raw)
In-Reply-To: <496F07C1.6050605@redhat.com>

On Thu, Jan 15, 2009 at 11:54:09AM +0200, Avi Kivity wrote:
> Amit Shah wrote:
>> These patches add support for cpuid functions that take a 'count' parameter
>> in addition to the function number. With these patches, KVM can run a VM
>> started with a newer CPU type (coreduo, core2duo). These patches also pave
>> way for a "host" CPU type, where we could pass the CPU type of the current
>> host to the VM.
>>
>> v3 uses the as-yet unused KVM_SET_CPUID2 interface, which was written to
>> support this functionality. Since we rely on kernel versions 2.6.25 at a
>> minimum for KVM and the SET_CPUID2 interface was introduced in 2.6.25, we're
>> safe with this.
>
> Looks good.  Note that function 2 also needs special treatment.

Yes; I'll add that support as well.

Thanks,
Amit