From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Alexandre Rostovtsev <tetromino@gmail.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lenovo-sl-laptop : driver for review
Date: Mon, 16 Feb 2009 15:18:09 +0000 [thread overview]
Message-ID: <20090216151809.GA4724@srcf.ucam.org> (raw)
In-Reply-To: <20090216025918.66d7a466@leftboat.lan>
On Mon, Feb 16, 2009 at 02:59:18AM -0500, Alexandre Rostovtsev wrote:
> +Fn F9 (eject): KEY_EJECTCD (161)
No - this is a dock eject key, not a CD eject key.
> +Fn F12 (hibernate): KEY_SUSPEND (205)
> +/sys/devices/platform/lenovo-sl-laptop/rfkill/rfkill*/
> + The bluetooth rfkill. state is the switch state (0 for bluetooth off,
> + 1 for bluetooth on).
> + Note that in case future versions of the driver add other rfkill switches,
> + userspace programs should check that the rfkill name is lensl_bluetooth_sw
Surely they should just be checking the rfkill type?
> +control_backlight:
> + If this parameter is set to 1, this driver will intercept brightness keys
> + (Fn+Home and Fn+End) and control the backlight brightness. This feature is
> + useful because the default ACPI video driver currently has poor support
> + for the Lenovo SL series. If you enable this feature, you should add
> + acpi_backlight=vendor
Please don't do that - the kernel shouldn't be consuming the brightness
events itself, that should be left up to userspace. The ACPI video
driver is broken in this respect.
> +static struct device_attribute dev_attr_bluetooth_enable =
> + __ATTR(bluetooth_enable, S_IWUSR | S_IRUGO,
> + bluetooth_enable_show, bluetooth_enable_store);
You support rfkill, so I'm not sure there's a benefit in exposing the
same functionality via a custom sysfs node.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-02-16 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 7:59 [PATCH] lenovo-sl-laptop : driver for review Alexandre Rostovtsev
2009-02-16 15:18 ` Matthew Garrett [this message]
2009-02-20 3:00 ` Henrique de Moraes Holschuh
2009-02-16 15:21 ` Matthew Garrett
2009-02-27 13:27 ` Pavel Machek
2009-02-28 14:37 ` Henrique de Moraes Holschuh
2009-03-10 11:22 ` Pavel Machek
2009-03-10 11:34 ` Henrique de Moraes Holschuh
2009-03-10 14:12 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090216151809.GA4724@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tetromino@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.