Re: [PATCH] lenovo-sl-laptop : driver for review

From: Pavel Machek <pavel@ucw.cz>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Alexandre Rostovtsev <tetromino@gmail.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lenovo-sl-laptop : driver for review
Date: Tue, 10 Mar 2009 15:12:38 +0100	[thread overview]
Message-ID: <20090310141238.GC1374@ucw.cz> (raw)
In-Reply-To: <20090310113419.GC371@khazad-dum.debian.net>

Hi!

> > > > That's quite a lot of code for verbatim copy; create shared helper?
> > > 
> > > Yeah, I am game.  But let's do it later on and not delay anything because of
> > > it, please.  I will start breaking thinkpad-acpi into multiple source files,
> > > and after that is done (should take a while, thinkpad-acpi is a big module
> > > with a LOT of subdriver interdependencies) we can look for the best way to
> > > reduce code duplication.
> > 
> > Well,  this monolith is quite long/hard to review. IMO it should be
> > split to make review easy. 
> 
> thinkpad-sl could be split, yes.  But if you guys are going to wait for
> thinkpad-acpi to be split _as well_ to do some common-path merging, THAT is
> going to take quite a while...

I guess waiting is not neccessary; plus having split thinkpad-sl
driver should make common-path merging easier for you later...

> An alternative is to submit a minimal thinkpad-sl, then add features to it
> patch-by-patch.  That makes reviewing it easier.

Yeah but as we are moving away from mega-driver, anyway, ...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html