Re: [PATCH] ARM: OMAP: Allow I2C bus driver to be compiled as a module

From: Tony Lindgren <tony@atomide.com>
To: Otto Solares <solca@guug.org>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: Allow I2C bus driver to be compiled as a module
Date: Wed, 18 Feb 2009 15:59:56 -0800	[thread overview]
Message-ID: <20090218235956.GC31436@atomide.com> (raw)
In-Reply-To: <20090218234327.GM24800@guug.org>

* Otto Solares <solca@guug.org> [090218 15:43]:
> On Wed, Feb 18, 2009 at 03:40:29PM -0800, Tony Lindgren wrote:
> > * Jarkko Nikula <jhnikula@gmail.com> [090218 01:42]:
> > > On Wed, 18 Feb 2009 11:22:18 +0200
> > > Aaro Koskinen <Aaro.Koskinen@nokia.com> wrote:
> > > 
> > > > Fixes a linker error when OMAP I2C bus driver is compiled as a module:
> > > > 
> > > >    ERROR: "i2c_register_board_info" [arch/arm/plat-omap/i2c.ko]
> > > > undefined!
> > > > 
> > > > The I2C utility functions used for board initialization should be
> > > > always built-in.
> > > > 
> > > > Signed-off-by: Aaro Koskinen <Aaro.Koskinen@nokia.com>
> > > > ---
> > > >  arch/arm/plat-omap/Makefile              |    3 ++-
> > > >  arch/arm/plat-omap/include/mach/common.h |    2 +-
> > > >  2 files changed, 3 insertions(+), 2 deletions(-)
> > > > 
> > > Acked-by: Jarkko Nikula  <jarkko.nikula@nokia.com>
> > 
> > Applying to linux-omap and omap-fixes.
> 
> Just curious: what about omap-2.6.28?

Heh, OK pushed there too :) I think we should close that branch soon
as 2.6.29 is fast approaching..

Tony