Re: [PATCH 1/1] Allow I2C_OMAP to compile as a module.

From: Felipe Balbi <me@felipebalbi.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
	Jarkko Nikula <jarkko.nikula@nokia.com>,
	"Shargorodsky Atal (EXT-Teleca/Helsinki)"
	<ext-atal.shargorodsky@nokia.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/1] Allow I2C_OMAP to compile as a module.
Date: Sun, 15 Feb 2009 14:47:15 -0600	[thread overview]
Message-ID: <61a7513ea2a517e5866e1ca10d8f7690@felipebalbi.com> (raw)
In-Reply-To: <20090215213559.0a6653a1.jhnikula@gmail.com>

Hi,

On Sun, 15 Feb 2009 21:35:59 +0200, Jarkko Nikula <jhnikula@gmail.com>
wrote:
> On Fri, 13 Feb 2009 14:21:00 -0800
> Tony Lindgren <tony@atomide.com> wrote:
> 
>> > Subject needs a "ARM: OMAP: " prefix, otherwise ok from me.
>> >
>> > Acked-by: Jarkko Nikula <jarkko.nikula@nokia.com>
>>
>> Sounds like a fix, except I posted a shorter version of the patch that
>> should do the trick (untested). Attached here too for reference.
>>
> Tony's version does not fix the issue since obj-$(CONFIG_I2C_OMAP) below
> still tries to compile arch/arm/plat-omap/i2c.c as a module.
> 
> -obj-$(CONFIG_I2C_OMAP) += i2c.o
> +
> +ifneq ($(CONFIG_I2C_OMAP),)
> +	obj-$(CONFIG_I2C_OMAP)		+= i2c.o
> +endif
> 
> Problem was that drivers/i2c/busses/i2c-omap.c can be module but
> arch/arm/plat-omap/i2c.c cannot since it is for early board
> initialization code.

why don't you:

-obj-$(CONFIG_I2C_OMAP) += i2c.o
+obj-y			+= i2c.o

It's quite possible that we will need i2c
anyways in most boards. And for the ones who
won't need, it's just a few extra bytes
to kernel image. I guess it should be
ok to always build i2c utilities.

-- 
Best Regards,

Felipe Balbi
http://blog.felipebalbi.com
me@felipebalbi.com