From: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
To: felipe.contreras@gmail.com, h-kanigeri2@ti.com
Cc: linux-omap@vger.kernel.org, felipe.contrers@nokia.com,
ameya.palande@nokia.com
Subject: Re: [PATCH] dspbridge: wait less and check the mailbox more
Date: Sun, 22 Feb 2009 07:21:37 +0200 (EET) [thread overview]
Message-ID: <20090222.072137.189714248.Hiroshi.DOYU@nokia.com> (raw)
In-Reply-To: <1235171057-7859-1-git-send-email-felipe.contreras@gmail.com>
Hi Felipe,
From: ext Felipe Contreras <felipe.contreras@gmail.com>
Subject: [PATCH] dspbridge: wait less and check the mailbox more
Date: Sat, 21 Feb 2009 00:04:17 +0100
> From: Felipe Contreras <felipe.contrers@nokia.com>
>
> Profiling showed the __delay function is called a lot; checking the mbox
> more often seems to decrease the usage by 2/3 according to OProfile.
Good finding.
> The changes are based on 'arch/arm/plat-omap/mailbox.c'. Tested on OMAP3430.
>
> Also, remove HW_MBOX_IsFull since it's not used by anybody.
Woundn't it be better to split this one into some logical parts,
tunning up part(decreasing delay) and cleanup part(the others)?
Home brewed MACROs themselves like UTIL_Wait() are basically evil from
kernel source readibility perspective, but keeping consistency within
specific module may be more important and this kind of cleaning up
would be better to be done at onece over a module, in separate
patches.
Hari,
Any comment? if it's ok, please merge it or newer ones into o-z as
well.
Hiroshi DOYU
next prev parent reply other threads:[~2009-02-22 5:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-20 23:04 [PATCH] dspbridge: wait less and check the mailbox more Felipe Contreras
2009-02-22 5:21 ` Hiroshi DOYU [this message]
2009-02-22 6:46 ` Felipe Contreras
2009-02-22 9:32 ` [PATCH v2 1/4] dsp-bridge: remove unnecessary comments in util.h Felipe Contreras
2009-02-22 9:32 ` [PATCH v2 2/4] dsp-bridge: remove UTIL_Wait wrapper Felipe Contreras
2009-02-22 9:32 ` [PATCH v2 3/4] dsp-bridge: cleanup and remove HW_MBOX_IsFull Felipe Contreras
2009-02-22 9:32 ` [PATCH v2 4/4] dsp-bridge: wait less and check the mailbox more Felipe Contreras
2009-02-23 22:06 ` [PATCH v2 3/4] dsp-bridge: cleanup and remove HW_MBOX_IsFull Kanigeri, Hari
2009-02-23 22:22 ` Felipe Contreras
2009-02-23 22:22 ` [PATCH v2 2/4] dsp-bridge: remove UTIL_Wait wrapper Kanigeri, Hari
2009-02-22 11:35 ` [PATCH v2 1/4] dsp-bridge: remove unnecessary comments in util.h Hiroshi DOYU
2009-03-04 18:11 [PATCH] DSPBRIDGE: Remove SEEK_* redefinitions Fernando Guzman Lugo
2009-03-04 18:11 ` [PATCH] DSPBRIDGE: Removes wrappers funtions of readl and writel Fernando Guzman Lugo
2009-03-04 18:11 ` [PATCH] DSPBRIDGE: Change address resources to void __iomem * Fernando Guzman Lugo
2009-03-04 18:11 ` [PATCH] DSPBRIDGE: Remove variables not used in cfgdefs.h Fernando Guzman Lugo
2009-03-04 18:11 ` [PATCH] DSPBRIDGE: cleanup of HW_MBOX_IsFull function Fernando Guzman Lugo
2009-03-04 18:11 ` [PATCH] DSPBRIDGE: wait less and check the mailbox more Fernando Guzman Lugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090222.072137.189714248.Hiroshi.DOYU@nokia.com \
--to=hiroshi.doyu@nokia.com \
--cc=ameya.palande@nokia.com \
--cc=felipe.contreras@gmail.com \
--cc=felipe.contrers@nokia.com \
--cc=h-kanigeri2@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.