Re: [PATCH v2 3/4] dsp-bridge: cleanup and remove HW_MBOX_IsFull

From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Kanigeri, Hari" <h-kanigeri2@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
	"ameya.palande@nokia.com" <ameya.palande@nokia.com>
Subject: Re: [PATCH v2 3/4] dsp-bridge: cleanup and remove HW_MBOX_IsFull
Date: Tue, 24 Feb 2009 00:22:45 +0200	[thread overview]
Message-ID: <94a0d4530902231422y6b044cb2qe686c7e106ff2e5e@mail.gmail.com> (raw)
In-Reply-To: <8F7AF80515AF0D4D93307E594F3CB40E211807CE@dlee03.ent.ti.com>

On Tue, Feb 24, 2009 at 12:06 AM, Kanigeri, Hari <h-kanigeri2@ti.com> wrote:
> Hi Felipe,
>
>> HW_MBOX_IsFull has many convoluted macros and is used only once. Clean
>> it up so it's easier to see what it's actually doing.
>
> -- Is this the reason you added a new function that checks if fifo is full or is there any issue with the existing function ?

fifo_full should do exactly the same as HW_MBOX_IsFulll, I just
removed all the macros and used __raw_readl instead. I could have
removed the fifo_full function and do the __raw_readl directly, but I
thought this way it was more readable.

The main reason I cleaned the function was for performance reasons;
remove unnecessary checks, extra steps, and the function call (now
inline).

-- 
Felipe Contreras