Re: [PATCH] sh: maple: Update the maple bus driver to support block reads and writes

From: Paul Mundt <lethal@linux-sh.org>
To: Adrian McMenamin <adrian@newgolddream.dyndns.info>
Cc: Greg KH <greg@kroah.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input <linux-input@vger.kernel.org>,
	linux-sh <linux-sh@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: maple: Update the maple bus driver to support block reads and writes
Date: Fri, 27 Feb 2009 07:06:34 +0000	[thread overview]
Message-ID: <20090227070634.GC28802@linux-sh.org> (raw)
In-Reply-To: <1234642605.6609.17.camel@localhost.localdomain>

On Sat, Feb 14, 2009 at 08:16:45PM +0000, Adrian McMenamin wrote:
> On Sat, 2009-02-14 at 20:06 +0000, Adrian McMenamin wrote:
> > Greg,
> > 
> > This patch updates the maple bus to support asynchronous block reads and
> > writes as well as generally improving the quality of the code and
> > supporting concurrency (all needed to support the Dreamcast visual
> > memory unit - a driver will also be posted for that).
> > 
> > I have posted versions of this before but am here following the patch
> > grouping suggested and have also tested this code and unlike earlier
> > versions it shows no signs of suffering from race conditions - so I hope
> > you will be happy to queue it for inclusion.
> > 
> > Changes in the bus driver necessitate some changes in the two maple bus
> > input drivers that are currently in mainline.
> > 
> > (Maple is SEGA's proprietary serial bus for the Dreamcast. It is capable
> > of comm speeds of up to 2Mbs.)
> > 
> > As well as supporting block reads and writes this code clean up removes
> > some poor handling of locks, uses an atomic status variable to serialise
> > access to devices and more robusly handles the general performance
> > problems of the bus.
> > 
> Apologies, some of the VMU patch slipped into that. Here is a completely
> clean version.
> 
> Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>

Applied, thanks.