From: Jeremy Allison <jra@samba.org>
To: simo <idra@samba.org>
Cc: Steve French <smfrench@gmail.com>,
Jeff Layton <jlayton@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"linux-cifs-client@lists.samba.org"
<linux-cifs-client@lists.samba.org>,
samba-technical <samba-technical@lists.samba.org>
Subject: Re: [CIFS] [PATCH] warn on EINVAL error on posix open, and turn off posix open if server broken for this call
Date: Wed, 4 Mar 2009 11:29:07 -0800 [thread overview]
Message-ID: <20090304192907.GB9885@samba1> (raw)
In-Reply-To: <1236194670.22692.0.camel@pico.li.ssimo.org>
On Wed, Mar 04, 2009 at 02:24:30PM -0500, simo wrote:
> On Wed, 2009-03-04 at 13:02 -0600, Steve French wrote:
> > Attached is patch to workaround the problem found in posix open to
> > Samba versions 3.3.1 and earlier
> > (create works, but open would fail with invalid parameter) - it
> > disables requests to try posix open after
> > a first failure.
>
> Why do you completely disable posix opens ?
> Wouldn't it make sense to reopen only when it fails ?
> After all when you create new files it works correctly.
No, you don't want to do this complexity. Much more
simple to just disable that call if you're running
against a buggy server.
Jeremy.
next prev parent reply other threads:[~2009-03-04 19:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 19:02 [CIFS] [PATCH] warn on EINVAL error on posix open, and turn off posix open if server broken for this call Steve French
2009-03-04 19:24 ` simo
2009-03-04 19:29 ` Jeremy Allison [this message]
2009-03-04 19:34 ` [linux-cifs-client] " Steve French
2009-03-04 19:30 ` Steve French
2009-03-04 20:36 ` simo
2009-03-04 19:29 ` Shirish Pargaonkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090304192907.GB9885@samba1 \
--to=jra@samba.org \
--cc=idra@samba.org \
--cc=jlayton@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.