Re: [linux-cifs-client] [CIFS] [PATCH] warn on EINVAL error on posix open, and turn off posix open if server broken for this call

From: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
To: Steve French <smfrench@gmail.com>
Cc: Jeremy Allison <jra@samba.org>, Jeff Layton <jlayton@redhat.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"linux-cifs-client@lists.samba.org"
	<linux-cifs-client@lists.samba.org>,
	samba-technical <samba-technical@lists.samba.org>
Subject: Re: [linux-cifs-client] [CIFS] [PATCH] warn on EINVAL error on posix open, and turn off posix open if server broken for this call
Date: Wed, 4 Mar 2009 13:29:38 -0600	[thread overview]
Message-ID: <4a4634330903041129w2c65011fvb048c45cf94fa896@mail.gmail.com> (raw)
In-Reply-To: <524f69650903041102v415a807m8a93f0462458a51@mail.gmail.com>

On Wed, Mar 4, 2009 at 1:02 PM, Steve French <smfrench@gmail.com> wrote:
> Attached is patch to workaround the problem found in posix open to
> Samba versions 3.3.1 and earlier
> (create works, but open would fail with invalid parameter) - it
> disables requests to try posix open after
> a first failure.
>
>
>
> --
> Thanks,
>
> Steve
>
> _______________________________________________
> linux-cifs-client mailing list
> linux-cifs-client@lists.samba.org
> https://lists.samba.org/mailman/listinfo/linux-cifs-client
>
>

Steve,

I think I will have to apply similar logic in cifs_lookup for lookup
intents i.e. when
cifs_posix_open fails with the same return code, follow the usual lookup path, I
do not have to disable posix opens though as Simo said.
Would be wasting a transaction in the process though in case of samba servers
that have this problem.

Regards,

Shirish