All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>,
	qemu-devel@nongnu.org, Carsten Otte <cotte@de.ibm.com>,
	kvm@vger.kernel.org, Rusty Russell <rusty@rustcor>
Subject: [PATCH 02/11] qemu: capability bits in pci save/restore
Date: Mon, 25 May 2009 15:25:11 +0300	[thread overview]
Message-ID: <20090525122511.GC5046__22942.8238155835$1243254807$gmane$org@redhat.com> (raw)
In-Reply-To: <cover.1243253205.git.mst@redhat.com>

Add support for capability bits in save/restore for pci.
These will be used for MSI, where the capability might
be present or not as requested by user, which does not
map well into a single version number.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/pci.c |   14 ++++++++++++--
 hw/pci.h |    4 ++++
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/hw/pci.c b/hw/pci.c
index 1e70e46..5dcfb4e 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -127,12 +127,15 @@ int pci_bus_num(PCIBus *s)
 
 void pci_device_save(PCIDevice *s, QEMUFile *f)
 {
+    int version = s->cap_present ? 3 : 2;
     int i;
 
-    qemu_put_be32(f, 2); /* PCI device version */
+    qemu_put_be32(f, version); /* PCI device version */
     qemu_put_buffer(f, s->config, 256);
     for (i = 0; i < 4; i++)
         qemu_put_be32(f, s->irq_state[i]);
+    if (version >= 3)
+        qemu_put_be32(f, s->cap_present);
 }
 
 int pci_device_load(PCIDevice *s, QEMUFile *f)
@@ -141,7 +144,7 @@ int pci_device_load(PCIDevice *s, QEMUFile *f)
     int i;
 
     version_id = qemu_get_be32(f);
-    if (version_id > 2)
+    if (version_id > 3)
         return -EINVAL;
     qemu_get_buffer(f, s->config, 256);
     pci_update_mappings(s);
@@ -149,6 +152,13 @@ int pci_device_load(PCIDevice *s, QEMUFile *f)
     if (version_id >= 2)
         for (i = 0; i < 4; i ++)
             s->irq_state[i] = qemu_get_be32(f);
+    if (version_id >= 3)
+        s->cap_present = qemu_get_be32(f);
+    else
+        s->cap_present = 0;
+
+    if (s->cap_present & ~s->cap_supported)
+        return -EINVAL;
 
     return 0;
 }
diff --git a/hw/pci.h b/hw/pci.h
index c0c2380..9139504 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -178,6 +178,10 @@ struct PCIDevice {
 
     /* Current IRQ levels.  Used internally by the generic PCI code.  */
     int irq_state[4];
+
+    /* Capability bits for save/load */
+    uint32_t cap_supported;
+    uint32_t cap_present;
 };
 
 PCIDevice *pci_register_device(PCIBus *bus, const char *name,
-- 
1.6.3.1.56.g79e1.dirty

  parent reply	other threads:[~2009-05-25 12:25 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1243253205.git.mst@redhat.com>
2009-05-25 12:12 ` [PATCHv2] qemu: make default_write_config use mask table Michael S. Tsirkin
2009-05-25 12:12 ` Michael S. Tsirkin
2009-05-25 12:12   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:24 ` [PATCH 01/11] " Michael S. Tsirkin
2009-05-25 12:24   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:24 ` Michael S. Tsirkin
2009-05-25 12:25 ` [PATCH 02/11] qemu: capability bits in pci save/restore Michael S. Tsirkin
2009-05-25 12:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:25 ` Michael S. Tsirkin [this message]
2009-05-25 12:25 ` [PATCH 03/11] qemu: add routines to manage PCI capabilities Michael S. Tsirkin
2009-05-25 12:25 ` Michael S. Tsirkin
2009-05-25 12:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-26  8:49   ` Isaku Yamahata
2009-05-26  8:49     ` Isaku Yamahata
2009-05-26  9:22     ` Michael S. Tsirkin
2009-05-26  9:22     ` Michael S. Tsirkin
2009-05-26  9:22       ` Michael S. Tsirkin
2009-05-26  8:49   ` Isaku Yamahata
2009-05-26  9:30   ` [PATCH] qemu: fix pci_find_capability for multiple caps Michael S. Tsirkin
2009-05-26  9:30     ` Michael S. Tsirkin
2009-05-26  9:30     ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:25 ` [PATCH 04/11] qemu: helper routines for pci access Michael S. Tsirkin
2009-05-25 12:25 ` Michael S. Tsirkin
2009-05-25 12:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-26  2:33   ` Isaku Yamahata
2009-05-26  2:33     ` Isaku Yamahata
2009-05-26  6:41     ` Michael S. Tsirkin
2009-05-26  6:41       ` Michael S. Tsirkin
2009-05-26  8:07       ` Avi Kivity
2009-05-26  8:07         ` Avi Kivity
2009-05-26  8:49         ` Michael S. Tsirkin
2009-05-26  8:49           ` Michael S. Tsirkin
2009-05-26  8:49         ` Michael S. Tsirkin
2009-05-26  8:07       ` Avi Kivity
2009-05-26  6:41     ` Michael S. Tsirkin
2009-05-26  2:33   ` Isaku Yamahata
2009-05-25 12:25 ` [PATCH 05/11] qemu: MSI-X support functions Michael S. Tsirkin
2009-05-25 12:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-06-09 23:19   ` Paul Brook
2009-06-09 23:19     ` Paul Brook
2009-06-10  9:46     ` Michael S. Tsirkin
2009-06-10  9:46     ` Michael S. Tsirkin
2009-06-10  9:46       ` Michael S. Tsirkin
2009-06-10 14:07       ` Paul Brook
2009-06-10 14:07         ` Paul Brook
2009-06-10 14:25         ` Michael S. Tsirkin
2009-06-10 14:25         ` Michael S. Tsirkin
2009-06-10 14:25           ` Michael S. Tsirkin
2009-06-10 14:39           ` Paul Brook
2009-06-10 14:39             ` Paul Brook
2009-06-10 14:47             ` Michael S. Tsirkin
2009-06-10 14:47             ` Michael S. Tsirkin
2009-06-10 14:47               ` Michael S. Tsirkin
2009-06-10 15:15               ` Paul Brook
2009-06-10 15:15                 ` Paul Brook
2009-06-10 15:52                 ` Michael S. Tsirkin
2009-06-10 15:52                 ` Michael S. Tsirkin
2009-06-10 15:52                   ` Michael S. Tsirkin
2009-06-10 16:08                   ` Paul Brook
2009-06-10 16:08                     ` Paul Brook
2009-06-10 16:26                     ` Michael S. Tsirkin
2009-06-10 16:26                       ` Michael S. Tsirkin
2009-06-10 16:46                       ` Paul Brook
2009-06-10 16:46                         ` Paul Brook
2009-06-10 17:03                         ` Michael S. Tsirkin
2009-06-10 17:03                           ` Michael S. Tsirkin
2009-06-10 17:30                           ` Paul Brook
2009-06-10 17:30                           ` Paul Brook
2009-06-10 17:30                             ` Paul Brook
2009-06-10 18:07                             ` Michael S. Tsirkin
2009-06-10 18:07                             ` Michael S. Tsirkin
2009-06-10 18:07                               ` Michael S. Tsirkin
2009-06-10 19:04                               ` Paul Brook
2009-06-10 19:04                                 ` Paul Brook
2009-06-11  8:29                                 ` Michael S. Tsirkin
2009-06-11  8:29                                 ` Michael S. Tsirkin
2009-06-11  8:29                                   ` Michael S. Tsirkin
2009-06-10 19:04                               ` Paul Brook
2009-06-10 17:03                         ` Michael S. Tsirkin
2009-06-10 16:46                       ` Paul Brook
2009-06-10 16:26                     ` Michael S. Tsirkin
2009-06-10 16:08                   ` Paul Brook
2009-06-10 15:15               ` Paul Brook
2009-06-10 14:39           ` Paul Brook
2009-06-10 14:07       ` Paul Brook
2009-06-09 23:19   ` Paul Brook
2009-05-25 12:25 ` Michael S. Tsirkin
2009-05-25 12:25 ` [PATCH 06/11] qemu: add flag to disable MSI-X by default Michael S. Tsirkin
2009-05-25 12:25 ` Michael S. Tsirkin
2009-05-25 12:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:25 ` [PATCH 07/11] qemu: minimal MSI/MSI-X implementation for PC Michael S. Tsirkin
2009-05-25 12:25   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:25 ` Michael S. Tsirkin
2009-05-25 12:26 ` [PATCH 08/11] qemu: add support for resizing regions Michael S. Tsirkin
2009-05-25 12:26   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:26 ` Michael S. Tsirkin
2009-05-25 12:26 ` [PATCH 09/11] qemu: virtio support for many interrupt vectors Michael S. Tsirkin
2009-05-25 12:26   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:26 ` Michael S. Tsirkin
2009-05-25 12:26 ` [PATCH 10/11] qemu: MSI-X support in virtio PCI Michael S. Tsirkin
2009-05-25 12:26   ` [Qemu-devel] " Michael S. Tsirkin
2009-05-25 12:26 ` Michael S. Tsirkin
2009-05-25 12:26 ` [PATCH 11/11] qemu: request 3 vectors in virtio-net Michael S. Tsirkin
2009-05-25 12:26 ` Michael S. Tsirkin
2009-05-25 12:26   ` [Qemu-devel] " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20090525122511.GC5046__22942.8238155835$1243254807$gmane$org@redhat.com' \
    --to=mst@redhat.com \
    --cc=avi@redhat.com \
    --cc=cotte@de.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcor \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.