From: "Michael S. Tsirkin" <mst@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org, avi@redhat.com, kvm@vger.kernel.org,
aliguori@us.ibm.com, kwolf@redhat.com
Subject: Re: [Qemu-devel] [PATCHv3 1/3] qemu/msi: fix segfault in msix_save
Date: Sun, 5 Jul 2009 14:10:47 +0300 [thread overview]
Message-ID: <20090705111046.GA4017@redhat.com> (raw)
In-Reply-To: <f43fc5580907050346u54388719n27f53d7cead8c9b1@mail.gmail.com>
On Sun, Jul 05, 2009 at 01:46:53PM +0300, Blue Swirl wrote:
> On 7/5/09, Michael S. Tsirkin <mst@redhat.com> wrote:
> > This fixes segfault reported by Kevin Wolf,
> > and simplifies the code in msix_save.
>
> > + if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
> > + return;
>
> Dubious: !x & y. You also forgot the braces.
Yes. Happens to work because QEMU_PCI_CAP_MSIX is 0x1.
I'll fix that, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org,
kvm@vger.kernel.org, avi@redhat.com
Subject: Re: [Qemu-devel] [PATCHv3 1/3] qemu/msi: fix segfault in msix_save
Date: Sun, 5 Jul 2009 14:10:47 +0300 [thread overview]
Message-ID: <20090705111046.GA4017@redhat.com> (raw)
In-Reply-To: <f43fc5580907050346u54388719n27f53d7cead8c9b1@mail.gmail.com>
On Sun, Jul 05, 2009 at 01:46:53PM +0300, Blue Swirl wrote:
> On 7/5/09, Michael S. Tsirkin <mst@redhat.com> wrote:
> > This fixes segfault reported by Kevin Wolf,
> > and simplifies the code in msix_save.
>
> > + if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
> > + return;
>
> Dubious: !x & y. You also forgot the braces.
Yes. Happens to work because QEMU_PCI_CAP_MSIX is 0x1.
I'll fix that, thanks!
next prev parent reply other threads:[~2009-07-05 11:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1246782566.git.mst@redhat.com>
2009-07-05 10:24 ` [PATCHv3 1/3] qemu/msi: fix segfault in msix_save Michael S. Tsirkin
2009-07-05 10:24 ` [Qemu-devel] " Michael S. Tsirkin
2009-07-05 10:45 ` Stuart Brady
2009-07-05 19:47 ` Michael S. Tsirkin
2009-07-05 20:12 ` Blue Swirl
2009-07-05 10:46 ` Blue Swirl
2009-07-05 10:46 ` Blue Swirl
2009-07-05 11:10 ` Michael S. Tsirkin [this message]
2009-07-05 11:10 ` Michael S. Tsirkin
2009-07-05 10:24 ` [PATCHv3 2/3] qemu/virtio: remove control vector save Michael S. Tsirkin
2009-07-05 10:24 ` [Qemu-devel] " Michael S. Tsirkin
2009-07-05 10:24 ` [PATCHv3 3/3] qemu/virtio: mark msi vectors used on load Michael S. Tsirkin
2009-07-05 10:24 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090705111046.GA4017@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.