From: Vivek Goyal <vgoyal@redhat.com> To: Gui Jianfeng <guijianfeng@cn.fujitsu.com> Cc: linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, dm-devel@redhat.com, jens.axboe@oracle.com, ryov@valinux.co.jp, balbir@linux.vnet.ibm.com, righi.andrea@gmail.com, nauman@google.com, dpshah@google.com, lizf@cn.fujitsu.com, mikew@google.com, fchecconi@gmail.com, paolo.valente@unimore.it, fernando@oss.ntt.co.jp, s-uchida@ap.jp.nec.com, taka@valinux.co.jp, jmoyer@redhat.com, dhaval@linux.vnet.ibm.com, m-ikeda@ds.jp.nec.com, agk@redhat.com, akpm@linux-foundation.org, peterz@infradead.org, jmarchan@redhat.com Subject: Re: [PATCH 02/24] io-controller: Core of the elevator fair queuing Date: Thu, 27 Aug 2009 17:08:48 -0400 [thread overview] Message-ID: <20090827210848.GA3821@redhat.com> (raw) In-Reply-To: <4A95F444.9040705@cn.fujitsu.com> On Thu, Aug 27, 2009 at 10:49:40AM +0800, Gui Jianfeng wrote: > Vivek Goyal wrote: > ... > > +static void update_min_vdisktime(struct io_service_tree *st) > > +{ > > + u64 vdisktime; > > + > > + if (st->active_entity) > > + vdisktime = st->active_entity->vdisktime; > > + > > + if (st->rb_leftmost) { > > + struct io_entity *entity = rb_entry(st->rb_leftmost, > > + struct io_entity, rb_node); > > + > > + if (!st->active_entity) > > + vdisktime = entity->vdisktime; > > + else > > + vdisktime = min_vdisktime(vdisktime, entity->vdisktime); > > + } > > + > > + st->min_vdisktime = max_vdisktime(st->min_vdisktime, vdisktime); > > +} > > block/elevator-fq.c: In function ‘elv_ioq_slice_expired’: > block/elevator-fq.c:132: warning: ‘vdisktime’ may be used uninitialized in this function > LD block/built-in.o > > We'd better initialize vdisktime at first. > Thanks Gui. Will fix in next posting. Vivek > Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com> > --- > block/elevator-fq.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/block/elevator-fq.c b/block/elevator-fq.c > index d04e925..a4161c2 100644 > --- a/block/elevator-fq.c > +++ b/block/elevator-fq.c > @@ -131,6 +131,8 @@ static void update_min_vdisktime(struct io_service_tree *st) > { > u64 vdisktime; > > + vdisktime = st->min_vdisktime; > + > if (st->active_entity) > vdisktime = st->active_entity->vdisktime; > > -- > 1.5.4.rc3
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com> To: Gui Jianfeng <guijianfeng@cn.fujitsu.com> Cc: dhaval@linux.vnet.ibm.com, peterz@infradead.org, dm-devel@redhat.com, dpshah@google.com, jens.axboe@oracle.com, agk@redhat.com, balbir@linux.vnet.ibm.com, paolo.valente@unimore.it, jmarchan@redhat.com, fernando@oss.ntt.co.jp, mikew@google.com, jmoyer@redhat.com, nauman@google.com, m-ikeda@ds.jp.nec.com, lizf@cn.fujitsu.com, fchecconi@gmail.com, s-uchida@ap.jp.nec.com, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, righi.andrea@gmail.com Subject: Re: [PATCH 02/24] io-controller: Core of the elevator fair queuing Date: Thu, 27 Aug 2009 17:08:48 -0400 [thread overview] Message-ID: <20090827210848.GA3821@redhat.com> (raw) In-Reply-To: <4A95F444.9040705@cn.fujitsu.com> On Thu, Aug 27, 2009 at 10:49:40AM +0800, Gui Jianfeng wrote: > Vivek Goyal wrote: > ... > > +static void update_min_vdisktime(struct io_service_tree *st) > > +{ > > + u64 vdisktime; > > + > > + if (st->active_entity) > > + vdisktime = st->active_entity->vdisktime; > > + > > + if (st->rb_leftmost) { > > + struct io_entity *entity = rb_entry(st->rb_leftmost, > > + struct io_entity, rb_node); > > + > > + if (!st->active_entity) > > + vdisktime = entity->vdisktime; > > + else > > + vdisktime = min_vdisktime(vdisktime, entity->vdisktime); > > + } > > + > > + st->min_vdisktime = max_vdisktime(st->min_vdisktime, vdisktime); > > +} > > block/elevator-fq.c: In function ‘elv_ioq_slice_expired’: > block/elevator-fq.c:132: warning: ‘vdisktime’ may be used uninitialized in this function > LD block/built-in.o > > We'd better initialize vdisktime at first. > Thanks Gui. Will fix in next posting. Vivek > Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com> > --- > block/elevator-fq.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/block/elevator-fq.c b/block/elevator-fq.c > index d04e925..a4161c2 100644 > --- a/block/elevator-fq.c > +++ b/block/elevator-fq.c > @@ -131,6 +131,8 @@ static void update_min_vdisktime(struct io_service_tree *st) > { > u64 vdisktime; > > + vdisktime = st->min_vdisktime; > + > if (st->active_entity) > vdisktime = st->active_entity->vdisktime; > > -- > 1.5.4.rc3
next prev parent reply other threads:[~2009-08-27 21:09 UTC|newest] Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-08-16 19:30 [RFC] IO scheduler based IO controller V8 Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 01/24] io-controller: Documentation Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal [not found] ` <1250451046-9966-2-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-25 3:36 ` Rik van Riel 2009-08-25 3:36 ` Rik van Riel 2009-08-25 3:36 ` Rik van Riel 2009-08-16 19:30 ` [PATCH 02/24] io-controller: Core of the elevator fair queuing Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-17 5:29 ` Gui Jianfeng 2009-08-17 5:29 ` Gui Jianfeng 2009-08-17 20:37 ` Vivek Goyal 2009-08-17 20:37 ` Vivek Goyal [not found] ` <4A88EACC.6010805-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> 2009-08-17 20:37 ` Vivek Goyal 2009-08-19 16:01 ` Jerome Marchand 2009-08-19 18:41 ` Vivek Goyal 2009-08-19 18:41 ` Vivek Goyal 2009-08-20 14:51 ` Jerome Marchand 2009-08-20 15:04 ` Vivek Goyal 2009-08-20 15:04 ` Vivek Goyal [not found] ` <4A8D6302.3080301-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-20 15:04 ` Vivek Goyal [not found] ` <20090819184142.GD4391-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-20 14:51 ` Jerome Marchand [not found] ` <4A8C21DE.1080001-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-19 18:41 ` Vivek Goyal 2009-08-19 18:30 ` Vivek Goyal 2009-08-19 18:30 ` Vivek Goyal 2009-08-21 1:54 ` Gui Jianfeng [not found] ` <4A8DFE3A.6030503-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> 2009-08-21 2:00 ` Vivek Goyal 2009-08-21 2:00 ` Vivek Goyal 2009-08-21 2:00 ` Vivek Goyal [not found] ` <1250451046-9966-3-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-17 5:29 ` Gui Jianfeng 2009-08-19 16:01 ` Jerome Marchand 2009-08-19 18:30 ` Vivek Goyal 2009-08-21 1:54 ` Gui Jianfeng 2009-08-27 2:49 ` Gui Jianfeng 2009-08-27 2:49 ` Gui Jianfeng 2009-08-27 21:08 ` Vivek Goyal [this message] 2009-08-27 21:08 ` Vivek Goyal [not found] ` <4A95F444.9040705-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> 2009-08-27 21:08 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 03/24] io-controller: Common flat fair queuing code in elevaotor layer Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-19 3:36 ` Gui Jianfeng [not found] ` <4A8B7336.7010800-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> 2009-08-19 18:39 ` Vivek Goyal 2009-08-19 18:39 ` Vivek Goyal 2009-08-19 18:39 ` Vivek Goyal [not found] ` <1250451046-9966-4-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-19 3:36 ` Gui Jianfeng 2009-08-19 3:36 ` Gui Jianfeng 2009-08-16 19:30 ` [PATCH 04/24] io-controller: Modify cfq to make use of flat elevator fair queuing Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 05/24] io-controller: Core scheduler changes to support hierarhical scheduling Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 06/24] io-controller: cgroup related changes for hierarchical group support Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 07/24] io-controller: Common hierarchical fair queuing code in elevaotor layer Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal [not found] ` <1250451046-9966-1-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-16 19:30 ` [PATCH 01/24] io-controller: Documentation Vivek Goyal 2009-08-16 19:30 ` [PATCH 02/24] io-controller: Core of the elevator fair queuing Vivek Goyal 2009-08-16 19:30 ` [PATCH 03/24] io-controller: Common flat fair queuing code in elevaotor layer Vivek Goyal 2009-08-16 19:30 ` [PATCH 04/24] io-controller: Modify cfq to make use of flat elevator fair queuing Vivek Goyal 2009-08-16 19:30 ` [PATCH 05/24] io-controller: Core scheduler changes to support hierarhical scheduling Vivek Goyal 2009-08-16 19:30 ` [PATCH 06/24] io-controller: cgroup related changes for hierarchical group support Vivek Goyal 2009-08-16 19:30 ` [PATCH 07/24] io-controller: Common hierarchical fair queuing code in elevaotor layer Vivek Goyal 2009-08-16 19:30 ` [PATCH 08/24] io-controller: cfq changes to use " Vivek Goyal 2009-08-16 19:30 ` [PATCH 09/24] io-controller: Export disk time used and nr sectors dipatched through cgroups Vivek Goyal 2009-08-16 19:30 ` [PATCH 10/24] io-controller: Debug hierarchical IO scheduling Vivek Goyal 2009-08-16 19:30 ` [PATCH 11/24] io-controller: Introduce group idling Vivek Goyal 2009-08-16 19:30 ` [PATCH 12/24] io-controller: Wait for requests to complete from last queue before new queue is scheduled Vivek Goyal 2009-08-16 19:30 ` [PATCH 13/24] io-controller: Separate out queue and data Vivek Goyal 2009-08-16 19:30 ` [PATCH 14/24] io-conroller: Prepare elevator layer for single queue schedulers Vivek Goyal 2009-08-16 19:30 ` [PATCH 15/24] io-controller: noop changes for hierarchical fair queuing Vivek Goyal 2009-08-16 19:30 ` [PATCH 16/24] io-controller: deadline " Vivek Goyal 2009-08-16 19:30 ` [PATCH 17/24] io-controller: anticipatory " Vivek Goyal 2009-08-16 19:30 ` [PATCH 18/24] blkio_cgroup patches from Ryo to track async bios Vivek Goyal 2009-08-16 19:30 ` [PATCH 19/24] io-controller: map async requests to appropriate cgroup Vivek Goyal 2009-08-16 19:30 ` [PATCH 20/24] io-controller: Per cgroup request descriptor support Vivek Goyal 2009-08-16 19:30 ` [PATCH 21/24] io-controller: Per io group bdi congestion interface Vivek Goyal 2009-08-16 19:30 ` [PATCH 22/24] io-controller: Support per cgroup per device weights and io class Vivek Goyal 2009-08-16 19:30 ` [PATCH 23/24] io-controller: map sync requests to group using bio tracking info Vivek Goyal 2009-08-16 19:30 ` [PATCH 24/24] io-controller: debug elevator fair queuing support Vivek Goyal 2009-08-16 19:53 ` [RFC] IO scheduler based IO controller V8 Vivek Goyal 2009-08-16 19:30 ` [PATCH 08/24] io-controller: cfq changes to use hierarchical fair queuing code in elevaotor layer Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 09/24] io-controller: Export disk time used and nr sectors dipatched through cgroups Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 10/24] io-controller: Debug hierarchical IO scheduling Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 11/24] io-controller: Introduce group idling Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-20 1:46 ` [PATCH] IO-Controller: clear ioq wait flag if a request goes into that ioq Gui Jianfeng [not found] ` <4A8CAAE2.1030804-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> 2009-08-20 13:42 ` Vivek Goyal 2009-08-20 13:42 ` Vivek Goyal 2009-08-20 13:42 ` Vivek Goyal [not found] ` <20090820134221.GC10615-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-21 0:57 ` Gui Jianfeng 2009-08-21 0:57 ` Gui Jianfeng [not found] ` <1250451046-9966-12-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-20 1:46 ` Gui Jianfeng 2009-08-28 1:12 ` [PATCH 11/24] io-controller: Introduce group idling Gui Jianfeng 2009-08-28 1:12 ` Gui Jianfeng 2009-08-28 1:12 ` Gui Jianfeng 2009-08-16 19:30 ` [PATCH 12/24] io-controller: Wait for requests to complete from last queue before new queue is scheduled Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-24 3:30 ` Gui Jianfeng [not found] ` <1250451046-9966-13-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-24 3:30 ` Gui Jianfeng 2009-08-16 19:30 ` [PATCH 13/24] io-controller: Separate out queue and data Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 14/24] io-conroller: Prepare elevator layer for single queue schedulers Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 15/24] io-controller: noop changes for hierarchical fair queuing Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 16/24] io-controller: deadline " Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 17/24] io-controller: anticipatory " Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 18/24] blkio_cgroup patches from Ryo to track async bios Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-18 11:42 ` Ryo Tsuruta 2009-08-18 11:42 ` Ryo Tsuruta [not found] ` <20090818.204212.59676649.ryov-jCdQPDEk3idL9jVzuh4AOg@public.gmane.org> 2009-08-18 14:26 ` Vivek Goyal 2009-08-18 14:26 ` Vivek Goyal 2009-08-18 14:26 ` Vivek Goyal 2009-08-19 1:43 ` Ryo Tsuruta [not found] ` <20090818142636.GA7367-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-19 1:43 ` Ryo Tsuruta [not found] ` <1250451046-9966-19-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2009-08-18 11:42 ` Ryo Tsuruta 2009-08-16 19:30 ` [PATCH 19/24] io-controller: map async requests to appropriate cgroup Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 20/24] io-controller: Per cgroup request descriptor support Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 21/24] io-controller: Per io group bdi congestion interface Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 22/24] io-controller: Support per cgroup per device weights and io class Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 23/24] io-controller: map sync requests to group using bio tracking info Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:30 ` [PATCH 24/24] io-controller: debug elevator fair queuing support Vivek Goyal 2009-08-16 19:30 ` Vivek Goyal 2009-08-16 19:53 ` [RFC] IO scheduler based IO controller V8 Vivek Goyal 2009-08-16 19:53 ` Vivek Goyal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090827210848.GA3821@redhat.com \ --to=vgoyal@redhat.com \ --cc=agk@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=balbir@linux.vnet.ibm.com \ --cc=containers@lists.linux-foundation.org \ --cc=dhaval@linux.vnet.ibm.com \ --cc=dm-devel@redhat.com \ --cc=dpshah@google.com \ --cc=fchecconi@gmail.com \ --cc=fernando@oss.ntt.co.jp \ --cc=guijianfeng@cn.fujitsu.com \ --cc=jens.axboe@oracle.com \ --cc=jmarchan@redhat.com \ --cc=jmoyer@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lizf@cn.fujitsu.com \ --cc=m-ikeda@ds.jp.nec.com \ --cc=mikew@google.com \ --cc=nauman@google.com \ --cc=paolo.valente@unimore.it \ --cc=peterz@infradead.org \ --cc=righi.andrea@gmail.com \ --cc=ryov@valinux.co.jp \ --cc=s-uchida@ap.jp.nec.com \ --cc=taka@valinux.co.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.