Re: [PATCH 00/24] configure and Makefile cleanup

From: Marcelo Tosatti <mtosatti@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 00/24] configure and Makefile cleanup
Date: Fri, 18 Sep 2009 16:57:14 -0300	[thread overview]
Message-ID: <20090918195714.GC16767@amt.cnet> (raw)
In-Reply-To: <cover.1253272938.git.quintela@redhat.com>

On Fri, Sep 18, 2009 at 01:41:08PM +0200, Juan Quintela wrote:
> This series:
> - werror is not disabled unconditoanally, you can disable it with
>   --disable-werror.
> - clean configure and Makefile* of mis-merges
> - sync such files to qemu upstream
> - kvm options are detected and configured _after_ detecting kvm, not
>   the other way around
> - add command line options and change styse so kvm-cap-pit and
>   kvm-cap-device-assignment looks like the other options.  Bring command
>   line flags to enable/disable them, and fix code to compile.
> - CONFIG_CPU_EMULATION is back, and it works (it is still a hack, proper
>   fix means moving code to new files and other conditional compilation, better
>   to do it at qemu upstream.
> - Why do we define "-D__user=" for gcc?  Nothing uses it (/me guess sparse
>   missmerge)
> 
> What I didn't touch:
> - kvm-kmod.
> - CFLAGS += $(KVM_CFLAGS)
>   on Makefile.target, only 4-5 files need them.  Didn't investigate too much
>   into it.
> - I only tested it on x86_64, i386 should work. powerpc/ia64 -> dunno.
> 
> For upstream:
> - kvm_cflags reorganization: make sense
> - KVM_CAP_PIT: haven't looked how much support is missing there
> - DEVICE_ASSIGNMENT: idem
> - CONFIG_CPU_EMULATION: Proper implementation is not trivial. What is in
>   qemu-kvm is a hack, proper integration requires moving code back and forth.
>   Not sure how important is to have this option.
> 
> Comments?

Juan,

Thanks for doing this.

I've applied all patches except those replied to.