Re: [PATCH 01/24] Don't disable werror unconditionally

From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 01/24] Don't disable werror unconditionally
Date: Sat, 19 Sep 2009 13:13:26 +0300	[thread overview]
Message-ID: <4AB4AEC6.4090201@redhat.com> (raw)
In-Reply-To: <20090918190256.GA14562@amt.cnet>

On 09/18/2009 10:02 PM, Marcelo Tosatti wrote:
> On Fri, Sep 18, 2009 at 01:41:10PM +0200, Juan Quintela wrote:
>    
>> Signed-off-by: Juan Quintela<quintela@redhat.com>
>> ---
>>   configure |    2 --
>>   1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 97292d9..e6252a2 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1758,8 +1758,6 @@ if test -z "$werror" ; then
>>       else
>>           werror="no"
>>       fi
>> -    # disable default werror for kvm
>> -    werror="no"
>>   fi
>>
>>   if test "$werror" = "yes" ; then
>>      
> Don't know why Avi added this.
>    

The merge which introduced this also introduced warnings into qemu-kvm.  
If the warnings are gone, it's better to restore -Werror to upstream 
behaviour.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.