All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Kyungmin Park <kmpark@infradead.org>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	soni.trilok@gmail.com
Subject: Re: [PATCH] Haptic class support (v2)
Date: Mon, 12 Oct 2009 17:20:20 +0100	[thread overview]
Message-ID: <20091012162020.GF22233@sirena.org.uk> (raw)
In-Reply-To: <ac3eb2510910120842m3129b76fyaa11b509e7f97038@mail.gmail.com>

On Mon, Oct 12, 2009 at 05:42:08PM +0200, Kay Sievers wrote:
> On Tue, Oct 6, 2009 at 09:45, Kyungmin Park <kmpark@infradead.org> wrote:

> > To enable the haptic, echo 1 > /sys/class/haptic/${name}/enable
> > You can adjust the level by echo ${level} > /sys/class/haptic/${name}/enable
> > or
> > With oneshot feature, echo ${msec time} > /sys/class/haptic/${name}/oneshot

> Please never add any custom files to the top-level of a class
> directory. This place is reserved for devices, and not for custom
> files. It's a serious bug in the layout and API of sysfs that this
> allowed at all.

I'm assuming that ${name} is the device name in the above in which case
it should be fine from that point of view?

  reply	other threads:[~2009-10-12 16:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-06  7:45 [PATCH] Haptic class support (v2) Kyungmin Park
2009-10-06 15:25 ` Randy Dunlap
2009-10-06 18:35 ` Trilok Soni
2009-10-06 18:35   ` Trilok Soni
2009-10-07  5:13   ` Kyungmin Park
2009-10-11  9:05 ` Pavel Machek
2009-10-12  0:32   ` Kyungmin Park
2009-10-12 13:44     ` Trilok Soni
2009-10-12 14:40       ` Greg KH
2009-10-12 14:40         ` Greg KH
2009-10-13 11:05     ` Pavel Machek
2009-10-12 15:42 ` Kay Sievers
2009-10-12 16:20   ` Mark Brown [this message]
2009-10-13 16:45 ` Kay Sievers
2009-10-20  6:44   ` Trilok Soni
2009-10-20  6:44     ` Trilok Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091012162020.GF22233@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=kay.sievers@vrfy.org \
    --cc=kmpark@infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=soni.trilok@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.