Re: [PATCH] Haptic class support (v2)

From: Greg KH <greg@kroah.com>
To: Trilok Soni <soni.trilok@gmail.com>
Cc: Kyungmin Park <kmpark@infradead.org>, Pavel Machek <pavel@ucw.cz>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH] Haptic class support (v2)
Date: Mon, 12 Oct 2009 07:40:23 -0700	[thread overview]
Message-ID: <20091012144023.GB1239@kroah.com> (raw)
In-Reply-To: <5d5443650910120644x4180ff6bt45b72be86b50588f@mail.gmail.com>

On Mon, Oct 12, 2009 at 07:14:57PM +0530, Trilok Soni wrote:
> Hi Kyungmin,
> 
> On Mon, Oct 12, 2009 at 6:02 AM, Kyungmin Park <kmpark@infradead.org> wrote:
> > On Sun, Oct 11, 2009 at 6:05 PM, Pavel Machek <pavel@ucw.cz> wrote:
> >> On Tue 2009-10-06 16:45:33, Kyungmin Park wrote:
> >>> This patch includes two haptic devices, isa1000 and isa1200
> >>> ISA1000 is gpio based haptic, but isa1200 is based on I2C
> >>> Both are working on Samsung SoCs and tested.
> >>>
> >>> To enable the haptic, echo 1 > /sys/class/haptic/${name}/enable
> >>> You can adjust the level by echo ${level} > /sys/class/haptic/${name}/enable
> >>> or
> >>> With oneshot feature, echo ${msec time} > /sys/class/haptic/${name}/oneshot
> >>
> >> New device classes should certainly be documented in Documentation/.
> >>
> >> For example... is level 0-100?
> >
> > Basically. range from 0 to 255. also each device can set max level in
> > case of isa1000 it's 6.
> >
> >>  Is it valid to change level while 'oneshot' is running?
> >
> > we usually use it under 1 sec. but I think it's possible to change it
> > but not tried.
> >
> >>  Does oneshot use last level set?
> >
> > Right. it used last set value.
> >
> > If you don't mind to update these at Documentation please wait until
> > commit first patches merged.
> 
> Let's see what Greg prefers. Could you please refresh your patchset
> with probably addressing comments given in the isa1200 and samsung_pwm
> driver by me?

Greg wants to see patches that add sysfs files to the kernel, also
contain Documentation/ABI/ updates as well.

thanks,

greg k-h