Re: [PATCH v7 3/5] OMAP: McBSP: Introduce caching in register write operations

From: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
	Peter Ujfalusi <peter.ujfalusi@nokia.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH v7 3/5] OMAP: McBSP: Introduce caching in register write operations
Date: Fri, 11 Dec 2009 14:51:27 +0100	[thread overview]
Message-ID: <200912111451.29185.jkrzyszt@tis.icnet.pl> (raw)
In-Reply-To: <20091211151149.c20acce5.jhnikula@gmail.com>

Friday 11 December 2009 14:11:49 Jarkko Nikula napisał(a):
> On Wed, 9 Dec 2009 21:31:20 +0100
>
> Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:
> > @@ -391,6 +405,10 @@ int omap_mcbsp_request(unsigned int id)
> >  	}
> >  	mcbsp = id_to_mcbsp_ptr(id);
> >
> > +	mcbsp->reg_cache = kzalloc(omap_mcbsp_cache_size, GFP_KERNEL);
> > +	if (!mcbsp->reg_cache)
> > +		return -ENOMEM;
> > +
> >  	spin_lock(&mcbsp->lock);
> >  	if (!mcbsp->free) {
> >  		dev_err(mcbsp->dev, "McBSP%d is currently in use\n",
>
> Great work. Could have my ack to patches 1-4 by moving the cache
> allocation after the mcbsp->free test lines. Memory leak and other
> badness would happen otherwise in case of multiple call to
> omap_mcbsp_request.

Yes, it's a bug, sorry.

> Just send an update to this mail if there is no comments to another
> patches.

OK.

Thanks,
Janusz

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html