Re: [PATCH v7 3/5] OMAP: McBSP: Introduce caching in register write operations

From: Jarkko Nikula <jhnikula@gmail.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Tony Lindgren <tony@atomide.com>,
	Peter Ujfalusi <peter.ujfalusi@nokia.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH v7 3/5] OMAP: McBSP: Introduce caching in register write operations
Date: Fri, 11 Dec 2009 15:11:49 +0200	[thread overview]
Message-ID: <20091211151149.c20acce5.jhnikula@gmail.com> (raw)
In-Reply-To: <200912092131.21517.jkrzyszt@tis.icnet.pl>

On Wed, 9 Dec 2009 21:31:20 +0100
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:

> @@ -391,6 +405,10 @@ int omap_mcbsp_request(unsigned int id)
>  	}
>  	mcbsp = id_to_mcbsp_ptr(id);
>  
> +	mcbsp->reg_cache = kzalloc(omap_mcbsp_cache_size, GFP_KERNEL);
> +	if (!mcbsp->reg_cache)
> +		return -ENOMEM;
> +
>  	spin_lock(&mcbsp->lock);
>  	if (!mcbsp->free) {
>  		dev_err(mcbsp->dev, "McBSP%d is currently in use\n",

Great work. Could have my ack to patches 1-4 by moving the cache
allocation after the mcbsp->free test lines. Memory leak and other
badness would happen otherwise in case of multiple call to
omap_mcbsp_request.

Just send an update to this mail if there is no comments to another
patches.

-- 
Jarkko