From: Felipe Balbi <felipe.balbi@nokia.com>
To: "ext Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: "Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
"Koskinen Aaro (Nokia-D/Helsinki)" <aaro.koskinen@nokia.com>,
David Brownell <david-b@pacbell.net>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
Anton Vorontsov <avorontsov@ru.mvista.com>,
Grazvydas Ignotas <notasas@gmail.com>,
"Chikkature Rajashekar, Madhusudhan" <madhu.cr@ti.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@openedhand.com>
Subject: Re: [RFC/PATCH 2/4] input: misc: twl4030: move to request_threaded_irq
Date: Mon, 14 Dec 2009 13:40:09 +0200 [thread overview]
Message-ID: <20091214114009.GI12526@nokia.com> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB02BC1421BD@dbde02.ent.ti.com>
Hi,
On Mon, Dec 14, 2009 at 12:31:11PM +0100, ext Shilimkar, Santosh wrote:
>In whole of the series the ISR you have converted to threads using threaded_irq are very
>small in size. They are like quick_change_handlers. So only advantage is the particular
>interrupt is masked for bit longer than with you change.
>
>I might be wrong here but it might introduce the spurious IRQ's because
>of bit of delay in the processing.What is the motive for this change ?
>Are we using this API as it suppose to be ?
the irq chip is connected through i2c and that mandate us to handle irqs
in thread context. Now that we have kernel-wise api for that, we're just
moving towards it instead of definint our own stuff and the lockdep
shortcuts we had to put before.
I boot tested these patches on a 3430-based board and it seems to be
working fine. Did a few tests with usb only. I can see I get the usb
presence irq correctly.
--
balbi
next prev parent reply other threads:[~2009-12-14 11:41 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 14:44 [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger Grazvydas Ignotas
2009-11-27 14:44 ` Grazvydas Ignotas
2009-11-27 14:54 ` Anton Vorontsov
2009-11-27 15:47 ` Grazvydas Ignotas
2009-11-27 16:23 ` Mark Brown
2009-11-30 18:45 ` Madhusudhan
2009-11-30 18:45 ` Madhusudhan
2009-11-30 18:58 ` Anton Vorontsov
2009-12-02 20:38 ` Grazvydas Ignotas
2009-12-02 20:38 ` Grazvydas Ignotas
2009-12-02 21:27 ` Anton Vorontsov
2009-12-02 21:27 ` Anton Vorontsov
2009-12-02 21:32 ` Grazvydas Ignotas
2009-11-30 21:33 ` Grazvydas Ignotas
2009-12-02 16:59 ` Madhusudhan
2009-12-02 16:59 ` Madhusudhan
2009-12-02 17:33 ` Felipe Balbi
2009-12-02 20:34 ` Grazvydas Ignotas
2009-12-02 20:49 ` Felipe Balbi
2009-12-02 20:49 ` Felipe Balbi
2009-12-02 21:29 ` Grazvydas Ignotas
2009-12-02 21:29 ` Grazvydas Ignotas
2009-12-02 21:54 ` Anton Vorontsov
2009-12-02 22:31 ` Felipe Balbi
2009-12-02 22:59 ` Anton Vorontsov
2009-12-03 8:39 ` Felipe Balbi
2009-12-03 10:55 ` Grazvydas Ignotas
2009-12-03 11:03 ` Felipe Balbi
2009-12-10 14:09 ` Grazvydas Ignotas
2009-12-10 14:18 ` Anton Vorontsov
2009-12-10 14:21 ` Felipe Balbi
2009-12-10 14:44 ` Anton Vorontsov
2009-12-10 16:51 ` Felipe Balbi
2009-12-10 20:51 ` Grazvydas Ignotas
2009-12-11 11:31 ` [RFC/PATCH 0/5] usb transceiver notifier Felipe Balbi
2009-12-11 11:31 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 1/5] usb: otg: add notifier support Felipe Balbi
2009-12-11 11:55 ` Mark Brown
2009-12-11 11:55 ` Mark Brown
2009-12-11 11:58 ` Felipe Balbi
2010-01-26 11:16 ` David Brownell
2010-01-26 13:11 ` Mark Brown
2010-01-26 13:35 ` David Brownell
2010-01-26 14:14 ` Felipe Balbi
2010-01-26 14:24 ` Oliver Neukum
2010-01-26 14:30 ` Felipe Balbi
2010-01-26 14:30 ` Felipe Balbi
2010-01-26 15:16 ` David Brownell
2010-01-26 15:21 ` David Brownell
2010-01-26 18:50 ` Felipe Balbi
2010-01-26 14:21 ` Mark Brown
2010-01-26 14:21 ` Mark Brown
2010-01-26 15:44 ` David Brownell
2010-01-26 16:13 ` Mark Brown
2010-01-26 14:10 ` Felipe Balbi
2010-01-26 14:19 ` Felipe Balbi
2010-01-26 15:33 ` David Brownell
2010-01-26 15:33 ` David Brownell
2010-01-26 15:07 ` David Brownell
2010-01-26 15:07 ` David Brownell
2010-01-26 19:09 ` Felipe Balbi
2010-01-26 19:15 ` Felipe Balbi
2010-01-26 19:15 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 2/5] usb: otg: twl4030: add support for notifier Felipe Balbi
2009-12-11 17:22 ` sai pavan
2009-12-11 17:22 ` sai pavan
2009-12-11 20:40 ` Felipe Balbi
2009-12-11 20:40 ` Felipe Balbi
2009-12-12 18:34 ` Mark Brown
2009-12-14 10:30 ` [RFC/PATCH 0/4] twl4030 threaded_irq support Felipe Balbi
2010-01-26 7:06 ` David Brownell
2010-01-26 7:06 ` David Brownell
2010-01-26 7:36 ` David Brownell
2010-01-26 7:36 ` David Brownell
2010-01-26 10:07 ` Mark Brown
2010-01-26 11:02 ` Felipe Balbi
2010-01-26 12:18 ` David Brownell
2010-01-26 12:18 ` David Brownell
2009-12-14 10:30 ` [RFC/PATCH 1/4] input: keyboard: twl4030: move to request_threaded_irq Felipe Balbi
2009-12-14 10:30 ` Felipe Balbi
2009-12-14 10:30 ` [RFC/PATCH 2/4] input: misc: " Felipe Balbi
2009-12-14 10:30 ` Felipe Balbi
2009-12-14 11:31 ` Shilimkar, Santosh
2009-12-14 11:40 ` Felipe Balbi [this message]
2009-12-14 13:16 ` Shilimkar, Santosh
2009-12-14 10:30 ` [RFC/PATCH 3/4] rtc: " Felipe Balbi
2009-12-14 10:30 ` [RFC/PATCH 4/4] usb: otg: " Felipe Balbi
2009-12-14 10:30 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 3/5] usb: musb: add support for ulpi block Felipe Balbi
2009-12-11 11:31 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 4/5] usb: musb: isp1704: add registers from isp1704 Felipe Balbi
2009-12-11 11:31 ` Felipe Balbi
2009-12-11 12:35 ` Krogerus Heikki (EXT-Teleca/Helsinki)
2009-12-11 12:35 ` Krogerus Heikki (EXT-Teleca/Helsinki)
2009-12-11 12:57 ` Felipe Balbi
2009-12-11 12:57 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 5/5] usb: musb: musb supports otg notifier Felipe Balbi
2009-12-11 11:40 ` Felipe Balbi
2009-12-11 11:40 ` Felipe Balbi
2009-12-30 19:07 ` [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger Madhusudhan
2009-12-30 19:07 ` Madhusudhan
2009-12-10 14:19 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091214114009.GI12526@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=aaro.koskinen@nokia.com \
--cc=avorontsov@ru.mvista.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=notasas@gmail.com \
--cc=sameo@openedhand.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.