From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: Madhusudhan <madhu.cr@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger
Date: Thu, 3 Dec 2009 00:27:10 +0300 [thread overview]
Message-ID: <20091202212710.GA24789@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <6ed0b2680912021238o29d7e773i9379369d7b277614@mail.gmail.com>
On Wed, Dec 02, 2009 at 10:38:31PM +0200, Grazvydas Ignotas wrote:
> On Mon, Nov 30, 2009 at 8:58 PM, Anton Vorontsov
> <avorontsov@ru.mvista.com> wrote:
> > On Mon, Nov 30, 2009 at 12:45:20PM -0600, Madhusudhan wrote:
> > [...]
> >> > + case POWER_SUPPLY_PROP_VOLTAGE_NOW:
> >> > + /* charging must be active for meaningful result */
> >> > + if (!is_charging) {
> >>
> >> How about putting a kern_info here?
> >
> > It might be better to return -EINVAL.
>
> That causes lots of warnings from power_supply core (driver failed to
> report XXX property), Not sure what to do here, I'd prefer to keep
> returning 0.
Lying to userspace is a bad idea.
How about this patch + changing the driver to return -ENODATA?
>From 0fe4c834b551c4d4454d57acaf75645675d199ee Mon Sep 17 00:00:00 2001
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Date: Thu, 3 Dec 2009 00:24:51 +0300
Subject: [PATCH] power_supply_sysfs: Handle -ENODATA in a special way
There are cases when some device can not report any meaningful value,
e.g. TWL4030 charger can report voltage only when charging is
active.
In these cases drivers will return -ENODATA, and we shouldn't flood
kernel log with error messages.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
drivers/power/power_supply_sysfs.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
index 0814439..c790e0c 100644
--- a/drivers/power/power_supply_sysfs.c
+++ b/drivers/power/power_supply_sysfs.c
@@ -65,7 +65,10 @@ static ssize_t power_supply_show_property(struct device *dev,
ret = psy->get_property(psy, off, &value);
if (ret < 0) {
- if (ret != -ENODEV)
+ if (ret == -ENODATA)
+ dev_dbg(dev, "driver has no data for `%s' property\n",
+ attr->attr.name);
+ else if (ret != -ENODEV)
dev_err(dev, "driver failed to report `%s' property\n",
attr->attr.name);
return ret;
--
1.6.3.3
WARNING: multiple messages have this Message-ID (diff)
From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: Madhusudhan <madhu.cr@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger
Date: Thu, 3 Dec 2009 00:27:10 +0300 [thread overview]
Message-ID: <20091202212710.GA24789@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <6ed0b2680912021238o29d7e773i9379369d7b277614@mail.gmail.com>
On Wed, Dec 02, 2009 at 10:38:31PM +0200, Grazvydas Ignotas wrote:
> On Mon, Nov 30, 2009 at 8:58 PM, Anton Vorontsov
> <avorontsov@ru.mvista.com> wrote:
> > On Mon, Nov 30, 2009 at 12:45:20PM -0600, Madhusudhan wrote:
> > [...]
> >> > + case POWER_SUPPLY_PROP_VOLTAGE_NOW:
> >> > + /* charging must be active for meaningful result */
> >> > + if (!is_charging) {
> >>
> >> How about putting a kern_info here?
> >
> > It might be better to return -EINVAL.
>
> That causes lots of warnings from power_supply core (driver failed to
> report XXX property), Not sure what to do here, I'd prefer to keep
> returning 0.
Lying to userspace is a bad idea.
How about this patch + changing the driver to return -ENODATA?
From 0fe4c834b551c4d4454d57acaf75645675d199ee Mon Sep 17 00:00:00 2001
From: Anton Vorontsov <avorontsov@ru.mvista.com>
Date: Thu, 3 Dec 2009 00:24:51 +0300
Subject: [PATCH] power_supply_sysfs: Handle -ENODATA in a special way
There are cases when some device can not report any meaningful value,
e.g. TWL4030 charger can report voltage only when charging is
active.
In these cases drivers will return -ENODATA, and we shouldn't flood
kernel log with error messages.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
drivers/power/power_supply_sysfs.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/power/power_supply_sysfs.c b/drivers/power/power_supply_sysfs.c
index 0814439..c790e0c 100644
--- a/drivers/power/power_supply_sysfs.c
+++ b/drivers/power/power_supply_sysfs.c
@@ -65,7 +65,10 @@ static ssize_t power_supply_show_property(struct device *dev,
ret = psy->get_property(psy, off, &value);
if (ret < 0) {
- if (ret != -ENODEV)
+ if (ret == -ENODATA)
+ dev_dbg(dev, "driver has no data for `%s' property\n",
+ attr->attr.name);
+ else if (ret != -ENODEV)
dev_err(dev, "driver failed to report `%s' property\n",
attr->attr.name);
return ret;
--
1.6.3.3
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-12-02 21:27 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 14:44 [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger Grazvydas Ignotas
2009-11-27 14:44 ` Grazvydas Ignotas
2009-11-27 14:54 ` Anton Vorontsov
2009-11-27 15:47 ` Grazvydas Ignotas
2009-11-27 16:23 ` Mark Brown
2009-11-30 18:45 ` Madhusudhan
2009-11-30 18:45 ` Madhusudhan
2009-11-30 18:58 ` Anton Vorontsov
2009-12-02 20:38 ` Grazvydas Ignotas
2009-12-02 20:38 ` Grazvydas Ignotas
2009-12-02 21:27 ` Anton Vorontsov [this message]
2009-12-02 21:27 ` Anton Vorontsov
2009-12-02 21:32 ` Grazvydas Ignotas
2009-11-30 21:33 ` Grazvydas Ignotas
2009-12-02 16:59 ` Madhusudhan
2009-12-02 16:59 ` Madhusudhan
2009-12-02 17:33 ` Felipe Balbi
2009-12-02 20:34 ` Grazvydas Ignotas
2009-12-02 20:49 ` Felipe Balbi
2009-12-02 20:49 ` Felipe Balbi
2009-12-02 21:29 ` Grazvydas Ignotas
2009-12-02 21:29 ` Grazvydas Ignotas
2009-12-02 21:54 ` Anton Vorontsov
2009-12-02 22:31 ` Felipe Balbi
2009-12-02 22:59 ` Anton Vorontsov
2009-12-03 8:39 ` Felipe Balbi
2009-12-03 10:55 ` Grazvydas Ignotas
2009-12-03 11:03 ` Felipe Balbi
2009-12-10 14:09 ` Grazvydas Ignotas
2009-12-10 14:18 ` Anton Vorontsov
2009-12-10 14:21 ` Felipe Balbi
2009-12-10 14:44 ` Anton Vorontsov
2009-12-10 16:51 ` Felipe Balbi
2009-12-10 20:51 ` Grazvydas Ignotas
2009-12-11 11:31 ` [RFC/PATCH 0/5] usb transceiver notifier Felipe Balbi
2009-12-11 11:31 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 1/5] usb: otg: add notifier support Felipe Balbi
2009-12-11 11:55 ` Mark Brown
2009-12-11 11:55 ` Mark Brown
2009-12-11 11:58 ` Felipe Balbi
2010-01-26 11:16 ` David Brownell
2010-01-26 13:11 ` Mark Brown
2010-01-26 13:35 ` David Brownell
2010-01-26 14:14 ` Felipe Balbi
2010-01-26 14:24 ` Oliver Neukum
2010-01-26 14:30 ` Felipe Balbi
2010-01-26 14:30 ` Felipe Balbi
2010-01-26 15:16 ` David Brownell
2010-01-26 15:21 ` David Brownell
2010-01-26 18:50 ` Felipe Balbi
2010-01-26 14:21 ` Mark Brown
2010-01-26 14:21 ` Mark Brown
2010-01-26 15:44 ` David Brownell
2010-01-26 16:13 ` Mark Brown
2010-01-26 14:10 ` Felipe Balbi
2010-01-26 14:19 ` Felipe Balbi
2010-01-26 15:33 ` David Brownell
2010-01-26 15:33 ` David Brownell
2010-01-26 15:07 ` David Brownell
2010-01-26 15:07 ` David Brownell
2010-01-26 19:09 ` Felipe Balbi
2010-01-26 19:15 ` Felipe Balbi
2010-01-26 19:15 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 2/5] usb: otg: twl4030: add support for notifier Felipe Balbi
2009-12-11 17:22 ` sai pavan
2009-12-11 17:22 ` sai pavan
2009-12-11 20:40 ` Felipe Balbi
2009-12-11 20:40 ` Felipe Balbi
2009-12-12 18:34 ` Mark Brown
2009-12-14 10:30 ` [RFC/PATCH 0/4] twl4030 threaded_irq support Felipe Balbi
2010-01-26 7:06 ` David Brownell
2010-01-26 7:06 ` David Brownell
2010-01-26 7:36 ` David Brownell
2010-01-26 7:36 ` David Brownell
2010-01-26 10:07 ` Mark Brown
2010-01-26 11:02 ` Felipe Balbi
2010-01-26 12:18 ` David Brownell
2010-01-26 12:18 ` David Brownell
2009-12-14 10:30 ` [RFC/PATCH 1/4] input: keyboard: twl4030: move to request_threaded_irq Felipe Balbi
2009-12-14 10:30 ` Felipe Balbi
2009-12-14 10:30 ` [RFC/PATCH 2/4] input: misc: " Felipe Balbi
2009-12-14 10:30 ` Felipe Balbi
2009-12-14 11:31 ` Shilimkar, Santosh
2009-12-14 11:40 ` Felipe Balbi
2009-12-14 13:16 ` Shilimkar, Santosh
2009-12-14 10:30 ` [RFC/PATCH 3/4] rtc: " Felipe Balbi
2009-12-14 10:30 ` [RFC/PATCH 4/4] usb: otg: " Felipe Balbi
2009-12-14 10:30 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 3/5] usb: musb: add support for ulpi block Felipe Balbi
2009-12-11 11:31 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 4/5] usb: musb: isp1704: add registers from isp1704 Felipe Balbi
2009-12-11 11:31 ` Felipe Balbi
2009-12-11 12:35 ` Krogerus Heikki (EXT-Teleca/Helsinki)
2009-12-11 12:35 ` Krogerus Heikki (EXT-Teleca/Helsinki)
2009-12-11 12:57 ` Felipe Balbi
2009-12-11 12:57 ` Felipe Balbi
2009-12-11 11:31 ` [RFC/PATCH 5/5] usb: musb: musb supports otg notifier Felipe Balbi
2009-12-11 11:40 ` Felipe Balbi
2009-12-11 11:40 ` Felipe Balbi
2009-12-30 19:07 ` [PATCH] power_supply: Add driver for TWL4030/TPS65950 BCI charger Madhusudhan
2009-12-30 19:07 ` Madhusudhan
2009-12-10 14:19 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202212710.GA24789@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.