From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
"Moore, Robert" <robert.moore@intel.com>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
Linux PCI <linux-pci@vger.kernel.org>,
Shaohua Li <shaohua.li@intel.com>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
Oliver Neukum <oliver@neukum.org>,
Matthew Garrett <mjg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Gary Hade <garyhade@us.ibm.com>
Subject: Re: [PATCH 4/8] ACPI: Use GPE reference counting to support shared GPEs
Date: Thu, 18 Feb 2010 21:01:44 +0100 [thread overview]
Message-ID: <201002182101.44171.rjw@sisk.pl> (raw)
In-Reply-To: <4B7CE6A3.7020103@np.css.fujitsu.com>
On Thursday 18 February 2010, Jin Dongming wrote:
> Hi, Rafael J. Wysocki
> > - /* Update enable mask, but don't enable the HW GPE as of yet */
> > -
> > - status = acpi_ev_enable_gpe(gpe_event_info, FALSE);
You could preserve some more context.
> I think the above line code should be remained. If it is deleted, the exception
> event will be raised on some machine.
Why would it? The GPE is still disabled at the hardware level at this point.
Rafael
next prev parent reply other threads:[~2010-02-18 20:00 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 22:35 [PATCH 0/8] PCI run-time PM support (rev. 4) Rafael J. Wysocki
2010-02-17 22:36 ` [PATCH 1/8] PCI PM: Add function for checking PME status of devices Rafael J. Wysocki
2010-02-23 0:21 ` Jesse Barnes
2010-02-23 0:21 ` Jesse Barnes
2010-02-23 19:56 ` Rafael J. Wysocki
2010-02-23 19:56 ` Rafael J. Wysocki
2010-02-17 22:36 ` Rafael J. Wysocki
2010-02-17 22:39 ` [PATCH 2/8] PCI PM: PCIe PME root port service driver (rev. 5) Rafael J. Wysocki
2010-02-17 22:39 ` Rafael J. Wysocki
2010-02-18 4:08 ` Kenji Kaneshige
2010-02-18 4:08 ` Kenji Kaneshige
2010-02-18 19:57 ` Rafael J. Wysocki
2010-02-18 19:57 ` Rafael J. Wysocki
2010-02-19 2:07 ` Kenji Kaneshige
2010-02-19 2:07 ` Kenji Kaneshige
2010-02-17 22:40 ` [PATCH 3/8] PCI PM: Make it possible to force using INTx for PCIe PME signaling Rafael J. Wysocki
2010-02-17 22:40 ` Rafael J. Wysocki
2010-02-17 22:41 ` [PATCH 4/8] ACPI: Use GPE reference counting to support shared GPEs Rafael J. Wysocki
2010-02-18 7:05 ` Jin Dongming
2010-02-18 20:01 ` Rafael J. Wysocki
2010-02-18 20:01 ` Rafael J. Wysocki [this message]
2010-02-19 7:24 ` Jin Dongming
2010-02-19 21:08 ` Rafael J. Wysocki
2010-02-19 21:08 ` Rafael J. Wysocki
2010-02-19 7:24 ` Jin Dongming
2010-02-18 7:05 ` Jin Dongming
2010-02-17 22:41 ` Rafael J. Wysocki
2010-02-17 22:41 ` [PATCH 5/8] ACPI / PM: Add more run-time wake-up fields (rev. 2) Rafael J. Wysocki
2010-02-17 22:41 ` Rafael J. Wysocki
2010-02-17 22:42 ` [PATCH 6/8] ACPI / ACPICA: Multiple system notify handlers per device Rafael J. Wysocki
2010-02-17 22:42 ` Rafael J. Wysocki
2010-02-17 22:44 ` [PATCH 7/8] PCI / ACPI / PM: Platform support for PCI PME wake-up (rev. 9) Rafael J. Wysocki
2010-02-17 22:44 ` Rafael J. Wysocki
2010-02-17 22:44 ` [PATCH 8/8] PCI PM: Run-time callbacks for PCI bus type (rev. 2) Rafael J. Wysocki
2010-02-17 22:44 ` Rafael J. Wysocki
2010-02-19 21:23 [PATCH 4/8] ACPI: Use GPE reference counting to support shared GPEs Moore, Robert
2010-02-19 23:14 ` Rafael J. Wysocki
2010-02-24 22:05 ` Moore, Robert
2010-02-25 15:14 ` Alexey Starikovskiy
2010-02-25 19:56 ` Rafael J. Wysocki
2010-02-19 23:18 ` Rafael J. Wysocki
2010-02-19 23:18 ` Rafael J. Wysocki
2010-02-23 0:26 ` Jesse Barnes
2010-02-23 23:52 ` Rafael J. Wysocki
2010-02-23 23:52 ` Rafael J. Wysocki
2010-02-24 22:26 ` Jesse Barnes
2010-02-24 22:26 ` Jesse Barnes
2010-02-23 0:26 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002182101.44171.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=bjorn.helgaas@hp.com \
--cc=garyhade@us.ibm.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jin.dongming@np.css.fujitsu.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mjg@redhat.com \
--cc=oliver@neukum.org \
--cc=robert.moore@intel.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.