Re: [PATCH 4/8] ACPI: Use GPE reference counting to support shared GPEs

From: Alexey Starikovskiy <aystarik@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "Moore, Robert" <robert.moore@intel.com>,
	Matthew Garrett <mjg@redhat.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"Lin, Ming M" <ming.m.lin@intel.com>,
	"Brown, Len" <len.brown@intel.com>
Subject: Re: [PATCH 4/8] ACPI: Use GPE reference counting to support shared GPEs
Date: Thu, 25 Feb 2010 18:14:08 +0300	[thread overview]
Message-ID: <4B8693C0.4020701@gmail.com> (raw)
In-Reply-To: <201002200014.04936.rjw@sisk.pl>

Rafael J. Wysocki пишет:
> --- linux-2.6.orig/drivers/acpi/ec.c
> +++ linux-2.6/drivers/acpi/ec.c
> @@ -307,7 +307,11 @@ static int acpi_ec_transaction(struct ac
>  	pr_debug(PREFIX "transaction start\n");
>  	/* disable GPE during transaction if storm is detected */
>  	if (test_bit(EC_FLAGS_GPE_STORM, &ec->flags)) {
> -		acpi_disable_gpe(NULL, ec->gpe);
> +		/*
> +		 * It has to be disabled at the hardware level regardless of the
> +		 * GPE reference counting, so that it doesn't trigger.
> +		 */
> +		acpi_set_gpe(NULL, ec->gpe, ACPI_GPE_DISABLE);
>  	}
>   
EC should have non-shared GPE, according to spec. Thus, refcounting is
not needed here anyway.

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html